CR-1136 [ICT379] VHIP907: Verkoopprijzen: Falende test SalesPriceService

closed on 28 May 18

Author

Moderator

Reviewers

[ICT379] VHIP907: Verkoopprijzen: Falende test SalesPriceService

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 32

CacheAdminA_trunk2010 (root:) 0
- Folder AX/Uitgaand/VKP 0
  - Folder PrijsVerschilNrUitz 0 Remove
    - Folder impl 0 Remove
      - File PrijsUitzBuildCache.cls.xml 0 Remove
      - File PrijsUitzDixfConverter.cls.xml 0 Remove
      - File PrijsUitzDixfGenerator.cls.xml 0 Remove
      - File PrijsUitzIterator.cls.xml 0 Remove
- Folder AXimpl 0
  - Folder Admin/VKP 0
    - Folder SalesPriceService 0
      - File ProductData.cls.xml 0 Remove
      - File ProductDataFactory.cls.xml 0 Remove
      - File ProductDataLijst.cls.xml 0 Remove
    - File SalesPriceService.cls.xml 0 Remove
  - Folder Dynamics/SalesPriceOut 0
    - Folder impl 0 Remove
      - File SalesPriceService.cls.xml 0 Remove
  - Folder Utils 0
    - File KlantIdConverter.cls.xml 3 Remove
  - File MessageIdFormatter.cls.xml 0 Remove
  - File MessageManager.cls.xml 0 Remove
- Folder vhTest 0
  - Folder Fake/AXimpl 0
    - Folder Admin/VKP 0
      - File SalesPriceService.cls.xml 0 Remove
    - File MessageIdFormatter.cls.xml 0 Remove
  - Folder Mock/AXimpl 0
    - Folder Admin/VKP 0
      - File SalesPriceService.cls.xml 0 Remove
    - File MessageIdFormatter.cls.xml 0 Remove
- Folder vhUnitTest/AXimpl 0
  - Folder Admin/VKP/SalesPriceService 0
    - Folder ProductDataFactory 0 Remove
      - File Test.cls.xml 0 Remove
    - Folder ProductDataLijst 0 Remove
      - File Test.cls.xml 0 Remove
    - File Test.cls.xml 0 Remove
  - Folder MessageIdFormatter 0 Remove
    - File Test.cls.xml 0 Remove
  - Folder MessageManager 0
    - File Test.cls.xml 0 Remove
  - Folder Utils/KlantIdConverter 0
    - File Test.cls.xml 0 Remove
- File KPRIJS.mac.rou 0 Remove
- File KPRIJSADMIN.mac.rou 0 Remove
- File KPRIJSAX.mac.rou 0 Remove
- File PVAX.mac.rou 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Martijn Vierstraete	Author & Moderator	17m	1	De voorloopnullen zijn Ax gerelateerd, het lijkt me logis...
Wim Vermeulen	Reviewer - Complete	30m	2	idem
Total		47m	3

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/AX/Uitgaand/VKP/PrijsVerschilNrUitz/impl/ Deleted

Click to load diff

/AX/.../impl/PrijsUitzBuildCache.cls.xml Deleted

Click to load diff

/AX/.../impl/PrijsUitzDixfConverter.cls.xml Deleted

Click to load diff

/AX/.../impl/PrijsUitzDixfGenerator.cls.xml Deleted

Click to load diff

/AXimpl/.../impl/SalesPriceService.cls.xml Deleted

Click to load diff

/vhUnitTest/.../SalesPriceService/ProductDataFactory/ Added

Click to load diff

/vhUnitTest/.../SalesPriceService/ProductDataLijst/ Added

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-1136

[ICT379] VHIP907: Verkoopprijzen: Falende test SalesPriceService

CR-1136 3

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

[ICT379] VHIP907: Verkoopprijzen: Falende test SalesPriceService

CR-1136 3

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against