CR-136 [UW352] Herberekenmaatwerk Visie 4

closed on 20 Mar 17

Author

Moderator

Reviewers

[UW352] Herberekenmaatwerk Visie 4

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 21

CacheAdminA_trunk2010 (root:) 0
- Folder WSimpl/Vhisie4/Winkelkar/WinkelkarService 0
  - Folder HerberekenMaatwerk 0
    - File LijnCacheBuilder.cls.xml 0 Remove
    - File LijnCacheMatcher.cls.xml 0 Remove
    - File LijnCacheValidator.cls.xml 0 Remove
  - Folder Synchroniseer 0
    - File Synchronisator.cls.xml 0 Remove
  - File HerberekenMaatwerk.cls.xml 0 Remove
- Folder vhTest 0
  - Folder Fake/WSimpl/Vhisie4/Winkelkar/WinkelkarService 0
    - Folder HerberekenMaatwerk 0
      - File LijnCacheBuilder.cls.xml 0 Remove
      - File LijnCacheMatcher.cls.xml 0 Remove
    - Folder Synchroniseer 0
      - File Synchronisator.cls.xml 0 Remove
  - Folder Mock/WSimpl/Vhisie4/Winkelkar/WinkelkarService 0
    - Folder HerberekenMaatwerk 0
      - File LijnCacheBuilder.cls.xml 0 Remove
      - File LijnCacheMatcher.cls.xml 0 Remove
    - Folder Synchroniseer 0
      - File Synchronisator.cls.xml 0 Remove
- Folder vhUnitTest/WSimpl/Vhisie4/Winkelkar/WinkelkarService/HerberekenMaatwerk 0
  - Folder LijnCacheBuilder 0 Remove
    - File Test.cls.xml 0 Remove
    - File TestBase.cls.xml 0 Remove
    - File TestGeefVerschillen.cls.xml 0 Remove
    - File TestValideerWinkelkarLijnen.cls.xml 0 Remove
  - Folder LijnCacheMatcher 0 Remove
    - File Test.cls.xml 0 Remove
  - Folder LijnCacheValidator 0 Remove
    - File Test.cls.xml 0 Remove
  - File Test.cls.xml 3 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Kurt Callebaut	Author & Moderator	17m	1	Ik zou dan voorstellen dat je zelf ook geen .ToArray gebr...
Jo Claes	Reviewer - Complete	21m	2 (2 defects)	Volgens mij gaat deze test identiek hetzelfde testen dan ...
Total		39m	3 (2 defects)

Linked Review:
- CR-120

#permalink

Objectives

Jo, kan je dit al eens nazien en laten weten wat er nog moet gebeuren. (Los van de synchroniseer, die komt later aan de beurt.) -> zie cachebuilder. Ik zou voor synchroniseer lijncache ook niet public willen maken, maar visitor of dergelijke willen toepassen. suggesties ?

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/WSimpl/.../HerberekenMaatwerk/LijnCacheMatcher.cls.xml Deleted

Click to load diff

/WSimpl/.../HerberekenMaatwerk/LijnCacheValidator.cls.xml Deleted

Click to load diff

/vhTest/.../HerberekenMaatwerk/LijnCacheMatcher.cls.xml Deleted

Click to load diff

/vhTest/.../HerberekenMaatwerk/LijnCacheMatcher.cls.xml Deleted

Click to load diff

/vhUnitTest/.../LijnCacheBuilder/Test.cls.xml Deleted

Click to load diff

/vhUnitTest/.../HerberekenMaatwerk/LijnCacheMatcher/ Deleted

Click to load diff

/vhUnitTest/.../LijnCacheMatcher/Test.cls.xml Deleted

Click to load diff

/vhUnitTest/.../HerberekenMaatwerk/LijnCacheValidator/ Deleted

Click to load diff

/vhUnitTest/.../LijnCacheValidator/Test.cls.xml Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-136

[UW352] Herberekenmaatwerk Visie 4

CR-136 3

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

[UW352] Herberekenmaatwerk Visie 4

CR-136 3

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against