CR-149 [UST2321] Vh4_SVC: LBX/TAX verkeerd gebruik booleans op ECON-laag

closed on 06 Apr 17

Author

Moderator

Reviewers

[UST2321] Vh4_SVC: LBX/TAX verkeerd gebruik booleans op ECON-laag

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 6

CacheAdminA_trunk2010 (root:) 0
- Folder ECONimpl/PM/Maatwerk/AppsConverter 0
  - Folder AppsNaarEcon 0
    - File Tax.cls.xml 1 Remove
  - Folder EconNaarApps 0
    - File Lbx.cls.xml 0 Remove
    - File Tax.cls.xml 0 Remove
- Folder vhTest/Utils 0
  - Folder APPS/PM/Maatwerk/dto 0
    - File LBXKenmerken.cls.xml 0 Remove
  - Folder ECON/PM/Maatwerk/dto 0
    - File LbxKenmerken.cls.xml 0 Remove
    - File TaxKenmerken.cls.xml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Tom Vermeulen	Author & Moderator	17m
Jo Claes	Reviewer - Complete	13m	2 (1 defect)	Denk als je het oplost op deze manier dat je code niet fu...
Total		30m	2 (1 defect)

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Jo Claes

In de toekomst wel eens bekijken om de oplossing iets generieker te maken -> ...

In de toekomst wel eens bekijken om de oplossing iets generieker te maken -> kwestie van niet iedere keer eentje te moeten toevoegen als er een booleanke bij komt

28 Mar 17

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-149

[UST2321] Vh4_SVC: LBX/TAX verkeerd gebruik booleans op ECON-laag

CR-149 2

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jo Claes

Log time against

[UST2321] Vh4_SVC: LBX/TAX verkeerd gebruik booleans op ECON-laag

CR-149 2

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jo Claes

Log time against