CR-163 [UST2241]VHIP_GLS: RegisterContainer implementeren

closed on 12 Jun 17

Author

Moderator

Reviewers

[UST2241]VHIP_GLS: RegisterContainer implementeren

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 82

CacheAdminA_trunk2010 (root:) 0
- Folder APPS/TRANSP/GLS 0
  - Folder GLSv1/impl 0
    - File BerichtVerzenderTemplate.cls.xml 0 Remove
  - Folder impl 0
    - File EtiketService.cls.xml 1 Remove
- Folder WS/AX/Transport/GLS/v01 0
  - Folder dto 0
    - File RegisterContainerRequest.cls.xml 1 Remove
    - File RegisterContainerResponse.cls.xml 0 Remove
    - File VerpakkingEenheid.cls.xml 0 Remove
  - File RegistrationService.cls.xml 1 Remove
- Folder WSimpl 0
  - Folder AX 0 Remove
    - Folder Transport 0 Remove
      - Folder GLS 0 Remove
        
        Folder v01 0 Remove
        
        Folder RegistrationService 0 Remove
        
        File RegisterContainer.cls.xml 3 Remove
        
        File RegisterContainerRequestConvertor.cls.xml 1 Remove
        
        File RegistreerBerichtVerzender.cls.xml 0 Remove
        
        File VerzendDataConvertor.cls.xml 1 Remove
- Folder vhDeploy 0
  - File Deploy20170329xWSGLSKlassenamen.cls.xml 0 Remove
- Folder vhTest 0
  - Folder Fake 0
    - Folder APPS/TRANSP 0
      - Folder GLS 0 Remove
        
        Folder impl 0 Remove
        
        File EtiketService.cls.xml 0 Remove
    - Folder WSimpl 0
      - Folder AX 0 Remove
        
        Folder Transport 0 Remove
        
        Folder GLS 0 Remove
        
        Folder v01 0 Remove
        
        Folder RegistrationService 0 Remove
        
        File RegisterContainerRequestConvertor.cls.xml 0 Remove
        
        File RegistreerBerichtVerzender.cls.xml 0 Remove
        
        File VerzendDataConvertor.cls.xml 0 Remove
  - Folder Integratie 0
    - Folder WSimpl 0 Remove
      - Folder AX 0 Remove
        
        Folder Transport 0 Remove
        
        Folder GLS 0 Remove
        
        Folder v01 0 Remove
        
        Folder RegistrationService 0 Remove
        
        File CommunicationServiceLocatorFake.cls.xml 0 Remove
        
        File DateTimeAPIMock.cls.xml 1 Remove
        
        File PrintApiFake.cls.xml 0 Remove
        
        File SocketFactoryMock.cls.xml 0 Remove
        
        File SocketMock.cls.xml 0 Remove
        
        File Test.cls.xml 0 Remove
        
        File TransportAPIFake.cls.xml 0 Remove
        
        File UnitIdBepalerFake.cls.xml 0 Remove
  - Folder Mock 0
    - Folder APPS/TRANSP/GLS 0
      - Folder impl 0 Remove
        
        File EtiketService.cls.xml 0 Remove
    - Folder WSimpl 0
      - Folder AX 0 Remove
        
        Folder Transport 0 Remove
        
        Folder GLS 0 Remove
        
        Folder v01 0 Remove
        
        Folder RegistrationService 0 Remove
        
        File RegisterContainerRequestConvertor.cls.xml 0 Remove
        
        File RegistreerBerichtVerzender.cls.xml 0 Remove
        
        File VerzendDataConvertor.cls.xml 0 Remove
  - Folder Utils 0
    - Folder APPS/TRANSP 0
      - Folder GLS 0 Remove
        
        Folder data 0 Remove
        
        File VerzendData.cls.xml 0 Remove
      - Folder dto 0
        
        File LeveringAdres.cls.xml 0 Remove
        
        File LeveringInfo.cls.xml 1 Remove
    - Folder WS 0
      - Folder AX 0 Remove
        
        Folder Transport 0 Remove
        
        Folder GLS 0 Remove
        
        Folder v01 0 Remove
        
        Folder dto 0 Remove
        
        File Adres.cls.xml 0 Remove
        
        File LeveringAdres.cls.xml 0 Remove
        
        File RegisterContainerRequest.cls.xml 0 Remove
        
        File RegisterContainerResponse.cls.xml 0 Remove
- Folder vhTestFiles/IntegratieTests 0
  - Folder WSimpl.AX.Transport.GLS.v01.RegistrationService 0 Remove
    - Folder Test 0 Remove
      - File 001_Bullzip_GLSFreight.TXT 0 Remove
      - File Request01.txt 0 Remove
      - File Response01.txt 0 Remove
  - Folder Webservices.WSDLControle/Test 0
    - File WS.AX.Transport.GLS.v01.RegistrationService.txt 0 Remove
- Folder vhUnitTest/WSimpl 0
  - Folder AX 0 Remove
    - Folder Transport 0 Remove
      - Folder GLS 0 Remove
        
        Folder v01 0 Remove
        
        Folder RegistrationService 0 Remove
        
        Folder RegisterContainer 0 Remove
        
        File Test.cls.xml 0 Remove
        
        Folder RegisterContainerRequestConvertor 0 Remove
        
        File Test.cls.xml 0 Remove
        
        Folder VerzendDataConvertor 0 Remove
        
        File Test.cls.xml 3 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Jo Willems	Author & Moderator	1h	1	De parcel en unit id zijn gebaseerd op zelfde veld uit de...
Jo Claes	Reviewer - Complete	38m	12 (6 defects)	Assert methods mogen geprivatiseerd worden
Total		1h 38m	13 (6 defects)

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/WSimpl/AX/.../GLS/v01/RegistrationService/ Added

Click to load diff

/vhTest/Fake/.../GLS/v01/RegistrationService/ Added

Click to load diff

/vhTest/Integratie/WSimpl/AX/Transport/GLS/ Added

Click to load diff

/vhTest/Integratie/.../v01/RegistrationService/ Added

Click to load diff

/vhTest/Mock/.../GLS/v01/RegistrationService/ Added

Click to load diff

/vhTest/Utils/WS/AX/Transport/GLS/v01/dto/ Added

Click to load diff

/vhTestFiles/IntegratieTests/WSimpl.AX.Transport.GLS.v01.RegistrationService/ Added

Click to load diff

/vhTestFiles/.../WSimpl.AX.Transport.GLS.v01.RegistrationService/Test/ Added

Click to load diff

/vhUnitTest/WSimpl/.../v01/RegistrationService/ Added

Click to load diff

/vhUnitTest/.../RegistrationService/RegisterContainer/ Added

Click to load diff

/vhUnitTest/.../RegistrationService/RegisterContainerRequestConvertor/ Added

Click to load diff

/vhUnitTest/.../RegistrationService/VerzendDataConvertor/ Added

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-163

[UST2241]VHIP_GLS: RegisterContainer implementeren

CR-163 13

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

[UST2241]VHIP_GLS: RegisterContainer implementeren

CR-163 13

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against