CR-1720 [UST4222] EC: MP: Daro: ook mailen van door handel toe te voegen losse componenten (naast de http...

closed on 28 Aug 19

Author

Moderator

Reviewers

[UST4222] EC: MP: Daro: ook mailen van door handel toe te voegen losse...

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 34

CacheAdminA_trunk2010 (root:) 0
- Folder APPS 0
  - Folder EC/Winkelkar/impl 0
    - Folder DoorHandelMeeleverenBepaler 0
      - File NietBenelux.cls.xml 2 Remove
    - File DoorHandelMeeleverenBepalerFactory.cls.xml 3 Remove
    - File MaatwerkLijnBuilder.cls.xml 1 Remove
  - Folder VKP/Offerte/impl/BesteldeOfferteMelder/HttpVerzender 0
    - Folder dto/OfferteGenerator 0
      - File Daro.cls.xml 2 Remove
    - File Daro.cls.xml 2 Remove
- Folder DOM 0
  - Folder EC/Winkelkar/impl 0
    - File MaatwerkLijnBuilder.cls.xml 1 Remove
  - Folder PM 0
    - Folder Maatwerk/Calc 0
      - Folder Common/impl 0
        
        File TAORKenmerken.cls.xml 1 Remove
      - Folder HF 0
        
        File IHalffabItem.cls.xml 1 Remove
    - Folder impl 0
      - Folder VerkoopPrijsBepaler 0
        
        File NietMeerekenenBepaler.cls.xml 5 Remove
      - File VerkoopPrijsBepaler.cls.xml 1 Remove
- Folder WSimpl/Vhisie4/Winkelkar/WinkelkarExport 0
  - Folder WinkelkarAanpasser 0
    - File BeslagDesign.cls.xml 0 Remove
    - File Daro.cls.xml 0 Remove
    - File Ferexpert.cls.xml 0 Remove
    - File Galimberti.cls.xml 0 Remove
    - File Pavanello.cls.xml 0 Remove
  - File WinkelkarAanpasserFactory.cls.xml 1 Remove
- Folder vhTest 0
  - Folder Fake/DOM/PM/Maatwerk/Calc/HF 0
    - File SamengesteldHalffabItem.cls.xml 0 Remove
    - File StandaardHalffabItem.cls.xml 0 Remove
  - Folder Mock/DOM/PM 0
    - Folder Maatwerk/Calc/HF 0
      - File SamengesteldHalffabItem.cls.xml 0 Remove
      - File StandaardHalffabItem.cls.xml 0 Remove
    - Folder impl/VerkoopPrijsBepaler 0
      - File NietMeerekenenBepaler.cls.xml 0 Remove
  - Folder Utils/WS/Vhisie4/WinkelkarExport/dto 0
    - File MaatwerkLijn.cls.xml 0 Remove
    - File Winkelkar.cls.xml 0 Remove
- Folder vhTestFiles/IntegratieTests/Webshop.Offerte.IngaveTotBestelling/Test/Daro/Daro/DaroGebruiker 0
  - File PostMessage001.txt 0 Remove
- Folder vhUnitTest 0
  - Folder APPS 0
    - Folder EC/Winkelkar/impl/DoorHandelMeeleverenBepaler/NietBenelux 0
      - File ZetDoorHandelMeeleverens.cls.xml 2 Remove
    - Folder VKP/Offerte/impl/BesteldeOfferteMelder/HttpVerzender 0
      - File Test.cls.xml 1 Remove
  - Folder DOM/PM/impl/VerkoopPrijsBepaler/NietMeerekenenBepaler 0
    - File Test.cls.xml 1 Remove
  - Folder End2End/TAOR/GebruikteHalffabItemsVoorPrijsberekening 0
    - File Test.cls.xml 1 Remove
  - Folder WSimpl/Vhisie4/Winkelkar/WinkelkarExport/WinkelkarAanpasser 0
    - Folder BeslagDesign 0
      - File PasAanTest.cls.xml 0 Remove
    - Folder Daro 0 Remove
      - File PasAanTest.cls.xml 0 Remove
    - Folder Ferexpert 0
      - File PasAanTest.cls.xml 0 Remove
    - Folder Galimberti 0
      - File PasAanTest.cls.xml 0 Remove
    - Folder Pavanello 0
      - File PasAanTest.cls.xml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Jo Willems	Author & Moderator	21m	1	Sorry voor deze review. Veel te veel revisies en meerdere...
Martijn Vierstraete	Reviewer - Complete	43m	25	Is er een reden waarom je tests toevoegt en uitschakelt?
Total		1h 4m	26

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Jo Willems

Sorry voor deze review. Veel te veel revisies en meerdere stories, maar het w...

Sorry voor deze review. Veel te veel revisies en meerdere stories, maar het was nog al dringend en alles liep door elkaar, en zie niet goed hoe ik dit in meerdere reviews kan steken.
Desnoods lopen we er samen eens door.
UST4222 , UST4223, en nog een stukje aanvulling op BUS734

04 Jun 19

Click to load diff

/vhUnitTest/WSimpl/.../WinkelkarAanpasser/Daro/ Added

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-1720

[UST4222] EC: MP: Daro: ook mailen van door handel toe te voegen losse...

CR-1720 26

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jo Willems

Log time against

[UST4222] EC: MP: Daro: ook mailen van door handel toe te voegen losse...

CR-1720 26

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jo Willems

Log time against