CR-1896 [ICT-872] UAT 1467: Pakbon pas aanmaken op moment van transport

open for 5 years due 5 years ago

Author

Moderator

Reviewers

[ICT-872] UAT 1467: Pakbon pas aanmaken op moment van transport

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 24

CacheAdminA_trunk2010 (root:) 0
- Folder AXimpl/Dynamics/InventoryOut 0
  - Folder Converter 0
    - File PakbonMagGeboektWordenConverter.cls.xml 2 Remove
  - Folder EventHandler 0
    - Folder PickingCompleet 0 Remove
      - File PakbonMagGeboektWorden.cls.xml 1 Remove
    - File PakbonMagGeboektWorden.cls.xml 1 Remove
    - File PickingCompleet.cls.xml 1 Remove
- Folder DOM/MAG/event 0
  - File EventRaiser.cls.xml 0 Remove
  - File PakbonMagGeboektWordenEvent.cls.xml 0 Remove
- Folder vhDeploy 0
  - File Deploy20191211xAXConfigItemsToevoegenVoorPakbonMagGeboektWorden.cls.xml 0 Remove
  - File Deploy20191211xEventHandlerPakbonMagGeboektWordenInstall.cls.xml 0 Remove
  - File Deploy20191211xPakbonMagGeboektWordenHandlerTechConfigBooleanFalseToevoegen.cls.xml 0 Remove
- Folder vhTest 0
  - Folder Fake 0
    - Folder AXimpl/Dynamics/InventoryOut/EventHandler 0
      - Folder PickingCompleet 0 Remove
        
        File PakbonMagGeboektWorden.cls.xml 0 Remove
    - Folder DOM/MAG 0
      - Folder event 0 Remove
        
        File EventRaiser.cls.xml 0 Remove
  - Folder Mock 0
    - Folder AXimpl/Dynamics/InventoryOut/EventHandler 0
      - Folder PickingCompleet 0 Remove
        
        File PakbonMagGeboektWorden.cls.xml 0 Remove
    - Folder DOM/MAG 0
      - Folder event 0 Remove
        
        File EventRaiser.cls.xml 0 Remove
- Folder vhUnitTest/AXimpl/Dynamics/InventoryOut 0
  - Folder Converter 0
    - Folder PakbonMagGeboektWorden 0 Remove
      - Folder Convert 0 Remove
        
        File Test.cls.xml 1 Remove
  - Folder EventHandler 0
    - Folder PickingCompleet 0 Remove
      - Folder PakbonMagGeboektWorden 0 Remove
        
        File Test.cls.xml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Laura Landuyt	Author & Moderator	49m
Jo Willems	Reviewer - Complete	46m	7 (2 defects)	Mis een testje hier op die test of generate uitgevoerd wo...
Total		1h 36m	7 (2 defects)

Linked Issue:
ICT-872
Linked Review:
- CR-1921

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Jo Willems

Algemene opmerking code conventions volgorde van elementen van een class 1 pa...

Algemene opmerking code conventions volgorde van elementen van een class
1 parameters
2 properties
3 Constructor (%OnNew)
4 Public methods
5 Private methods

voor Testcases onbefore* en onafter* methods voor de eigenlijke test methods

11 Dec 19

Laura Landuyt

Resolved

11 Dec 19

Click to load diff

/vhTest/Fake/.../EventHandler/PickingCompleet/ Added

Click to load diff

/vhTest/Mock/.../EventHandler/PickingCompleet/ Added

Click to load diff

/vhUnitTest/.../Converter/PakbonMagGeboektWorden/ Added

Click to load diff

/vhUnitTest/.../PakbonMagGeboektWorden/Convert/ Added

Click to load diff

/vhUnitTest/.../EventHandler/PickingCompleet/ Added

Click to load diff

/vhUnitTest/.../PickingCompleet/PakbonMagGeboektWorden/ Added

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-1896

[ICT-872] UAT 1467: Pakbon pas aanmaken op moment van transport

CR-1896 7

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jo Willems

Log time against

[ICT-872] UAT 1467: Pakbon pas aanmaken op moment van transport

CR-1896 7

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jo Willems

Log time against