CR-2013 [ICT-1374] SVG-031 Aanmaken CrossFactory

closed on 23 Nov 20

Author

Moderator

Reviewers

[ICT-1374] SVG-031 Aanmaken CrossFactory

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 20

CacheAdminA_trunk2010 (root:) 0
- Folder APPS/Halux/PPS/ALUFrees/Svg 0
  - Folder BasisElement 0
    - File CrossDiag.cls.xml 1 Remove
    - File CrossFactory.cls.xml 0 Remove
    - File CrossVH.cls.xml 0 Remove
    - File TCross.cls.xml 0 Remove
  - Folder KaderdeurElement/Boring 0
    - File BoringElementFactory.cls.xml 0 Remove
- Folder vhTest 0
  - Folder Fake/APPS/Halux/PPS/ALUFrees/Svg 0
    - Folder BasisElement 0 Remove
      - File CrossFactory.cls.xml 0 Remove
  - Folder Mock/APPS/Halux/PPS/ALUFrees/Svg 0
    - Folder BasisElement 0 Remove
      - File CrossFactory.cls.xml 0 Remove
    - Folder KaderdeurElement 0
      - Folder Boring 0
        
        File BoringElementFactory.cls.xml 0 Remove
      - Folder Hoekverbinder 0 Remove
- Folder vhUnitTest/APPS/Halux/PPS/ALUFrees/Svg 0
  - Folder BasisElement 0
    - Folder CrossDiag 0 Remove
      - File Test.cls.xml 0 Remove
    - Folder CrossFactory 0 Remove
      - File Test.cls.xml 3 Remove
    - Folder CrossVH 0 Remove
      - File Test.cls.xml 0 Remove
    - Folder TCross 0 Remove
      - File Test.cls.xml 0 Remove
  - Folder KaderdeurElement/Beslag/Boringen/VoegToeBoringen 0
    - File Test.cls.xml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Sam Van Hoey	Author & Moderator	1m
Tom Vermeulen	Reviewer - Complete	16m	2 (1 defect)	AssertClassName bestaat ook
Wim Vermeulen	Reviewer - Complete	51m	2	Bij iedere UT moet je denken "Kan deze setup fouten verbe...
Total		1h 9m	4 (1 defect)

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/vhTest/Fake/.../ALUFrees/Svg/BasisElement/ Added

Click to load diff

/vhTest/Mock/.../ALUFrees/Svg/BasisElement/ Added

Click to load diff

/vhTest/.../KaderdeurElement/Hoekverbinder/ Added

Click to load diff

/vhUnitTest/APPS/.../BasisElement/CrossDiag/ Deleted

Click to load diff

/vhUnitTest/APPS/.../CrossDiag/Test.cls.xml Deleted

Click to load diff

/vhUnitTest/APPS/.../Svg/BasisElement/CrossVH/ Deleted

Click to load diff

/vhUnitTest/APPS/.../CrossVH/Test.cls.xml Deleted

Click to load diff

/vhUnitTest/APPS/.../Svg/BasisElement/TCross/ Deleted

Click to load diff

/vhUnitTest/APPS/.../TCross/Test.cls.xml Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-2013

[ICT-1374] SVG-031 Aanmaken CrossFactory

CR-2013 4

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

[ICT-1374] SVG-031 Aanmaken CrossFactory

CR-2013 4

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against