CR-2083 [ICT-1528] EC: MP: Häfele DE: Kortingen-bestand uittesten

closed on 23 Nov 20

Author

Moderator

Reviewers

[ICT-1528] EC: MP: Häfele DE: Kortingen-bestand uittesten

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 31

CacheAdminACommon_trunk2010 (root:) 0
- Folder TECH 0
  - File XMLReader.cls.xml 0 Remove
- Folder vhTest 0
  - Folder Fake/TECH 0
    - Folder XMLReader 0 Remove
      - File FakeKortingReader.cls.xml 0 Remove
    - File XMLReader.cls.xml 0 Remove
  - Folder Mock/TECH 0
    - File XMLReader.cls.xml 0 Remove
CacheAdminA_trunk2010 (root:) 0
- Folder APPS/VKP 0
  - Folder Klantspecifiek/Haefele 0
    - File KortingParser.cls.xml 2 Remove
  - Folder Korting 0
    - Folder impl 0
      - File CustomerVerwerker.cls.xml 0 Remove
      - File KortingService.cls.xml 0 Remove
    - File KortingParser.cls.xml 0 Remove
- Folder vhTest 0
  - Folder Fake/APPS/VKP 0
    - Folder Klantspecifiek 0 Remove
      - Folder Haefele 0 Remove
        
        File KortingParser.cls.xml 0 Remove
    - Folder Korting/impl 0
      - File CustomerVerwerker.cls.xml 0 Remove
      - File KortingService.cls.xml 0 Remove
  - Folder Mock/APPS/VKP 0
    - Folder Klantspecifiek 0 Remove
      - Folder Haefele 0 Remove
        
        File KortingParser.cls.xml 0 Remove
    - Folder Korting/impl 0
      - File CustomerVerwerker.cls.xml 0 Remove
      - File KortingService.cls.xml 0 Remove
  - Folder Utils/APPS/VKP 0
    - Folder Korting 0 Remove
      - File Customer.cls.xml 0 Remove
- Folder vhUnitTest/APPS/VKP 0
  - Folder Klantspecifiek/Haefele 0
    - Folder KortingParser 0 Remove
      - Folder Parse 0 Remove
        
        File Test.cls.xml 2 Remove
  - Folder Korting/impl 0
    - Folder CustomerVerwerker 0 Remove
      - Folder VerwerkCustomer 0 Remove
        
        File FakeKortingReader.cls.xml 0 Remove
        
        File Test.cls.xml 0 Remove
    - Folder KortingService 0
      - Folder GeefKortingConfiguratieLijst 0 Remove
        
        File Test.cls.xml 1 Remove
      - Folder StelInKortingen 0
        
        File Test.cls.xml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Sam Van Hoey	Author & Moderator	30m
Tom Vermeulen	Reviewer - Complete	50m	5 (4 defects)	normaalgezien geen early quits in een method (tenzij hele...
Total		1h 20m	5 (4 defects)

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/vhTest/.../XMLReader/FakeKortingReader.cls.xml Deleted

Click to load diff

/vhTest/Fake/.../VKP/Klantspecifiek/Haefele/ Added

Click to load diff

/vhTest/Mock/.../VKP/Klantspecifiek/Haefele/ Added

Click to load diff

/vhUnitTest/APPS/.../Haefele/KortingParser/ Added

Click to load diff

/vhUnitTest/APPS/.../impl/CustomerVerwerker/ Added

Click to load diff

/vhUnitTest/.../CustomerVerwerker/VerwerkCustomer/ Added

Click to load diff

/vhUnitTest/.../KortingService/GeefKortingConfiguratieLijst/ Added

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-2083

[ICT-1528] EC: MP: Häfele DE: Kortingen-bestand uittesten

CR-2083 5

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

[ICT-1528] EC: MP: Häfele DE: Kortingen-bestand uittesten

CR-2083 5

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against