CR-2097 [ICT-949] Voorbereiding vertaaltool via Perfion als UI (niet meer porten)

open for 5 years due 4 years ago

Author

Moderator

Reviewers

[ICT-949] Voorbereiding vertaaltool via Perfion als UI (niet meer porten)

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 58

CacheAdminA_trunk2010 (root:) 0
- Folder Res 0
  - Folder Perfion/Synchroniser 0
    - File Perfion.cls.xml 0 Remove
    - File PerfionRepository.cls.xml 0 Remove
    - File TaalConverter.cls.xml 0 Remove
    - File Vertalingen.cls.xml 6 Remove
    - File VertalingenParser.cls.xml 0 Remove
  - File VertalingAbstract.cls.xml 0 Remove
  - File VertalingRepository.cls.xml 1 Remove
- Folder WS/PM/Perfion/Vertaling/DataService 0
  - File GetData.cls.xml 0 Remove
- Folder WSimpl/PM/Perfion/Vertaling/DataService 0
  - File GetData.cls.xml 0 Remove
- Folder vhTest 0
  - Folder Fake 0
    - Folder Res 0
      - Folder Perfion 0 Remove
        
        Folder Synchroniser 0 Remove
        
        File PerfionRepository.cls.xml 0 Remove
        
        File TaalConverter.cls.xml 0 Remove
        
        File VertalingenParser.cls.xml 0 Remove
      - File VertalingRepository.cls.xml 0 Remove
    - Folder WSimpl 0
      - Folder PM 0 Remove
        
        Folder Perfion 0 Remove
        
        Folder Vertaling 0 Remove
        
        Folder DataService 0 Remove
        
        File GetData.cls.xml 0 Remove
  - Folder Mock 0
    - Folder Res 0 Remove
      - Folder Perfion 0 Remove
        
        Folder Synchroniser 0 Remove
        
        File PerfionRepository.cls.xml 0 Remove
        
        File TaalConverter.cls.xml 0 Remove
        
        File VertalingenParser.cls.xml 0 Remove
      - File VertalingRepository.cls.xml 0 Remove
    - Folder WSimpl 0
      - Folder PM 0 Remove
        
        Folder Perfion 0 Remove
        
        Folder Vertaling 0 Remove
        
        Folder DataService 0 Remove
        
        File GetData.cls.xml 0 Remove
  - Folder Utils 0
    - Folder Res 0 Remove
      - Folder Perfion 0 Remove
        
        Folder Synchroniser 0 Remove
        
        File Perfion.cls.xml 0 Remove
        
        File Vertaling.cls.xml 0 Remove
      - File Vertaling.cls.xml 0 Remove
- Folder vhUnitTest/Res 0
  - Folder Perfion 0 Remove
    - Folder Synchroniser 0 Remove
      - Folder PerfionRepository 0 Remove
        
        File Test.cls.xml 0 Remove
        
        File spy.cls.xml 0 Remove
      - Folder TaalConverter 0 Remove
        
        Folder Converter 0 Remove
        
        File Test.cls.xml 0 Remove
      - Folder Vertalingen 0 Remove
        
        Folder SynchroniseerVertalingen 0 Remove
        
        File Test.cls.xml 0 Remove
        
        Folder VerwerkVertalingsGroep 0 Remove
        
        File Test.cls.xml 0 Remove
        
        Folder VoegToeVertalingen 0 Remove
        
        File Test.cls.xml 0 Remove
        
        Folder VulPerfionTabel 0 Remove
        
        File Test.cls.xml 0 Remove
  - Folder VertalingRepository 0 Remove
    - File Test.cls.xml 0 Remove
- File vhCARETAKER.mac.rou 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Sam Van Hoey	Author & Moderator	56m
Jo Willems	Reviewer - Complete	1h 3m	8 (5 defects)	Deel op per groep : Method VerwerkVertalingen(){ Do ..Ve...
Total		1h 59m	8 (5 defects)

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Jo Willems

alle scenario's uit jira issue gecoverd? en het opvragen van vertalingen uit...

alle scenario's uit jira issue gecoverd?

en het opvragen van vertalingen uit perfion en opvragen van bestaande res vertalingen moet met de zelfde argumenten (groep ?) gebeuren. anders ga je dingen verwijderen die niet mogen verwijderd worden.
Log welke groepen je opvraagt uit perfion, en welke uit caché, zodat blijkt uit de logging wazt er gebeurt.

Defect

27 Oct 20

Jo Willems

Unresolved

27 Oct 20

Click to load diff

/vhTest/Fake/.../Perfion/Vertaling/DataService/ Added

Click to load diff

/vhTest/Mock/.../Perfion/Vertaling/DataService/ Added

Click to load diff

/vhUnitTest/.../Synchroniser/PerfionRepository/ Added

Click to load diff

/vhUnitTest/Res/.../Synchroniser/TaalConverter/ Added

Click to load diff

/vhUnitTest/Res/.../TaalConverter/Converter/ Added

Click to load diff

/vhUnitTest/Res/.../Synchroniser/Vertalingen/ Added

Click to load diff

/vhUnitTest/.../Vertalingen/SynchroniseerVertalingen/ Deleted

Click to load diff

/vhUnitTest/.../SynchroniseerVertalingen/Test.cls.xml Deleted

Click to load diff

/vhUnitTest/.../Vertalingen/VerwerkVertalingsGroep/ Added

Click to load diff

/vhUnitTest/.../Vertalingen/VoegToeVertalingen/ Deleted

Click to load diff

/vhUnitTest/.../VoegToeVertalingen/Test.cls.xml Deleted

Click to load diff

/vhUnitTest/.../Vertalingen/VulPerfionTabel/ Deleted

Click to load diff

/vhUnitTest/.../VulPerfionTabel/Test.cls.xml Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-2097

[ICT-949] Voorbereiding vertaaltool via Perfion als UI (niet meer porten)

CR-2097 8

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jo Willems

Log time against

[ICT-949] Voorbereiding vertaaltool via Perfion als UI (niet meer porten)

CR-2097 8

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jo Willems

Log time against