CR-2135 [ICT-1753] [rvTVE, rvJWI] EC: MP: ORGALUX: MultipersonalityPrijsWebservice bouwen en aan ITR aanbieden...

open for 4 years due 4 years ago

Author

Moderator

Reviewers

[ICT-1753] [rvTVE, rvJWI] EC: MP: ORGALUX: MultipersonalityPrijsWebservice...

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 23

CacheAdminA_trunk2010 (root:) 0
- Folder APPS/EC/Winkelkar/WinkelkarService 0
  - Folder impl 0
    - Folder PrijsBepaler 0
      - File HaefeleDEPrijsFactorBepaler.cls.xml 1 Remove
      - File SFSPrijsFactorBepaler.cls.xml 1 Remove
    - File PrijsFactorBepalerFactory.cls.xml 1 Remove
  - File PrijsFactorBepaler.cls.xml 0 Remove
- Folder WS/Vhisie4/Winkelkar 0
  - Folder dto 0
    - Folder MultipersonalityPrijsWebservice 0 Remove
      - File PrijsHeaderInput.cls.xml 0 Remove
      - File PrijsLijnInput.cls.xml 0 Remove
      - File XppObjectBase.cls.xml 0 Remove
      - File guid.cls.xml 0 Remove
    - File PrijsHeaderOutput.cls.xml 0 Remove
    - File PrijsLijnOutput.cls.xml 0 Remove
  - File BerekenProductPrijzenRequest.cls.xml 0 Remove
  - File MultipersonalityPrijsWebservice.cls.xml 0 Remove
- Folder WSimpl/Vhisie4/Winkelkar 0
  - Folder MultipersonalityPrijsWebservice 0 Remove
    - File BerekenProductPrijzen.cls.xml 4 Remove
- Folder vhTest 0
  - Folder Fake/APPS/EC/Winkelkar/WinkelkarService/impl 0
    - File PrijsFactorBepalerFactory.cls.xml 0 Remove
  - Folder Mock 0
    - Folder APPS/EC/Winkelkar/WinkelkarService 0
      - Folder impl 0
        
        File PrijsFactorBepalerFactory.cls.xml 0 Remove
      - File PrijsFactorBepaler.cls.xml 0 Remove
    - Folder AXimpl/Admin/VKP 0
      - File SalesPriceService.cls.xml 0 Remove
- Folder vhTestFiles/IntegratieTests/Webservices.WSDLControle/Test 0
  - File WS.Vhisie4.Winkelkar.MultipersonalityPrijsWebservice.txt 0 Remove
- Folder vhUnitTest/WSimpl/Vhisie4/Winkelkar 0
  - Folder MultipersonalityPrijsWebservice 0 Remove
    - Folder BerekenProductPrijzen 0 Remove
      - File Test.cls.xml 2 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Sam Van Hoey	Author & Moderator	30m
Jo Willems	Reviewer - Complete	25m
Tom Vermeulen	Reviewer - Complete	27m	9 (7 defects)	algemene opmerking over onderstaande tests: Ze bevinden z...
Total		1h 22m	9 (7 defects)

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/WS/.../dto/MultipersonalityPrijsWebservice/ Added

Click to load diff

/WSimpl/.../Winkelkar/MultipersonalityPrijsWebservice/ Added

Click to load diff

/vhUnitTest/.../Winkelkar/MultipersonalityPrijsWebservice/ Added

Click to load diff

/vhUnitTest/.../MultipersonalityPrijsWebservice/BerekenProductPrijzen/ Added

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-2135

[ICT-1753] [rvTVE, rvJWI] EC: MP: ORGALUX: MultipersonalityPrijsWebservice...

CR-2135 9

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

[ICT-1753] [rvTVE, rvJWI] EC: MP: ORGALUX: MultipersonalityPrijsWebservice...

CR-2135 9

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against