CR-2258 [ICT-1756] WebServiceLogger geeft "Unknown webmethod"

closed on 02 Feb 21

Author

Moderator

Reviewers

[ICT-1756] WebServiceLogger geeft "Unknown webmethod"

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 6

CacheAdminACommon_trunk2010 (root:) 0
- Folder vhLib 0
  - Folder WebServiceLogger 0
    - Folder impl 0
      - File BestandLogger.cls.xml 0 Remove
      - File VhLibLogger.cls.xml 0 Remove
    - File LogService.cls.xml 0 Remove
    - File Logger.cls.xml 0 Remove
  - File WebService.cls.xml 0 Remove
  - File WebServiceHelper.cls.xml 6 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Wim Vermeulen	Author & Moderator	34m	2	inderdaad. T eerste deel was het belangrijkste om te begr...
Jelle Baele	Reviewer - Complete	40m	4	Ok top, bedankt!!
Total		1h 14m	6

#permalink

Objectives

De code changes zijn niet spectaculair. De echte reden waarom ik deze review aan jou geef is omdat hier het principe van composition duidelijk wordt toegepast :
vhLib.WebService heeft veel afgeleide klassen, dus iedere wijziging van implementatie zou een compile van alle afgeleide klassen tot gevolg hebben.
Door deze implementatie te verplaatsen naar een Helper klasse, is die grote compile dus niet meer nodig.
In deze story moest echter een extra parameter doorgegeven worden van WebService aan WebServiceHelper. Vandaar de eenmalige grote compile, en hebben we hopelijk voldoende informatie meegegeven, zodat volgende gewenste wijzigingen enkel in de Helper moeten gebeuren.

Als deze uitleg niet duidelijk is, wil ik je dit gerust nog eens via skype toelichten. Laat maar weten.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-2258

[ICT-1756] WebServiceLogger geeft "Unknown webmethod"

CR-2258 6

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

[ICT-1756] WebServiceLogger geeft "Unknown webmethod"

CR-2258 6

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against