CR-2274 [ICT-2144] [rvWV] HX: TAX koppeling: hoogteverstelling pilootklanten productieaansturing...

closed on 16 Mar 21

Author

Moderator

Reviewers

[ICT-2144] [rvWV] HX: TAX koppeling: hoogteverstelling pilootklanten...

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 42

CacheAdminA_trunk2010 (root:) 0
- Folder APPS 0
  - Folder Halux 0
    - Folder Machine/Kantenband/enu 0
      - Folder LijmProgramma 0
        
        File AutoComplete.cls.xml 0 Remove
        
        File Verwerker.cls.xml 0 Remove
      - File LijmProgramma.cls.xml 0 Remove
    - Folder PPS 0
      - Folder Activiteit/impl/TAOR/Zijkant 0
        
        File KamerFreesDataProgrammaAanvuller.cls.xml 0 Remove
        
        File KamerFreesIsoProgrammaBepaler.cls.xml 1 Remove
        
        File VerwerkingIDBepaler.cls.xml 0 Remove
      - Folder TAORProductie/impl 0
        
        File ZijkantLijmProgrammaBepaler.cls.xml 0 Remove
    - Folder common/impl 0
      - Folder ProductieGroepBepaler 0
        
        File ProductieOpstartfaseBepalerTAX.cls.xml 0 Remove
      - File ProductieGroepBepalerTAX.cls.xml 0 Remove
  - Folder common 0
    - Folder impl 0
      - File KlantInstellingenService.cls.xml 0 Remove
    - File KlantInstellingenService.cls.xml 0 Remove
- Folder DOM 0
  - Folder PM 0
    - Folder TAORProduct 0
      - Folder impl 0
        
        File TAORLadeImpl.cls.xml 0 Remove
      - File TAORLade.cls.xml 0 Remove
    - Folder impl 0
      - File MaatwerkProductImpl.cls.xml 0 Remove
  - Folder VKP/enu 0
    - Folder Klant 0
      - File AutoComplete.cls.xml 0 Remove
      - File Verwerker.cls.xml 0 Remove
    - File Klant.cls.xml 0 Remove
- Folder vhTest 0
  - Folder Fake/APPS/Halux 0
    - Folder PPS 0
      - Folder Activiteit/impl/TAOR/Zijkant 0
        
        File KamerFreesIsoProgrammaBepaler.cls.xml 0 Remove
      - Folder TAORProductie/impl 0
        
        File ZijkantLijmProgrammaBepaler.cls.xml 0 Remove
      - Folder impl 0
        
        File ZijkantLijmProgrammaBepaler.cls.xml 0 Remove
    - Folder common/impl/ProductieGroepBepaler 0
      - File ProductieOpstartfaseBepalerTAX.cls.xml 0 Remove
  - Folder Mock 0
    - Folder APPS 0
      - Folder Halux 0
        
        Folder PPS 0
        
        Folder Activiteit/impl/TAOR/Zijkant 0
        
        File KamerFreesIsoProgrammaBepaler.cls.xml 0 Remove
        
        File VerwerkingIDBepaler.cls.xml 0 Remove
        
        Folder TAORProductie/impl 0
        
        File ZijkantLijmProgrammaBepaler.cls.xml 0 Remove
        
        Folder impl 0
        
        File ZijkantLijmProgrammaBepaler.cls.xml 0 Remove
        
        Folder common/impl/ProductieGroepBepaler 0
        
        File ProductieOpstartfaseBepalerTAX.cls.xml 0 Remove
      - Folder common 0
        
        File KlantInstellingenService.cls.xml 0 Remove
    - Folder DOM/PM/TAORProduct 0
      - File TAORLade.cls.xml 0 Remove
- Folder vhUnitTest/APPS/Halux 0
  - Folder PPS 0
    - Folder Activiteit/impl/TAOR 0
      - Folder LijstVerwerkers/Opdeelzaag/OptimalisatieBestandenGenerator/VoerUit 0
        
        File TestProductGroep.cls.xml 0 Remove
      - Folder Zijkant 0
        
        Folder KamerFreesDataAanvuller/VulAan 0
        
        File Test.cls.xml 0 Remove
        
        Folder KamerFreesDataDimensiesAanvuller/VulAan 0
        
        File Test.cls.xml 0 Remove
        
        Folder KamerFreesDataPickingAanvuller/VulAan 0
        
        File Test.cls.xml 0 Remove
        
        Folder KamerFreesDataProgrammaAanvuller/VulAan 0
        
        File Test.cls.xml 0 Remove
        
        Folder KamerFreesIsoProgrammaBepaler 0
        
        File Test.cls.xml 0 Remove
        
        Folder VerwerkingIDBepaler/BepaalVerwerkingID 0
        
        File Test.cls.xml 0 Remove
        
        File KamerFreesDataAanvullerTestBase.cls.xml 0 Remove
    - Folder TAORProductie/impl/ZijkantLijmProgrammaBepaler 0
      - File Test.cls.xml 1 Remove
    - Folder impl 0
      - Folder ZijkantLijmProgrammaBepaler 0 Remove
        
        Folder BepaalProgramma 0 Remove
        
        File Test.cls.xml 0 Remove
  - Folder common/impl 0
    - Folder ProductieGroepBepaler/ProductieOpstartfaseBepalerTAX/IsInOpstartfase 0
      - File Test.cls.xml 4 Remove
    - Folder ProductieGroepBepalerTAX/GeefProductieGroep 0
      - File Test.cls.xml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Tommy Hebb	Author & Moderator	46m	2	Heum... waarom? Die verandert toch nooit en hoeft tussen ...
Tom Vermeulen	Reviewer - Complete	1h 26m	1 (1 defect)	ineens een Set van maken, lijn wordt korter en leesbaarder
Wim Vermeulen	Reviewer - Complete	2h 6m	3	Ik had verwacht dat "Product" of "ProductId" reeds werd d...
Total		4h 19m	6 (1 defect)

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/vhTest/.../impl/ZijkantLijmProgrammaBepaler.cls.xml Deleted

Click to load diff

/vhUnitTest/.../impl/ZijkantLijmProgrammaBepaler/ Deleted

Click to load diff

/vhUnitTest/.../ZijkantLijmProgrammaBepaler/BepaalProgramma/ Deleted

Click to load diff

/vhUnitTest/.../BepaalProgramma/Test.cls.xml Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-2274

[ICT-2144] [rvWV] HX: TAX koppeling: hoogteverstelling pilootklanten...

CR-2274 6

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

[ICT-2144] [rvWV] HX: TAX koppeling: hoogteverstelling pilootklanten...

CR-2274 6

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against