CR-2325 [ICT-163] [rvTVE] Verkoopfacturen synchronisatie is overbodig geworden. De code en backgroundjob mag...

open for 4 years due 4 years ago

Author

Moderator

Reviewers

[ICT-163] [rvTVE] Verkoopfacturen synchronisatie is overbodig geworden. De code...

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 19

CacheAdminA_trunk2010 (root:) 0
- Folder AX 0
  - Folder Uitgaand/BKH/OpenstaandeVerkoopFactuur/impl 0
    - File Synchroniser.cls.xml 0 Remove
    - File TransactionLockingRepository.cls.xml 0 Remove
    - File TransactionRepository.cls.xml 0 Remove
    - File TransactionToOpenstaandeFactuurIdConverter.cls.xml 0 Remove
  - File CARETAKER.mac.rou 1 Remove
- Folder vhTest 0
  - Folder Fake/AX/Uitgaand/BKH/OpenstaandeVerkoopFactuur/impl 0
    - File TransactionLockingRepository.cls.xml 0 Remove
    - File TransactionRepository.cls.xml 0 Remove
    - File TransactionToOpenstaandeFactuurIdConverter.cls.xml 0 Remove
  - Folder Mock/AX/Uitgaand/BKH/OpenstaandeVerkoopFactuur/impl 0
    - File TransactionLockingRepository.cls.xml 0 Remove
    - File TransactionRepository.cls.xml 0 Remove
    - File TransactionToOpenstaandeFactuurIdConverter.cls.xml 0 Remove
- Folder vhUnitTest/AX/Uitgaand/BKH 0
  - Folder OpenstaandeVerkoopFactuur 0 Remove
    - Folder impl 0 Remove
      - Folder Synchroniser 0 Remove
        
        File Test.cls.xml 0 Remove
      - Folder TransactionRepository 0 Remove
        
        File Test.cls.xml 0 Remove
      - Folder TransactionToOpenstaandeFactuurIdConverter 0 Remove
        
        File Test.cls.xml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Jelle Baele	Author & Moderator	6m	2	Deze routine moet nog verwijderd worden samen met de back...
Tom Vermeulen	Reviewer - Complete	21m
Total		27m	2

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Jelle Baele

Voorlopig heb ik enkel de code die uitgevoerd moet worden in de AX.CARETAKER....

Voorlopig heb ik enkel de code die uitgevoerd moet worden in de AX.CARETAKER.mac in commentaar gezet om zeker te zijn dat ik de juiste backgroundjob heb genomen (de beschrijving in het kaartje leek mij niet juist, dus heb mij gebaseerd op de titel van het kaartje en de bijhorende backgroundjob dat ik hierbij gevonden heb).

08 Jul 21

/AX/Uitgaand/.../impl/Synchroniser.cls.xml Deleted

Click to load diff

/AX/.../impl/TransactionLockingRepository.cls.xml Deleted

Click to load diff

/AX/.../impl/TransactionRepository.cls.xml Deleted

Click to load diff

/AX/.../impl/TransactionToOpenstaandeFactuurIdConverter.cls.xml Deleted

Click to load diff

/vhTest/.../impl/TransactionLockingRepository.cls.xml Deleted

Click to load diff

/vhTest/.../impl/TransactionRepository.cls.xml Deleted

Click to load diff

/vhTest/.../impl/TransactionToOpenstaandeFactuurIdConverter.cls.xml Deleted

Click to load diff

/vhTest/.../impl/TransactionLockingRepository.cls.xml Deleted

Click to load diff

/vhTest/.../impl/TransactionRepository.cls.xml Deleted

Click to load diff

/vhTest/.../impl/TransactionToOpenstaandeFactuurIdConverter.cls.xml Deleted

Click to load diff

/vhUnitTest/.../BKH/OpenstaandeVerkoopFactuur/ Deleted

Click to load diff

/vhUnitTest/.../OpenstaandeVerkoopFactuur/impl/ Deleted

Click to load diff

/vhUnitTest/AX/.../Synchroniser/Test.cls.xml Deleted

Click to load diff

/vhUnitTest/AX/.../impl/TransactionRepository/ Deleted

Click to load diff

/vhUnitTest/.../TransactionRepository/Test.cls.xml Deleted

Click to load diff

/vhUnitTest/.../impl/TransactionToOpenstaandeFactuurIdConverter/ Deleted

Click to load diff

/vhUnitTest/.../TransactionToOpenstaandeFactuurIdConverter/Test.cls.xml Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-2325

[ICT-163] [rvTVE] Verkoopfacturen synchronisatie is overbodig geworden. De code...

CR-2325 2

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jelle Baele

Log time against

[ICT-163] [rvTVE] Verkoopfacturen synchronisatie is overbodig geworden. De code...

CR-2325 2

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jelle Baele

Log time against