CR-2416 [ICT-1611] [rvWV] VKP: Klantkost: opkuis APPS.common.KlantKost package in caché, want niet meer in gebruik.

closed on 14 Apr 22

Author

Moderator

Reviewers

[ICT-1611] [rvWV] VKP: Klantkost: opkuis APPS.common.KlantKost package in caché,...

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 70

CacheAdminA_trunk2010 (root:) 0
- Folder APPS 0
  - Folder TRANSP/GLS/Shipment 0
    - Folder Verwerker 0 Remove
      - File GLSTransportKostItem.cls.xml 0 Remove
      - File IndividueelKostItem.cls.xml 0 Remove
    - Folder data 0
      - File GLSTransportKostItem.cls.xml 0 Remove
      - File IndividueelKostItem.cls.xml 0 Remove
    - File Verwerker.cls.xml 0 Remove
  - Folder common 0
    - Folder KlantKost 0 Remove
      - Folder enu 0 Remove
        
        File KostType.cls.xml 0 Remove
      - Folder impl 0 Remove
        
        Folder KlantKost 0 Remove
        
        Folder dto 0 Remove
        
        File Factor.cls.xml 0 Remove
        
        File FactorGateway.cls.xml 0 Remove
        
        Folder KlantKostService 0 Remove
        
        File TransportFactorenInitiator.cls.xml 0 Remove
        
        Folder data 0 Remove
        
        File AfhalingKostItem.cls.xml 0 Remove
        
        File BezoekKostItem.cls.xml 0 Remove
        
        File BulkTransportKostItem.cls.xml 0 Remove
        
        File DoorgerekendKostItem.cls.xml 0 Remove
        
        File EnkelvoudigeFactor.cls.xml 0 Remove
        
        File Factor.cls.xml 0 Remove
        
        File GLSTransportKostItem.cls.xml 0 Remove
        
        File GenotenKortingContantItem.cls.xml 0 Remove
        
        File IndividueelKostItem.cls.xml 0 Remove
        
        File LosTransportKostItem.cls.xml 0 Remove
        
        File MaandKost.cls.xml 0 Remove
        
        File MeervoudigeFactor.cls.xml 0 Remove
        
        File MeervoudigeKlantSpecifiekeFactor.cls.xml 0 Remove
        
        File MonsterKostItem.cls.xml 0 Remove
        
        File OrderIngaveLoonKostItem.cls.xml 0 Remove
        
        File PostKostItem.cls.xml 0 Remove
        
        File RitTransportKostItem.cls.xml 0 Remove
        
        File AfhalingKostCalculator.cls.xml 0 Remove
        
        File BezoekKostCalculator.cls.xml 0 Remove
        
        File GenotenKortingContantCalculator.cls.xml 0 Remove
        
        File KlantKostService.cls.xml 0 Remove
        
        File KostCalculator.cls.xml 0 Remove
        
        File MaandKostAggregator.cls.xml 0 Remove
        
        File MonsterKostCalculator.cls.xml 0 Remove
        
        File OrderIngaveLoonKostCalculator.cls.xml 0 Remove
        
        File TransportKostCalculator.cls.xml 0 Remove
      - File KlantKostService.cls.xml 0 Remove
- Folder Stat 0
  - Folder enu 0 Remove
    - File KlantKostType.cls.xml 0 Remove
  - File OmzetKlantProductMaand.cls.xml 0 Remove
- Folder vhDeploy 0
  - File D20220103xKlantKostDataOpkuis.cls.xml 0 Remove
- Folder vhUnitTest/APPS 0
  - Folder TRANSP/GLS/Shipment/Verwerker 0
    - File DataMKlantAPI.cls.xml 0 Remove
    - File TestGLSMeerdereBonnenInEenTransport.cls.xml 0 Remove
    - File TestGLSService.cls.xml 0 Remove
  - Folder common 0
    - Folder KlantKost 0 Remove
      - Folder impl 0 Remove
        
        File KlantKostService.cls.xml 0 Remove
        
        File TransportKostCalculator.cls.xml 0 Remove
      - File DataMKlantAPI.cls.xml 0 Remove
      - File KostUtils.cls.xml 0 Remove
      - File TestAfhalingKosten.cls.xml 0 Remove
      - File TestBezoekKosten.cls.xml 0 Remove
      - File TestCommercieleOverdracht.cls.xml 0 Remove
      - File TestDoorgerekendeKosten.cls.xml 0 Remove
      - File TestFactor.cls.xml 0 Remove
      - File TestGenotenKortingContant.cls.xml 0 Remove
      - File TestMonsterKosten.cls.xml 0 Remove
      - File TestOrderIngaveLoonKost.cls.xml 0 Remove
      - File TestPortKosten.cls.xml 0 Remove
      - File TestTransportKosten.cls.xml 0 Remove
      - File TestTransportKostenDI2en3.cls.xml 0 Remove
- Folder zTryout/JLM 0
  - File KlantKostDataLooper.cls.xml 0 Remove
- File vhCARETAKER.mac.rou 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Joannes Lemmens	Author & Moderator	15m
Wim Vermeulen	Reviewer - Complete	16m	1	Wanneer meer dan 90% van de klassen verwijderd worden, da...
Total		31m	1

#permalink

Objectives

Context: Stukken software in Admin om kosten die VH heeft aan klanten expliciet te berekenen en bewaren, met als doel deze op de KPI "Klant Product Analyse" te tonen.Dat KPI-KPA-bestand is echter al enkele jaren niet meer in gebruik (vervanging in Qlik).

Te bekomen resultaat is dat die code verwijderd wordt.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Wim Vermeulen

Wanneer meer dan 90% van de klassen verwijderd worden, dan valt er nog weinig...

Wanneer meer dan 90% van de klassen verwijderd worden, dan valt er nog weinig te reviewen. De blijvende implementaties uiteraard, die zijn "Review O.K."
Indien een klasse onterecht verwijderd zou zijn, zal ik als reviewer hier helaas niet kunnen opmerken.
Er zijn wel nog enkele deploy-klassen die verwijzen naar de package "APPS.common.KlantKost". Deze kan je best ook nog opkuisen.

13 Apr 22

Click to load diff

/APPS/.../Verwerker/GLSTransportKostItem.cls.xml Deleted

Click to load diff

/APPS/.../Verwerker/IndividueelKostItem.cls.xml Deleted

Click to load diff

/APPS/common/KlantKost/impl/KlantKost/dto/ Deleted

Click to load diff

/APPS/common/.../KlantKost/dto/Factor.cls.xml Deleted

Click to load diff

/APPS/.../KlantKost/FactorGateway.cls.xml Deleted

Click to load diff

/APPS/.../KlantKostService/TransportFactorenInitiator.cls.xml Deleted

Click to load diff

/APPS/common/.../data/AfhalingKostItem.cls.xml Deleted

Click to load diff

/APPS/common/.../data/BezoekKostItem.cls.xml Deleted

Click to load diff

/APPS/.../data/BulkTransportKostItem.cls.xml Deleted

Click to load diff

/APPS/.../data/DoorgerekendKostItem.cls.xml Deleted

Click to load diff

/APPS/.../data/EnkelvoudigeFactor.cls.xml Deleted

Click to load diff

/APPS/common/.../impl/data/Factor.cls.xml Deleted

Click to load diff

/APPS/.../data/GLSTransportKostItem.cls.xml Deleted

Click to load diff

/APPS/.../data/GenotenKortingContantItem.cls.xml Deleted

Click to load diff

/APPS/.../data/IndividueelKostItem.cls.xml Deleted

Click to load diff

/APPS/.../data/LosTransportKostItem.cls.xml Deleted

Click to load diff

/APPS/common/.../impl/data/MaandKost.cls.xml Deleted

Click to load diff

/APPS/.../data/MeervoudigeFactor.cls.xml Deleted

Click to load diff

/APPS/.../data/MeervoudigeKlantSpecifiekeFactor.cls.xml Deleted

Click to load diff

/APPS/common/.../data/MonsterKostItem.cls.xml Deleted

Click to load diff

/APPS/.../data/OrderIngaveLoonKostItem.cls.xml Deleted

Click to load diff

/APPS/common/.../data/PostKostItem.cls.xml Deleted

Click to load diff

/APPS/.../data/RitTransportKostItem.cls.xml Deleted

Click to load diff

/APPS/.../impl/AfhalingKostCalculator.cls.xml Deleted

Click to load diff

/APPS/.../impl/BezoekKostCalculator.cls.xml Deleted

Click to load diff

/APPS/.../impl/GenotenKortingContantCalculator.cls.xml Deleted

Click to load diff

/APPS/common/.../impl/KlantKostService.cls.xml Deleted

Click to load diff

/APPS/common/.../impl/KostCalculator.cls.xml Deleted

Click to load diff

/APPS/.../impl/MaandKostAggregator.cls.xml Deleted

Click to load diff

/APPS/.../impl/MonsterKostCalculator.cls.xml Deleted

Click to load diff

/APPS/.../impl/OrderIngaveLoonKostCalculator.cls.xml Deleted

Click to load diff

/APPS/.../impl/TransportKostCalculator.cls.xml Deleted

Click to load diff

/APPS/.../KlantKost/KlantKostService.cls.xml Deleted

Click to load diff

/vhUnitTest/.../impl/KlantKostService.cls.xml Deleted

Click to load diff

/vhUnitTest/.../impl/TransportKostCalculator.cls.xml Deleted

Click to load diff

/vhUnitTest/.../KlantKost/DataMKlantAPI.cls.xml Deleted

Click to load diff

/vhUnitTest/.../KlantKost/KostUtils.cls.xml Deleted

Click to load diff

/vhUnitTest/.../KlantKost/TestAfhalingKosten.cls.xml Deleted

Click to load diff

/vhUnitTest/.../KlantKost/TestBezoekKosten.cls.xml Deleted

Click to load diff

/vhUnitTest/.../KlantKost/TestCommercieleOverdracht.cls.xml Deleted

Click to load diff

/vhUnitTest/.../KlantKost/TestDoorgerekendeKosten.cls.xml Deleted

Click to load diff

/vhUnitTest/.../KlantKost/TestFactor.cls.xml Deleted

Click to load diff

/vhUnitTest/.../KlantKost/TestGenotenKortingContant.cls.xml Deleted

Click to load diff

/vhUnitTest/.../KlantKost/TestMonsterKosten.cls.xml Deleted

Click to load diff

/vhUnitTest/.../KlantKost/TestOrderIngaveLoonKost.cls.xml Deleted

Click to load diff

/vhUnitTest/.../KlantKost/TestPortKosten.cls.xml Deleted

Click to load diff

/vhUnitTest/.../KlantKost/TestTransportKosten.cls.xml Deleted

Click to load diff

/vhUnitTest/.../KlantKost/TestTransportKostenDI2en3.cls.xml Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-2416

[ICT-1611] [rvWV] VKP: Klantkost: opkuis APPS.common.KlantKost package in caché,...

CR-2416 1

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Wim Vermeulen

Log time against

[ICT-1611] [rvWV] VKP: Klantkost: opkuis APPS.common.KlantKost package in caché,...

CR-2416 1

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Wim Vermeulen

Log time against