CR-2421 [ICT-1432] [rvJWI] HR: Brandlijst: oude code opkuisen DOM.HR.*:

closed on 26 Jan 24

Author

Moderator

Reviewers

[ICT-1432] [rvJWI] HR: Brandlijst: oude code opkuisen DOM.HR.*:

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 85

CacheAdminA_trunk2010 (root:) 0
- Folder APPS 0
  - Folder HR 0 Remove
    - Folder ProTime 0 Remove
      - File Facade.cls.xml 0 Remove
    - Folder WerknemersLijstBijBrand 0 Remove
      - Folder dto 0 Remove
        
        File Statuut.cls.xml 0 Remove
        
        File Werkgever.cls.xml 0 Remove
        
        File Werknemer.cls.xml 0 Remove
        
        File WerknemersLijst.cls.xml 0 Remove
    - Folder WieIsWie 0 Remove
      - File Facade.cls.xml 0 Remove
  - Folder Halux/Planning 0
    - Folder Activiteit/impl 0
      - File ActiviteitPerBatchService.cls.xml 0 Remove
    - Folder impl 0
      - File DisplayInfoGeproduceerd.cls.xml 0 Remove
  - Folder Stat 0
    - Folder TAXAttentie 0 Remove
      - Folder dto 0 Remove
        
        File Data.cls.xml 0 Remove
      - Folder impl 0 Remove
        
        File DataExporter.cls.xml 0 Remove
        
        File DataVerzamelaar.cls.xml 0 Remove
        
        File MailVerzender.cls.xml 0 Remove
        
        File Repository.cls.xml 0 Remove
        
        File TAXAttentieService.cls.xml 0 Remove
    - File TAXAttentieService.cls.xml 0 Remove
- Folder BL 0
  - Folder HR 0 Remove
    - File WerknemersLijstBrandDoc.cls.xml 0 Remove
- Folder DOM/HR 0
  - Folder Protime 0 Remove
    - Folder impl 0 Remove
      - File AanwezigheidRepo.cls.xml 0 Remove
      - File ProtimeAPI.cls.xml 0 Remove
      - File WerknemerConverteerder.cls.xml 0 Remove
      - File WerknemerRepository.cls.xml 0 Remove
    - File AanwezigheidRepo.cls.xml 0 Remove
    - File Afdeling.cls.xml 0 Remove
    - File Functie.cls.xml 0 Remove
    - File Werkgever.cls.xml 0 Remove
    - File Werknemer.cls.xml 0 Remove
    - File WerknemerGateway.cls.xml 0 Remove
  - Folder dto 0 Remove
    - File Werknemer.cls.xml 0 Remove
    - File WerknemerAanwezigheden.cls.xml 0 Remove
    - File WerknemerAanwezigheid.cls.xml 0 Remove
    - File Werknemers.cls.xml 0 Remove
  - Folder enu 0 Remove
    - File Aanwezigheid.cls.xml 0 Remove
    - File Bedrijf.cls.xml 0 Remove
    - File Statuut.cls.xml 0 Remove
    - File Werkgever.cls.xml 0 Remove
  - Folder impl 0 Remove
    - File WerknemerRepository.cls.xml 0 Remove
  - File ProtimeAPI.cls.xml 0 Remove
  - File WerknemerRepository.cls.xml 0 Remove
- Folder WS 0
  - Folder HR 0 Remove
    - Folder BrandLijst 0 Remove
      - File BrandLijstService.cls.xml 0 Remove
  - Folder Halux/Planning 0
    - File ActiviteitPerBatchService.cls.xml 0 Remove
- Folder vhTest 0
  - Folder Fake/DOM 0
    - Folder HR 0 Remove
      - Folder Protime 0 Remove
        
        Folder impl 0 Remove
        
        File WerknemerConverteerder.cls.xml 0 Remove
        
        File WerknemerGateway.cls.xml 0 Remove
  - Folder Mock/DOM 0
    - Folder HR 0 Remove
      - Folder Protime 0 Remove
        
        Folder impl 0 Remove
        
        File WerknemerConverteerder.cls.xml 0 Remove
        
        File AanwezigheidRepo.cls.xml 0 Remove
        
        File WerknemerGateway.cls.xml 0 Remove
      - File ProtimeAPI.cls.xml 0 Remove
      - File WerknemerRepository.cls.xml 0 Remove
- Folder vhTestFiles/IntegratieTests/Webservices.WSDLControle/Test 0
  - File WS.HR.BrandLijst.BrandLijstService.txt 0 Remove
  - File WS.Halux.Planning.ActiviteitPerBatchService.txt 0 Remove
- Folder vhUnitTest 0
  - Folder APPS 0
    - Folder HR 0 Remove
      - Folder ProTime 0 Remove
        
        File Facade.cls.xml 0 Remove
        
        File FacadeUpdate.cls.xml 0 Remove
        
        File TestFacade.cls.xml 0 Remove
  - Folder DOM 0
    - Folder HR 0 Remove
      - Folder impl 0 Remove
        
        Folder WerknemerRepository 0 Remove
        
        Folder GeefWerknemer 0 Remove
        
        File Test.cls.xml 0 Remove
        
        Folder GeefWerknemers 0 Remove
        
        File Test.cls.xml 0 Remove
        
        Folder GeefWerknemersInDienst 0 Remove
        
        File Test.cls.xml 0 Remove
- File vhCARETAKER.mac.rou 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Joannes Lemmens	Author & Moderator	38m
Jo Willems	Reviewer - Complete	25m	1	Er is nog een csp pagina met een query die verwijst naar ...
Total		1h 3m	1

#permalink

Objectives

ICT-1432

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Jo Willems

Er is nog een csp pagina met een query die verwijst naar de global die je op ...

Er is nog een csp pagina met een query die verwijst naar de global die je op gaat kuisen. csp.HR.Medewerkers.cls
En er is nog wel wat code die naar die global verwijst.
Een 'search in files' gewoon naar 'protime' brengt nog wel wat code aan het licht.
Ik denk dat er ook nog wat onderzoek zal moeten gebeuren of deze overblijvende code al dan niet nog gebruikt wordt. er wordt nog gerefereerd naar protime nummers. van waar komen die dan?
Dat zal verder bepalen of er mss reeds uitgevoerde deletes moeten teruggedraaid worden of niet.

07 Apr 22

Jo Willems

Unresolved

07 Apr 22

Click to load diff

/APPS/Stat/.../impl/DataExporter.cls.xml Deleted

Click to load diff

/APPS/Stat/.../impl/DataVerzamelaar.cls.xml Deleted

Click to load diff

/APPS/Stat/.../impl/MailVerzender.cls.xml Deleted

Click to load diff

/APPS/Stat/.../impl/TAXAttentieService.cls.xml Deleted

Click to load diff

/DOM/HR/.../impl/AanwezigheidRepo.cls.xml Deleted

Click to load diff

/DOM/.../impl/WerknemerConverteerder.cls.xml Deleted

Click to load diff

/DOM/HR/.../impl/WerknemerRepository.cls.xml Deleted

Click to load diff

/DOM/HR/Protime/AanwezigheidRepo.cls.xml Deleted

Click to load diff

/DOM/HR/Protime/WerknemerGateway.cls.xml Deleted

Click to load diff

/DOM/HR/dto/WerknemerAanwezigheden.cls.xml Deleted

Click to load diff

/DOM/HR/dto/WerknemerAanwezigheid.cls.xml Deleted

Click to load diff

/DOM/HR/impl/WerknemerRepository.cls.xml Deleted

Click to load diff

/vhTest/.../impl/WerknemerConverteerder.cls.xml Deleted

Click to load diff

/vhTest/.../Protime/WerknemerGateway.cls.xml Deleted

Click to load diff

/vhTest/.../impl/WerknemerConverteerder.cls.xml Deleted

Click to load diff

/vhTest/.../Protime/AanwezigheidRepo.cls.xml Deleted

Click to load diff

/vhTest/.../Protime/WerknemerGateway.cls.xml Deleted

Click to load diff

/vhTest/.../HR/WerknemerRepository.cls.xml Deleted

Click to load diff

/vhUnitTest/APPS/HR/ProTime/Facade.cls.xml Deleted

Click to load diff

/vhUnitTest/.../ProTime/FacadeUpdate.cls.xml Deleted

Click to load diff

/vhUnitTest/.../ProTime/TestFacade.cls.xml Deleted

Click to load diff

/vhUnitTest/DOM/.../impl/WerknemerRepository/ Deleted

Click to load diff

/vhUnitTest/.../WerknemerRepository/GeefWerknemer/ Deleted

Click to load diff

/vhUnitTest/DOM/.../GeefWerknemer/Test.cls.xml Deleted

Click to load diff

/vhUnitTest/.../WerknemerRepository/GeefWerknemers/ Deleted

Click to load diff

/vhUnitTest/.../GeefWerknemers/Test.cls.xml Deleted

Click to load diff

/vhUnitTest/.../WerknemerRepository/GeefWerknemersInDienst/ Deleted

Click to load diff

/vhUnitTest/.../GeefWerknemersInDienst/Test.cls.xml Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-2421

[ICT-1432] [rvJWI] HR: Brandlijst: oude code opkuisen DOM.HR.*:

CR-2421 1

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jo Willems

Log time against

[ICT-1432] [rvJWI] HR: Brandlijst: oude code opkuisen DOM.HR.*:

CR-2421 1

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jo Willems

Log time against