CR-2465 [ICT-2932] INK: Productcreatie INK

closed on 14 Jul 22

Author

Moderator

Reviewers

[ICT-2932] INK: Productcreatie INK

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 83

CacheAdminA_trunk2010 (root:) 0
- Folder APPS/PM/Maatwerk 0
  - Folder dto 0
    - File INKKenmerken.cls.xml 0 Remove
  - Folder impl 0
    - Folder KenmerkenValidator 0
      - File INK.cls.xml 0 Remove
    - File DtoNaarKenmerkVisitor.cls.xml 0 Remove
- Folder DOM/PM 0
  - Folder INKProduct 0 Remove
    - Folder impl 0 Remove
      - File INKIngekort.cls.xml 0 Remove
    - File INKIngekort.cls.xml 0 Remove
  - Folder Maatwerk 0
    - Folder BewerktHalffabrikaat 0
      - Folder impl 0 Remove
        
        File BaseEnums.cls.xml 0 Remove
    - Folder Calc 0
      - Folder Common 0
        
        Folder impl 0
        
        File INKKenmerken.cls.xml 0 Remove
        
        File OmleidingNaarDotNetBepaler.cls.xml 0 Remove
        
        File IKCanonischeWaardeGenerator.cls.xml 0 Remove
        
        File IngegevenKenmerkenVisitor.cls.xml 0 Remove
      - Folder HF/enu 0
        
        Folder INKRol 0 Remove
        
        File AutoComplete.cls.xml 0 Remove
        
        File Verwerker.cls.xml 0 Remove
        
        File INKRol.cls.xml 0 Remove
    - Folder INK/impl 0
      - File Base.cls.xml 0 Remove
      - File BaseEnums.cls.xml 0 Remove
    - File GenerischProductBepaler.cls.xml 0 Remove
  - Folder enu 0
    - Folder Familie 0
      - File AutoComplete.cls.xml 0 Remove
      - File Verwerker.cls.xml 0 Remove
    - Folder ProductType 0
      - File AutoComplete.cls.xml 0 Remove
      - File Verwerker.cls.xml 0 Remove
    - Folder Variant 0
      - File AutoComplete.cls.xml 0 Remove
      - File Verwerker.cls.xml 0 Remove
    - File Familie.cls.xml 0 Remove
    - File ProductType.cls.xml 0 Remove
    - File Variant.cls.xml 0 Remove
  - Folder impl 0
    - Folder DataM 0
      - File DataMINKCreator.cls.xml 0 Remove
    - File ProductAPI.cls.xml 0 Remove
    - File ProductTypeAPIimpl.cls.xml 0 Remove
  - File ProductTypeAPI.cls.xml 0 Remove
- Folder DOTNET/PM/Maatwerk/Converter 0
  - File DomNaarDotnet.cls.xml 0 Remove
- Folder ECON/PM/Maatwerk/dto 0
  - File InkKenmerken.cls.xml 0 Remove
- Folder ECONimpl/PM/Maatwerk/KenmerkenConverter 0
  - Folder AppsNaarEcon 0
    - File Ink.cls.xml 0 Remove
  - Folder EconNaarApps 0
    - File Ink.cls.xml 0 Remove
  - File EconNaarAppsFactory.cls.xml 0 Remove
- Folder WSimpl 0
  - Folder AX/CalculatedProduct 0
    - File LadeVariantBepaler.cls.xml 0 Remove
    - File ProductUpdater.cls.xml 0 Remove
  - Folder PM/Maatwerk/MaatwerkService/DotNet 0
    - File GeefMaatwerkDetails.cls.xml 0 Remove
  - Folder Vhisie4/Winkelkar 0
    - File EconConfiguratieConverter.cls.xml 0 Remove
- Folder vhConsistency/Checks/DOM/PM/GenerischeProducten 0
  - File ProductTypeVerwerker.cls.xml 0 Remove
- Folder vhTest 0
  - Folder DOM/PM/Maatwerk 0
    - Folder INK 0 Remove
      - File Base.cls.xml 0 Remove
  - Folder Fake 0
    - Folder APPS/PM/Maatwerk/impl/KenmerkenValidator 0
      - File INK.cls.xml 0 Remove
    - Folder DOM/PM/impl 0
      - File ProductTypeAPIimpl.cls.xml 0 Remove
  - Folder Mock 0
    - Folder APPS/PM/Maatwerk/impl/KenmerkenValidator 0
      - File INK.cls.xml 0 Remove
    - Folder DOM/PM 0
      - Folder INKProduct 0 Remove
        
        File INKIngekort.cls.xml 0 Remove
      - Folder impl 0
        
        File ProductTypeAPIimpl.cls.xml 0 Remove
      - File ProductTypeAPI.cls.xml 0 Remove
  - Folder Utils 0
    - Folder APPS/PM/Maatwerk/dto 0
      - File INKKenmerken.cls.xml 0 Remove
    - Folder AXimpl/PM/Maatwerk 0
      - File InkKenmerken.cls.xml 0 Remove
    - Folder ECON/PM/Maatwerk/dto 0
      - File InkKenmerken.cls.xml 0 Remove
- Folder vhTestFiles/IntegratieTests/Webservices.WSDLControle/Test 0
  - File WS.APPS.VKP.VerkoopService.txt 0 Remove
  - File WS.EC.ConfiguratorKenmerkenGetter.txt 0 Remove
  - File WS.EC.ExterneVerkoopService.txt 0 Remove
  - File WS.EC.InterneConfiguratorService.txt 0 Remove
  - File WS.EC.InterneVerkoopService.txt 0 Remove
  - File WS.EC.SessieLozeExterneVerkoopService.txt 0 Remove
  - File WS.EC.WebshopConfiguratorService.txt 0 Remove
  - File WS.EC.Winkelkar.ExterneWinkelkarService.txt 0 Remove
  - File WS.EC.Winkelkar.InterneWinkelkarService.txt 0 Remove
  - File WS.EC.Winkelkar.WinkelkarService.txt 0 Remove
  - File WS.PM.Maatwerk.Framework.ConfiguratieService.txt 0 Remove
  - File WS.PM.Maatwerk.MaatwerkService.txt 0 Remove
  - File WS.PM.Specials.SpecialsEditorService.txt 0 Remove
  - File WS.TBX.DataIO.txt 0 Remove
  - File WS.VKP.Maatwerk.ConfiguratorService.txt 0 Remove
  - File WS.Vhisie4.Winkelkar.WinkelkarService.txt 0 Remove
- Folder vhUnitTest 0
  - Folder AXimpl/PM/Maatwerk 0
    - Folder INK 0 Remove
      - Folder AxNaarEconConverter 0 Remove
        
        File Test.cls.xml 3 Remove
  - Folder DOM/PM 0
    - Folder Maatwerk 0
      - Folder INK 0
        
        File Base.cls.xml 0 Remove
      - Folder IngegevenKenmerkenTypeAPI/IsLadeMetUitsparing 0
        
        File TestVoorAlleKenmerkenKlassen.cls.xml 0 Remove
    - Folder MaatwerkProduct/GeefHalffabItemsBoom 0
      - File Test.cls.xml 0 Remove
    - Folder impl/IKCanonischeWaarde 0
      - File TestINKKenmerken.cls.xml 0 Remove
  - Folder ECONimpl/PM/Maatwerk/KenmerkenConverter 0
    - Folder AppsNaarEcon 0
      - Folder Ink 0 Remove
        
        File Test.cls.xml 0 Remove
    - Folder EconNaarApps 0
      - Folder Ink 0 Remove
        
        File Test.cls.xml 0 Remove
    - Folder EconNaarAppsFactory 0
      - File Test.cls.xml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Peter Vercoutter	Author & Moderator	3m	1	Je doet een vergelijking van de verschillen, dus je wilt ...
Jelle Baele	Reviewer - Complete	12m	2	Vanwaar assert empty list?
Total		14m	3

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/DOM/PM/Maatwerk/BewerktHalffabrikaat/impl/ Added

Click to load diff

/vhUnitTest/AXimpl/.../INK/AxNaarEconConverter/ Added

Click to load diff

/vhUnitTest/ECONimpl/.../AppsNaarEcon/Ink/ Added

Click to load diff

/vhUnitTest/ECONimpl/.../EconNaarApps/Ink/ Added

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-2465

[ICT-2932] INK: Productcreatie INK

CR-2465 3

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

[ICT-2932] INK: Productcreatie INK

CR-2465 3

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against