CR-2472 [ICT-3041] [rvPVR] Revego: Eerste opzet BomBol generatie:

closed on 08 Aug 22

Author

Moderator

Reviewers

[ICT-3041] [rvPVR] Revego: Eerste opzet BomBol generatie:

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 76

CacheAdminA_trunk2010 (root:) 0
- Folder APPS/PM/Maatwerk 0
  - Folder dto 0
    - File IngegevenKenmerkenVisitor.cls.xml 0 Remove
    - File RVGKenmerken.cls.xml 0 Remove
  - Folder impl 0
    - Folder KenmerkenValidator 0
      - File RVG.cls.xml 0 Remove
    - Folder RVG 0 Remove
      - File DtoNaarKenmerkConverter.cls.xml 0 Remove
    - File DtoNaarKenmerkVisitor.cls.xml 0 Remove
- Folder DOM/PM 0
  - Folder Maatwerk 0
    - Folder Calc 0
      - Folder Common 0
        
        Folder impl 0
        
        File OmleidingNaarDotNetBepaler.cls.xml 0 Remove
        
        File RVGKenmerken.cls.xml 0 Remove
        
        File IKCanonischeWaardeGenerator.cls.xml 0 Remove
        
        File IngegevenKenmerkenVisitor.cls.xml 0 Remove
      - Folder HF 0
        
        Folder enu 0
        
        Folder RVGRol 0 Remove
        
        File AutoComplete.cls.xml 0 Remove
        
        File Verwerker.cls.xml 0 Remove
        
        File RVGRol.cls.xml 1 Remove
        
        Folder impl 0
        
        Folder RVG 0 Remove
        
        File HalffabClassNameFactory.cls.xml 0 Remove
        
        File SpecHFv001.cls.xml 0 Remove
      - Folder Kost/impl 0
        
        Folder RVG 0 Remove
        
        File SpecKostv001.cls.xml 0 Remove
    - Folder RVG 0 Remove
      - Folder impl 0 Remove
        
        File KorttekstBepaler.cls.xml 2 Remove
    - Folder Syncs/DotNet/MaatwerkCalculator/impl 0
      - File ProductInfo.cls.xml 0 Remove
    - File GenerischProductBepaler.cls.xml 1 Remove
  - Folder enu 0
    - File Familie.cls.xml 0 Remove
  - Folder impl 0
    - Folder DataM 0
      - File DataMRVGLadeCreator.cls.xml 0 Remove
    - File ProductAPI.cls.xml 0 Remove
    - File RVGLangtekstCreator.cls.xml 1 Remove
  - File KorttekstUtils.cls.xml 1 Remove
- Folder DOTNET/PM/Maatwerk/Converter 0
  - File DomNaarDotnet.cls.xml 1 Remove
- Folder ECON/PM/Maatwerk/dto 0
  - File RvgKenmerken.cls.xml 1 Remove
- Folder ECONimpl/PM/Maatwerk/KenmerkenConverter 0
  - Folder EconNaarApps 0
    - File Rvg.cls.xml 1 Remove
  - File EconNaarAppsFactory.cls.xml 0 Remove
- Folder WSimpl 0
  - Folder PM/Maatwerk/MaatwerkService/DotNet 0
    - Folder RolNaamValidator 0
      - File RvgValidator.cls.xml 0 Remove
    - File GeefMaatwerkDetails.cls.xml 0 Remove
    - File RolNaamValidatorFactory.cls.xml 0 Remove
  - Folder Vhisie4/Winkelkar 0
    - File EconConfiguratieConverter.cls.xml 1 Remove
- Folder vhDeploy 0
  - File D20220729xZetGlobalsVoorRVG.cls.xml 0 Remove
  - File Deploy20220728xToevoegenSpecsRVGv001.cls.xml 0 Remove
- Folder vhTest 0
  - Folder Fake/APPS/PM/Maatwerk/impl/KenmerkenValidator 0
    - File RVG.cls.xml 0 Remove
  - Folder Integratie/Webservices/WSDLControle 0
    - File Test.cls.xml 0 Remove
  - Folder Mock/APPS/PM/Maatwerk/impl/KenmerkenValidator 0
    - File RVG.cls.xml 0 Remove
  - Folder Utils 0
    - Folder APPS/PM/Maatwerk/dto 0
      - File RVGKenmerken.cls.xml 0 Remove
    - Folder DOM/PM/Maatwerk/Calc/Common/impl 0
      - File RVGKenmerken.cls.xml 0 Remove
    - Folder ECON/PM/Maatwerk/dto 0
      - File RvgKenmerken.cls.xml 0 Remove
- Folder vhTestFiles/IntegratieTests/Webservices.WSDLControle/Test 0
  - File WS.APPS.VKP.VerkoopService.txt 0 Remove
  - File WS.EC.ConfiguratorKenmerkenGetter.txt 0 Remove
  - File WS.EC.ExterneVerkoopService.txt 0 Remove
  - File WS.EC.InterneConfiguratorService.txt 0 Remove
  - File WS.EC.InterneVerkoopService.txt 0 Remove
  - File WS.EC.SessieLozeExterneVerkoopService.txt 0 Remove
  - File WS.EC.WebshopConfiguratorService.txt 0 Remove
  - File WS.EC.Winkelkar.ExterneWinkelkarService.txt 0 Remove
  - File WS.EC.Winkelkar.InterneWinkelkarService.txt 0 Remove
  - File WS.EC.Winkelkar.WinkelkarService.txt 0 Remove
  - File WS.PM.Maatwerk.Framework.ConfiguratieService.txt 0 Remove
  - File WS.PM.Maatwerk.MaatwerkService.txt 0 Remove
  - File WS.PM.Specials.SpecialsEditorService.txt 0 Remove
  - File WS.TBX.DataIO.txt 0 Remove
  - File WS.VKP.Maatwerk.ConfiguratorService.txt 0 Remove
  - File WS.Vhisie4.Winkelkar.WinkelkarService.txt 0 Remove
- Folder vhUnitTest 0
  - Folder APPS/PM/Maatwerk 0
    - Folder dto 0
      - Folder RVGKenmerken 0 Remove
        
        File Test.cls.xml 0 Remove
    - Folder impl/KenmerkenValidator 0
      - Folder RVG 0 Remove
        
        File Test.cls.xml 0 Remove
  - Folder DOM/PM 0
    - Folder Maatwerk/Calc/Common/impl/OmleidingNaarDotNetBepaler 0
      - Folder HeeftHFBuildersInCache 0
        
        File Test.cls.xml 0 Remove
      - Folder HeeftHFBuildersInDotNet 0
        
        File Test.cls.xml 0 Remove
      - Folder IsMaatwerkCalculatieInDotNet 0
        
        File Test.cls.xml 0 Remove
    - Folder impl/IKCanonischeWaarde 0
      - File TestRVGKenmerken.cls.xml 0 Remove
  - Folder ECONimpl/PM/Maatwerk/KenmerkenConverter 0
    - Folder EconNaarApps 0
      - Folder Rvg 0 Remove
        
        File Test.cls.xml 0 Remove
    - Folder EconNaarAppsFactory 0
      - File Test.cls.xml 0 Remove
  - Folder WSimpl/Vhisie4 0
    - Folder OPC/OPCService/OPCKenmerkenConverter 0
      - Folder ConverteerBlumKenmerkenNaarAXKenmerken 0 Remove
        
        File Test.cls.xml 1 Remove
      - File Test.cls.xml 0 Remove
    - Folder Winkelkar/EconConfiguratieConverter 0
      - File Test.cls.xml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Jelle Baele	Author & Moderator	27m	1	Deze klasse hoort niet bij dit kaartje. Ik had dit gecomm...
Peter Vercoutter	Reviewer - Complete	38m	11 (1 defect)	Er bestaan nog extra testen voor convertoren, je moet es ...
Total		1h 5m	12 (1 defect)

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Peter Vercoutter

Er bestaan nog extra testen voor convertoren, je moet es kijken naar mijn com...

Er bestaan nog extra testen voor convertoren, je moet es kijken naar mijn commit 68434, daar staan bijna alle in behalve 'appsnaarecon', das de enige wss

02 Aug 22

Click to load diff

/vhUnitTest/APPS/.../Maatwerk/dto/RVGKenmerken/ Added

Click to load diff

/vhUnitTest/APPS/.../KenmerkenValidator/RVG/ Added

Click to load diff

/vhUnitTest/ECONimpl/.../EconNaarApps/Rvg/ Added

Click to load diff

/vhUnitTest/.../OPCKenmerkenConverter/ConverteerBlumKenmerkenNaarAXKenmerken/ Added

Click to load diff

/vhUnitTest/.../OPCKenmerkenConverter/Test.cls.xml Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-2472

[ICT-3041] [rvPVR] Revego: Eerste opzet BomBol generatie:

CR-2472 12

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Peter Vercoutter

Log time against

[ICT-3041] [rvPVR] Revego: Eerste opzet BomBol generatie:

CR-2472 12

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Peter Vercoutter

Log time against