CR-2480 [ICT-2997] [rvPVR] RVG: Custom OPC specs winkelkarlijn:

closed on 11 Dec 24

Author

Moderator

Reviewers

[ICT-2997] [rvPVR] RVG: Custom OPC specs winkelkarlijn:

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 35

CacheAdminA_trunk2010 (root:) 0
- Folder DOM/PM 0
  - Folder Maatwerk/Calc/Common/impl 0
    - File RVGKenmerken.cls.xml 0 Remove
  - Folder enu 0
    - File RVGTOBKleur.cls.xml 0 Remove
- Folder WS/Vhisie4/OPC 0
  - File GeefVertaaldeWinkelkarLijnRequest.cls.xml 0 Remove
  - File GeefVertaaldeWinkelkarLijnResponse.cls.xml 0 Remove
  - File GeefWinkelkarLijnInfoRequest.cls.xml 0 Remove
  - File GeefWinkelkarLijnInfoResponse.cls.xml 0 Remove
  - File OPCService.cls.xml 0 Remove
- Folder WSimpl/Vhisie4/OPC 0
  - Folder OPCService 0
    - Folder OPCKenmerkenConverter 0
      - Folder dto 0 Remove
        
        File VertaaldeWinkelkarInfo.cls.xml 0 Remove
        
        File WinkelkarKenmerk.cls.xml 0 Remove
        
        File WinkelkarKenmerken.cls.xml 0 Remove
      - File BlumKenmerkNaarWinkelkarLijnInfoConverter.cls.xml 0 Remove
      - File BlumNaarAXKenmerkenConverter.cls.xml 0 Remove
    - File OPCKenmerkenConverter.cls.xml 1 Remove
  - File OPCService.cls.xml 0 Remove
- Folder vhDeploy 0
  - File D20220725xInsertVertalingRevegoWinkelkarlijnInfo.cls.xml 1 Remove
  - File D20220803xVerwijderTijdelijkeVertalingRevegoWinkelkarlijnInfo.cls.xml 0 Remove
- Folder vhTest 0
  - Folder Fake/WSimpl/Vhisie4/OPC/OPCService 0
    - Folder OPCKenmerkenConverter 0
      - File BlumKenmerkNaarWinkelkarLijnInfoConverter.cls.xml 0 Remove
      - File BlumNaarAXKenmerkenConverter.cls.xml 0 Remove
    - File OPCKenmerkenConverter.cls.xml 0 Remove
  - Folder Mock/WSimpl/Vhisie4/OPC/OPCService 0
    - Folder OPCKenmerkenConverter 0
      - File BlumKenmerkNaarWinkelkarLijnInfoConverter.cls.xml 0 Remove
      - File BlumNaarAXKenmerkenConverter.cls.xml 0 Remove
    - File OPCKenmerkenConverter.cls.xml 0 Remove
- Folder vhTestFiles/IntegratieTests/Webservices.WSDLControle/Test 0
  - File WS.Vhisie4.OPC.OPCService.txt 0 Remove
- Folder vhUnitTest/WSimpl/Vhisie4/OPC/OPCService 0
  - Folder OPCKenmerkenConverter 0
    - Folder BlumKenmerkNaarWinkelkarLijnInfoConverter 0 Remove
      - Folder ConverteerBlumKenmerkNaarWinkelkarLijnInfo 0 Remove
        
        File Test.cls.xml 1 Remove
      - Folder GeefGroepering 0 Remove
        
        File Test.cls.xml 0 Remove
    - Folder BlumNaarAXKenmerkenConverter/ConverteerBlumKenmerkNaarAXKenmerk 0
      - File Test.cls.xml 0 Remove
    - Folder ConverteerBlumKenmerkenNaarAXKenmerken 0
      - File Test.cls.xml 0 Remove
    - Folder ConverteerBlumKenmerkenNaarWinkelkarLijnInfo 0 Remove
      - File Test.cls.xml 0 Remove
    - File Test.cls.xml 0 Remove
  - File Test.cls.xml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Jelle Baele	Author & Moderator	10m
Peter Vercoutter	Reviewer - Complete	16m	3	Mss heb jij meer context maar als we een kenmerk niet kun...
Total		26m	3

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/WS/.../OPC/GeefVertaaldeWinkelkarLijnRequest.cls.xml Deleted

Click to load diff

/WS/.../OPC/GeefVertaaldeWinkelkarLijnResponse.cls.xml Deleted

Click to load diff

/WSimpl/Vhisie4/.../OPCKenmerkenConverter/dto/ Deleted

Click to load diff

/WSimpl/.../dto/VertaaldeWinkelkarInfo.cls.xml Deleted

Click to load diff

/WSimpl/.../dto/WinkelkarKenmerk.cls.xml Deleted

Click to load diff

/WSimpl/.../dto/WinkelkarKenmerken.cls.xml Deleted

Click to load diff

/vhUnitTest/.../OPCKenmerkenConverter/BlumKenmerkNaarWinkelkarLijnInfoConverter/ Added

Click to load diff

/vhUnitTest/.../BlumKenmerkNaarWinkelkarLijnInfoConverter/ConverteerBlumKenmerkNaarWinkelkarLijnInfo/ Added

Click to load diff

/vhUnitTest/.../BlumKenmerkNaarWinkelkarLijnInfoConverter/GeefGroepering/ Added

Click to load diff

/vhUnitTest/.../OPCKenmerkenConverter/ConverteerBlumKenmerkenNaarWinkelkarLijnInfo/ Added

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-2480

[ICT-2997] [rvPVR] RVG: Custom OPC specs winkelkarlijn:

CR-2480 3

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

[ICT-2997] [rvPVR] RVG: Custom OPC specs winkelkarlijn:

CR-2480 3

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against