CR-2513 [ICT-3120] [rvWV] PM: TAX: Front HoogteVerstelling MoventoKoppeling: release alle klanten:

closed on 07 Nov 22

Author

Moderator

Reviewers

[ICT-3120] [rvWV] PM: TAX: Front HoogteVerstelling MoventoKoppeling: release...

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 61

CacheAdminA_trunk2010 (root:) 0
- Folder APPS/PM/Maatwerk 0
  - Folder MaatwerkModel/Modellen 0
    - File TaorboxModel.cls.xml 0 Remove
  - Folder impl 0
    - File MaatwerkDefaultsViaConfiguratieToepasser.cls.xml 0 Remove
- Folder DOM/PM 0
  - Folder Maatwerk/Calc/HF/impl 0
    - Folder TAOR/Builder 0
      - Folder HFSetSchroeven 0
        
        File ConditieDiepteVerstellingSchroefBepaler.cls.xml 0 Remove
      - File HFDiepteVerstellingSchroefv001.cls.xml 0 Remove
      - File HFDiepteVerstellingv001.cls.xml 0 Remove
    - File HalffabSpecKenmerkenAanpasser.cls.xml 0 Remove
  - Folder TAORProduct/impl 0
    - File TAORLadeImpl.cls.xml 0 Remove
- Folder ECONimpl/PM/Maatwerk/KenmerkenConverter/EconNaarApps 0
  - File Tax.cls.xml 0 Remove
- Folder EXT 0
  - Folder Optima/CalculPrix/impl 0
    - File RequestVerwerker.cls.xml 0 Remove
  - Folder Unishop/PurchaseOrder001 0
    - File ProductConverter.cls.xml 0 Remove
- Folder vhDeploy 0
  - File D20220930xInsertVertalingTaxMoventoKoppelingVoorLangtekst.cls.xml 0 Remove
- Folder vhTest/Utils 0
  - Folder APPS 0
    - Folder EDI/common/dto 0
      - File LadeTAX.cls.xml 0 Remove
    - Folder PM/Maatwerk/dto 0
      - File TAORKenmerken.cls.xml 0 Remove
  - Folder AXimpl/PM/Maatwerk 0
    - File TaxKenmerken.cls.xml 0 Remove
  - Folder ECON/PM/Maatwerk/dto 0
    - File TaxKenmerken.cls.xml 0 Remove
  - Folder EXT/Unishop/PurchaseOrder001/CreateOrder 0
    - File LadeEigenschappenTAX.cls.xml 0 Remove
- Folder vhTestFiles/IntegratieTests 0
  - Folder ProductBeheer.Maatwerk.Configurator.Taorbox.VerwerkKenmerkWijzigingen 0
    - Folder Test002 0
      - Folder Intern/VanHoecke/VanHoeckeKlantMetProbox/VanHoeckeGebruiker 0
        
        File File_003.xml 0 Remove
      - Folder Webshop/VanHoecke/VanHoeckeKlantMetProbox/VanHoeckeGebruiker 0
        
        File File_003.xml 0 Remove
    - Folder Test002MetGekoppeldeMat 0
      - Folder Intern/VanHoecke/VanHoeckeKlantMetProbox/VanHoeckeGebruiker 0
        
        File File_003.xml 0 Remove
      - Folder Webshop/VanHoecke/VanHoeckeKlantMetProbox/VanHoeckeGebruiker 0
        
        File File_003.xml 0 Remove
  - Folder ProductBeheer.Maatwerk.Langteksten.TAX 0
    - Folder TestLosseComponentenInBulk/Bodem 0
      - File TestLosseComponentenInBulk_Langteksten.txt 0 Remove
    - Folder TestLosseComponentenInBulkAfwijkendeKantenband/Bodem 0
      - File TestLosseComponentenInBulkAfwijkendeKantenband_Langteksten.txt 0 Remove
    - Folder TestVerpakkingType/Lossecomponenten 0
      - File TestVerpakkingType_Langteksten.txt 0 Remove
  - Folder Productie.Planning.ActieveBatches.Taorbox.Aansturing 0
    - Folder AcceptatieTest/StartBatch 0
      - Folder Ardis/ImportAuto 0
        
        File Productie_009_ImportFile_15000_20141114_091500.txt 0 Remove
      - File External_SQL.DB_KantenbandData.xml 0 Remove
      - File External_SQL.DB_ZijkantKamerFreesData.xml 0 Remove
      - File Productie_003_TAX_OnderdelenPickingLijst.txt 0 Remove
      - File Productie_005_PRODUCTIEDETAILBLAD.xml 0 Remove
      - File Productie_006_PRODUCTIEDETAILBLAD.xml 0 Remove
      - File Productie_007_TAGBASEDDOC.xml 0 Remove
    - Folder TestLosseComponent/StartBatch 0
      - Folder Ardis/ImportAuto 0
        
        File Productie_011_ImportFile_15000_20141114_091500.txt 1 Remove
      - File External_SQL.DB_BodemSlicingData.xml 0 Remove
      - File Productie_007_PRODUCTIEDETAILBLAD.xml 0 Remove
      - File Productie_009_TAGBASEDDOC.xml 0 Remove
      - File Productie_010_Halux_Productie_Keller_Klant_TAX_LosseComponenten_5x10.TXT 0 Remove
    - Folder TestLosseComponentKleurW7/StartBatch 0
      - Folder Ardis/ImportManueel 0
        
        File Productie_011_ImportFile_15000_20141114_091500.txt 0 Remove
      - File External_SQL.DB_BodemSlicingData.xml 0 Remove
      - File Productie_007_PRODUCTIEDETAILBLAD.xml 0 Remove
      - File Productie_009_TAGBASEDDOC.xml 0 Remove
      - File Productie_010_Halux_Productie_Keller_Klant_TAX_LosseComponenten_5x10.TXT 0 Remove
    - Folder TestV1ZijkantLinks/StartBatch 0
      - Folder Ardis/ImportAuto 0
        
        File Productie_005_ImportFile_15000_20141114_091500.txt 0 Remove
      - File External_SQL.DB_KantenbandData.xml 0 Remove
      - File External_SQL.DB_ZijkantKamerFreesData.xml 0 Remove
      - File Productie_003_TAGBASEDDOC.xml 0 Remove
    - Folder TestV1ZijkantLinks1Stuk/StartBatch 0
      - Folder Ardis/ImportAuto 0
        
        File Productie_005_ImportFile_15000_20141114_091500.txt 0 Remove
      - File External_SQL.DB_KantenbandData.xml 0 Remove
      - File External_SQL.DB_ZijkantKamerFreesData.xml 0 Remove
      - File Productie_003_TAGBASEDDOC.xml 0 Remove
  - Folder WSimpl.AX.CalculatedProduct/TestTax 0
    - File 1648504.xml 0 Remove
- Folder vhUnitTest 0
  - Folder APPS 0
    - Folder Halux 0
      - Folder PPS/Activiteit/impl/TAOR/LijstVerwerkers/AssemblageKarOverzicht/DocumentInhoudBuilder/RijDataBepalerMetKar 0
        
        File Test.cls.xml 0 Remove
      - Folder common/impl/ProductieSequentie/Taor/SorteerSleutelBepaler/Bepaal 0
        
        File Test.cls.xml 0 Remove
    - Folder PM/Maatwerk/End2End/TAOR 0
      - File TestBasisTAORRollen.cls.xml 0 Remove
      - File TestTAORGewoneLadeMetMatHF.cls.xml 0 Remove
  - Folder DOM/PM 0
    - Folder Maatwerk 0
      - Folder Calc/HF/impl/TAOR/Builder 0
        
        Folder HFSetSchroeven/ConditieDiepteVerstellingSchroefBepaler 0
        
        File Test.cls.xml 0 Remove
        
        Folder ProductieRoute 0
        
        Folder DiepteVerstelling 0
        
        File Test.cls.xml 0 Remove
        
        Folder Koppeling 0
        
        File Test.cls.xml 0 Remove
      - Folder TAX/impl/KorttekstBepaler/BepaalKorttekst 0
        
        File TestLosseComponenten.cls.xml 0 Remove
    - Folder impl 0
      - Folder IKCanonischeWaarde 0
        
        File TestTAORKenmerken.cls.xml 0 Remove
      - Folder TAORLangtekstCreator/GeefLangtekst/LosseComponent 0
        
        File Test.cls.xml 0 Remove
  - Folder EXT/Unishop/PurchaseOrder001/ProductConverter/ExtNaarEdi/Tax 0
    - File Test.cls.xml 0 Remove
  - Folder End2End/TAOR/GebruikteHalffabItemsVoorPrijsberekening 0
    - File Test.cls.xml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Tommy Hebb	Author & Moderator	5m	1	De meeste testfiles heb ik maar buiten de review gehouden...
Wim Vermeulen	Reviewer - Complete	54m	2	TestFiles reviewen, is in dit soort stories bijna onbegon...
Total		59m	3

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Tommy Hebb

De meeste testfiles heb ik maar buiten de review gehouden. Een aantal zijn to...

De meeste testfiles heb ik maar buiten de review gehouden. Een aantal zijn toch toegevoegd, bij wijze van check van het resultaat is dat, denk ik, wel ok en het is bovendien soms ook moeilijk om uit te maken a.d.h.v. de changesets of het al dan niet over code gaat of testfiles.
P.s.: Ook kleine change in Econ (zie svn).

21 Oct 22

Wim Vermeulen

TestFiles reviewen, is in dit soort stories bijna onbegonnen werk. Ik heb zo ...

TestFiles reviewen, is in dit soort stories bijna onbegonnen werk. Ik heb zo goed en zo kwaad mogelijk de changes bekeken.
Alvast bedankt om het aantal testfiles te filteren.
Het geheel lijkt me wel oké te zijn.

Ook in eCon enkele commits gereviewed.

02 Nov 22

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-2513

[ICT-3120] [rvWV] PM: TAX: Front HoogteVerstelling MoventoKoppeling: release...

CR-2513 3

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Tommy Hebb

Wim Vermeulen

Log time against

[ICT-3120] [rvWV] PM: TAX: Front HoogteVerstelling MoventoKoppeling: release...

CR-2513 3

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Tommy Hebb

Wim Vermeulen

Log time against