CR-2726 [ICT-4439] [rvPVR] Ophalen BOMBOL uit Encoway:

closed on 02 Apr 24

Author

Moderator

Reviewers

[ICT-4439] [rvPVR] Ophalen BOMBOL uit Encoway:

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 58

CacheAdminA_trunk2010 (root:) 0
- Folder APPS 0
  - Folder Halux/common/impl 0
    - Folder Encoway 0 Remove
      - File ProductieAansturingService.cls.xml 0 Remove
    - File ProductieAansturingService.cls.xml 0 Remove
    - File ProductieSequentieItemService.cls.xml 0 Remove
  - Folder PM/Maatwerk 0
    - Folder dto 0
      - Folder VhConfig 0 Remove
        
        File BerekendeKenmerken.cls.xml 0 Remove
        
        File Halffabrikaat.cls.xml 0 Remove
        
        File Kost.cls.xml 0 Remove
        
        File KostItem.cls.xml 0 Remove
        
        File MaatwerkDetails.cls.xml 0 Remove
      - File VhConfig.cls.xml 0 Remove
    - Folder impl 0
      - Folder VhConfig 0 Remove
        
        Folder Converter 0 Remove
        
        File HalffabItemsBoom.cls.xml 0 Remove
        
        File LbxKenmerken.cls.xml 0 Remove
      - File BerekeningServiceIngegevenKenmerken.cls.xml 0 Remove
      - File BerekeningServiceProduct.cls.xml 0 Remove
      - File VhConfigHelper.cls.xml 0 Remove
- Folder AXimpl/Dynamics/SalesOrderIn/Converter 0
  - File SalesOrderConverter.cls.xml 0 Remove
- Folder DOM/PM 0
  - Folder Maatwerk/Calc/Common 0
    - Folder VhConfig 0 Remove
      - Folder Converter 0 Remove
        
        File HalffabItemsBoom.cls.xml 0 Remove
        
        File LbxKenmerken.cls.xml 0 Remove
      - File BerekendeKenmerken.cls.xml 0 Remove
      - File Halffabrikaat.cls.xml 0 Remove
      - File Kost.cls.xml 0 Remove
      - File KostItem.cls.xml 0 Remove
      - File MaatwerkDetails.cls.xml 0 Remove
    - File VhConfig.cls.xml 0 Remove
    - File VhConfigHelper.cls.xml 0 Remove
  - Folder impl 0
    - Folder DataM 0
      - File DataMProductCreator.cls.xml 0 Remove
    - File ProductAPI.cls.xml 0 Remove
  - File ProductAPI.cls.xml 0 Remove
- Folder WSimpl/PM/Maatwerk/MaatwerkService 0
  - Folder Encoway 0 Remove
    - Folder Dto 0 Remove
      - File SalesContext.cls.xml 0 Remove
    - File EncowayJsonConverter.cls.xml 0 Remove
    - File GeefMaatwerkDetailsRequest.cls.xml 0 Remove
  - File Encoway.cls.xml 0 Remove
  - File EncowayHttpClient.cls.xml 0 Remove
- Folder vhDeploy 0
  - File Deploy20240322xConfigItemsEncowayHttp.cls.xml 0 Remove
- Folder vhTest 0
  - Folder Fake/WSimpl/PM/Maatwerk/MaatwerkService 0
    - Folder Encoway 0 Remove
      - File EncowayJsonConverter.cls.xml 0 Remove
    - File EncowayHttpClient.cls.xml 0 Remove
  - Folder Mock 0
    - Folder APPS/PM/Maatwerk/impl 0
      - File BerekeningServiceIngegevenKenmerken.cls.xml 0 Remove
      - File BerekeningServiceProduct.cls.xml 0 Remove
    - Folder DOM/PM 0
      - File ProductAPI.cls.xml 0 Remove
    - Folder WSimpl/PM/Maatwerk/MaatwerkService 0
      - Folder Encoway 0 Remove
        
        File EncowayJsonConverter.cls.xml 0 Remove
      - File EncowayHttpClient.cls.xml 0 Remove
- Folder vhUnitTest/WSimpl/PM/Maatwerk/MaatwerkService 0
  - Folder Encoway 0 Remove
    - Folder EncowayJsonConverter 0 Remove
      - Folder Parse 0 Remove
        
        File Test.cls.xml 0 Remove
      - Folder Stringify 0 Remove
        
        File Test.cls.xml 0 Remove
    - Folder GeefMaatwerkDetails 0 Remove
      - File Test.cls.xml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments
Jelle Baele	Author & Moderator	1m
Peter Vercoutter	Reviewer - Complete	7m
Total		8m	0

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/APPS/PM/Maatwerk/impl/VhConfig/Converter/ Added

Click to load diff

/DOM/PM/Maatwerk/.../Common/VhConfig/Converter/ Deleted

Click to load diff

/DOM/PM/.../Converter/HalffabItemsBoom.cls.xml Deleted

Click to load diff

/DOM/PM/.../Converter/LbxKenmerken.cls.xml Deleted

Click to load diff

/DOM/.../VhConfig/BerekendeKenmerken.cls.xml Deleted

Click to load diff

/DOM/PM/.../VhConfig/Halffabrikaat.cls.xml Deleted

Click to load diff

/DOM/PM/.../Common/VhConfig/Kost.cls.xml Deleted

Click to load diff

/DOM/PM/.../Common/VhConfig/KostItem.cls.xml Deleted

Click to load diff

/DOM/PM/.../VhConfig/MaatwerkDetails.cls.xml Deleted

Click to load diff

/DOM/PM/.../Calc/Common/VhConfig.cls.xml Deleted

Click to load diff

/DOM/PM/.../Calc/Common/VhConfigHelper.cls.xml Deleted

Click to load diff

/WSimpl/PM/.../MaatwerkService/Encoway/Dto/ Added

Click to load diff

/vhUnitTest/WSimpl/.../MaatwerkService/Encoway/ Added

Click to load diff

/vhUnitTest/.../Encoway/EncowayJsonConverter/ Added

Click to load diff

/vhUnitTest/.../EncowayJsonConverter/Stringify/ Added

Click to load diff

/vhUnitTest/.../Encoway/GeefMaatwerkDetails/ Added

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-2726

[ICT-4439] [rvPVR] Ophalen BOMBOL uit Encoway:

CR-2726 0

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

[ICT-4439] [rvPVR] Ophalen BOMBOL uit Encoway:

CR-2726 0

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against