CR-2819 [PRJ051-26] [rvJBA] Papier voor aansturing BWC freesmachine (Homag) vervangen door barcode

closed on 22 Oct 24

Author

Moderator

Reviewers

[PRJ051-26] [rvJBA] Papier voor aansturing BWC freesmachine (Homag) vervangen...

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 137

CacheAdminA_trunk2010 (root:) 0
- Folder APPS/Halux/PPS 0
  - Folder Activiteit/impl 0
    - Folder LBX 0
      - File DataVoorFreesMachine.cls.xml 0 Remove
    - Folder MVX 0
      - File DataVoorFreesMachine.cls.xml 2 Remove
  - Folder Document/impl 0
    - Folder LBX 0
      - File DataVoorFreesMachine.cls.xml 1 Remove
    - Folder MVX 0
      - File DataVoorFreesMachine.cls.xml 0 Remove
    - Folder common 0
      - File DataVoorFreesMachine.cls.xml 0 Remove
- Folder DOM/PM/Maatwerk/Calc/Common/impl 0
  - File OmleidingNaarEncowayBepaler.cls.xml 0 Remove
- Folder vhDeploy 0
  - Folder Maatwerk 0
    - Folder LBX 0
      - File AansturingIncrementeel.cls.xml 0 Remove
    - Folder MVX 0
      - File AansturingIncrementeel.cls.xml 0 Remove
  - File Deploy20241008xToevoegenMVXAansturingActieFreesBestanden.cls.xml 0 Remove
  - File Deploy20241014xToevoegenLBXAansturingActieFreesBestanden.cls.xml 0 Remove
- Folder vhTest/Integratie/Productie/Planning/ActieveBatches 0
  - Folder Legrabox/Aansturing 0
    - File TestBase.cls.xml 0 Remove
  - Folder Merivobox/Aansturing 0
    - File TestBase.cls.xml 0 Remove
- Folder vhTestFiles/IntegratieTests 0
  - Folder Productie.Planning.ActieveBatches 0
    - Folder TestAansturingActiesVolgorde 0
      - File Volgorde_AansturingActies.txt 0 Remove
    - Folder TestActiviteitVolgorde 0
      - File Volgorde.txt 0 Remove
  - Folder Productie.Planning.ActieveBatches.Legrabox.Aansturing 0
    - Folder Test002Lijn3/StartBatch 0
      - Folder FreesList 0 Remove
        
        Folder lis 0 Remove
        
        File B15000.lis 0 Remove
      - Folder FreesMain 0 Remove
        
        Folder BAT 0 Remove
        
        File B15000.BAT 0 Remove
        
        Folder Error 0 Remove
        
        Folder 15000 0 Remove
        
        Folder MRG 0 Remove
        
        Folder 15000 0 Remove
        
        File 0003-LI7K-Recht-LBX.MRG 0 Remove
        
        Folder Result 0 Remove
        
        Folder 15000 0 Remove
    - Folder Test019LijnA/StartBatch 0
      - Folder FreesList 0 Remove
        
        Folder lis 0 Remove
        
        File B15000.lis 0 Remove
      - Folder FreesMain 0 Remove
        
        Folder BAT 0 Remove
        
        File B15000.BAT 0 Remove
        
        Folder Error 0 Remove
        
        Folder 15000 0 Remove
        
        Folder MRG 0 Remove
        
        Folder 15000 0 Remove
        
        File 0003-LI7K-Recht-LBX.MRG 0 Remove
        
        Folder Result 0 Remove
        
        Folder 15000 0 Remove
    - Folder Test020LijnB/StartBatch 0
      - Folder FreesList 0 Remove
        
        Folder lis 0 Remove
        
        File B15000.lis 0 Remove
      - Folder FreesMain 0 Remove
        
        Folder BAT 0 Remove
        
        File B15000.BAT 0 Remove
        
        Folder Error 0 Remove
        
        Folder 15000 0 Remove
        
        Folder MRG 0 Remove
        
        Folder 15000 0 Remove
        
        File 0003-LI7K-Recht-LBX.MRG 0 Remove
        
        Folder Result 0 Remove
        
        Folder 15000 0 Remove
    - Folder Test022DubbeleSifonladeMetMat/StartBatch 0
      - Folder FreesList 0 Remove
        
        Folder lis 0 Remove
        
        File B15000.lis 0 Remove
      - Folder FreesMain 0 Remove
        
        Folder BAT 0 Remove
        
        File B15000.BAT 0 Remove
        
        Folder Error 0 Remove
        
        Folder 15000 0 Remove
        
        Folder MRG 0 Remove
        
        Folder 15000 0 Remove
        
        File 0001-LI7K-Recht-LBX.MRG 0 Remove
        
        Folder Result 0 Remove
        
        Folder 15000 0 Remove
    - Folder TestLBXFree/StartBatch 0
      - Folder FreesList 0 Remove
        
        Folder lis 0 Remove
        
        File B15000.lis 0 Remove
      - Folder FreesMain 0 Remove
        
        Folder BAT 0 Remove
        
        File B15000.BAT 0 Remove
        
        Folder Error 0 Remove
        
        Folder 15000 0 Remove
        
        Folder MRG 0 Remove
        
        Folder 15000 0 Remove
        
        File 0003-LI7M-Recht-LBX.MRG 0 Remove
        
        Folder Result 0 Remove
        
        Folder 15000 0 Remove
    - Folder TestSifon/StartBatch 0
      - Folder FreesList 0 Remove
        
        Folder lis 0 Remove
        
        File B15000.lis 0 Remove
      - Folder FreesMain 0 Remove
        
        Folder BAT 0 Remove
        
        File B15000.BAT 0 Remove
        
        Folder Error 0 Remove
        
        Folder 15000 0 Remove
        
        Folder MRG 0 Remove
        
        Folder 15000 0 Remove
        
        File 0001-LI7M-Recht-LBX.MRG 0 Remove
        
        File 0002-LI7K-Recht-LBX.MRG 0 Remove
        
        File 0003-LI7L-Recht-LBX.MRG 0 Remove
        
        File 0004-LI7N-Recht-LBX.MRG 0 Remove
        
        Folder Result 0 Remove
        
        Folder 15000 0 Remove
  - Folder Productie.Planning.ActieveBatches.Merivobox.Aansturing 0
    - Folder TestSifonladeDubbeleUitsparingMetMat/StartBatch 0
      - Folder FreesList 0 Remove
        
        Folder lis 0 Remove
        
        File B15000.lis 0 Remove
      - Folder FreesMain 0 Remove
        
        Folder BAT 0 Remove
        
        File B15000.BAT 0 Remove
        
        Folder Error 0 Remove
        
        Folder 15000 0 Remove
        
        Folder MRG 0 Remove
        
        Folder 15000 0 Remove
        
        File 0001-LI7K-Recht-MVX.MRG 0 Remove
        
        File 0002-LI7K-Recht-MVX.MRG 0 Remove
        
        Folder Result 0 Remove
        
        Folder 15000 0 Remove
    - Folder TestSifonladeEnkeleUitsparing/StartBatch 0
      - Folder FreesList 0 Remove
        
        Folder lis 0 Remove
        
        File B15000.lis 0 Remove
      - Folder FreesMain 0 Remove
        
        Folder BAT 0 Remove
        
        File B15000.BAT 0 Remove
        
        Folder Error 0 Remove
        
        Folder 15000 0 Remove
        
        Folder MRG 0 Remove
        
        Folder 15000 0 Remove
        
        File 0001-LI7K-Recht-MVX.MRG 0 Remove
        
        File 0002-LI7K-Recht-MVX.MRG 0 Remove
        
        File 0003-LI7K-Recht-MVX.MRG 0 Remove
        
        Folder Result 0 Remove
        
        Folder 15000 0 Remove
    - Folder TestSpoelbaklade/StartBatch 0
      - Folder FreesList 0 Remove
        
        Folder lis 0 Remove
        
        File B15000.lis 0 Remove
      - Folder FreesMain 0 Remove
        
        Folder BAT 0 Remove
        
        File B15000.BAT 0 Remove
        
        Folder Error 0 Remove
        
        Folder 15000 0 Remove
        
        Folder MRG 0 Remove
        
        Folder 15000 0 Remove
        
        File 0001-LI7K-Recht-MVX.MRG 0 Remove
        
        Folder Result 0 Remove
        
        Folder 15000 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Peter Vercoutter	Author & Moderator	7m
Jelle Baele	Reviewer - Complete	9m	3	Vrij veel code in 1 method, ik zou die wat meer opsplitse...
Total		16m	3

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesList/lis/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/BAT/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Error/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/MRG/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../MRG/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Result/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesList/lis/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/BAT/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Error/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/MRG/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../MRG/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Result/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesList/lis/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/BAT/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Error/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/MRG/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../MRG/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Result/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesList/lis/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/BAT/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Error/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/MRG/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../MRG/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Result/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesList/lis/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/BAT/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Error/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/MRG/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../MRG/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Result/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesList/lis/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/BAT/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Error/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/MRG/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../MRG/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Result/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesList/lis/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/BAT/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Error/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/MRG/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../MRG/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Result/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesList/lis/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/BAT/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Error/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/MRG/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../MRG/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Result/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesList/lis/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/BAT/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Error/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../FreesMain/MRG/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../MRG/15000/ Added

Click to load diff

/vhTestFiles/IntegratieTests/.../Result/15000/ Added

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-2819

[PRJ051-26] [rvJBA] Papier voor aansturing BWC freesmachine (Homag) vervangen...

CR-2819 3

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

[PRJ051-26] [rvJBA] Papier voor aansturing BWC freesmachine (Homag) vervangen...

CR-2819 3

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against