CR-3 [UST1939] Vh4_SVC: MaakWinkelkar

closed on 17 Jan 17

Author

Moderator

Reviewers

[UST1939] Vh4_SVC: MaakWinkelkar

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 52

CacheAdminA_trunk2010 (root:) 0
- Folder APPS 0
  - Folder EC 0
    - Folder Verkoop 0
      - Folder impl/Externe 0
        
        File VerkoopService.cls.xml 2 Remove
      - File ExterneVerkoopService.cls.xml 0 Remove
    - Folder Winkelkar 0
      - Folder impl 0
        
        File ExterneWinkelkarService.cls.xml 0 Remove
        
        File WinkelkarService.cls.xml 0 Remove
      - File WinkelkarService.cls.xml 0 Remove
  - Folder VKP 0
    - Folder Offerte 0
      - Folder impl 0
        
        File OfferteRepository.cls.xml 0 Remove
      - File OfferteRepository.cls.xml 0 Remove
    - Folder event 0
      - File OfferteEventRaiser.cls.xml 0 Remove
      - File OfferteGemaaktEventRaiser.cls.xml 0 Remove
    - Folder impl 0
      - File OfferteService.cls.xml 2 Remove
    - File OfferteService.cls.xml 0 Remove
- Folder DOM 0
  - Folder EC/Winkelkar 0
    - Folder impl 0
      - File WinkelkarRepository.cls.xml 0 Remove
    - File Winkelkar.cls.xml 0 Remove
    - File WinkelkarRepository.cls.xml 0 Remove
  - Folder PARTIJ 0
    - Folder impl 0
      - File LegacyPartijAPI.cls.xml 0 Remove
    - File LegacyPartijAPI.cls.xml 0 Remove
- Folder WSimpl/Vhisie4/Winkelkar 0
  - Folder WinkelkarService 0 Remove
    - File MaakWinkelkar.cls.xml 0 Remove
- Folder vhTest 0
  - Folder Fake/APPS 0
    - Folder EC/Winkelkar/impl 0
      - File WinkelkarService.cls.xml 0 Remove
    - Folder VKP 0
      - File Offerte.cls.xml 0 Remove
  - Folder Mock 0
    - Folder APPS 0
      - Folder EC 0
        
        Folder Verkoop 0
        
        Folder impl 0 Remove
        
        File ExterneVerkoopService.cls.xml 0 Remove
        
        Folder Winkelkar 0
        
        Folder impl 0
        
        File WinkelkarService.cls.xml 0 Remove
        
        File WinkelkarService.cls.xml 0 Remove
      - Folder VKP 0
        
        Folder Offerte 0
        
        File OfferteRepository.cls.xml 0 Remove
        
        File OfferteService.cls.xml 0 Remove
    - Folder DOM 0
      - Folder EC/Winkelkar 0
        
        File WinkelkarRepository.cls.xml 0 Remove
      - Folder PARTIJ 0
        
        File LegacyPartijAPI.cls.xml 0 Remove
  - Folder Utils/WS 0
    - Folder Vhisie4 0 Remove
      - Folder Winkelkar 0 Remove
        
        File MaakWinkelkarRequest.cls.xml 2 Remove
- Folder vhUnitTest 0
  - Folder APPS 0
    - Folder EC 0
      - Folder Verkoop/impl/Externe/VerkoopService 0
        
        Folder MaakOfferte 0
        
        File Test.cls.xml 2 Remove
        
        Folder MaakWinkelkar 0 Remove
        
        File Test.cls.xml 0 Remove
      - Folder Winkelkar/impl/WinkelkarService 0
        
        Folder ControleerWinkelkarViaExterneId 0 Remove
        
        File Test.cls.xml 0 Remove
    - Folder EDI/Bestel/impl/BestelService/UnishopBesteller/PlaatsBestelling 0
      - File Test.cls.xml 0 Remove
    - Folder VKP 0
      - Folder Offerte/impl 0
        
        Folder OfferteRepository 0 Remove
        
        File Test.cls.xml 0 Remove
      - Folder impl/OfferteService 0
        
        Folder ControleerOfferteViaExterneId 0 Remove
        
        File Test.cls.xml 2 Remove
        
        Folder ControleerOfferteViaterneId 0 Remove
        
        File Test.cls.xml 0 Remove
  - Folder DOM 0
    - Folder EC/Winkelkar 0
      - Folder impl 0 Remove
        
        Folder WinkelkarRepository 0 Remove
        
        File Test.cls.xml 0 Remove
    - Folder PARTIJ/impl 0
      - File TestLegacyPartijAPI.cls.xml 0 Remove
  - Folder WSimpl 0
    - Folder Vhisie4 0 Remove
      - Folder Winkelkar 0 Remove
        
        Folder WinkelkarService 0 Remove
        
        Folder MaakWinkelkar 0 Remove
        
        File Test.cls.xml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Kurt Callebaut	Author & Moderator	1h	6	Bedenking : GemaaktofferteEvent zou zo dicht mogelijk bij...
Jo Claes	Reviewer - 0% reviewed	35m	6	RaiseEventOfferte is een implementatie detail en hoort ni...
Total		1h 34m	12

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Jo Claes

Het feit dat er op de DOM.EC.. winkelkar en APPS.VKP.Offerte een ExterneId st...

Het feit dat er op de DOM.EC.. winkelkar en APPS.VKP.Offerte een ExterneId staat is een intern gegeven dus de controle op winkelkar en offerte horen samen te zitten.
Het zou in principe niet kunnen dat de ExterneId reeds op de winkelkar staat en niet op de offerte dus is eigenlijk een controle op de offerte voldoende.
Dus de foutmelding die we naar de buitenwereld sturen is eerder één van alla "ID reeds gebruik" want intracto heeft geen weet van onze offertes en Winkelkarren.

05 Jan 17

Kurt Callebaut

Melding is veraglemeend naar "ExterneId x bestaat reeds". Daar er op data niv...

Melding is veraglemeend naar "ExterneId x bestaat reeds".
Daar er op data niveau geen relatie is tussen offerte en winkelkar, moet er een controle voor beide offerte en winkelkar gebeuren. Repository geeft enkel bestaat viaexterneId en het is niet de bedoeling de repository een foutmelding te laten genereren. De meldingen zitten dus op niveau van de services. 1 controle enkel op ofwel offerte of winkelkar lijkt met gevaarlijk omdat het op data niveau niet opgevangen wordt. We willen ook geen dependency creeëren tussen offerte service en winkelkar service. Vandaar elk hun controle; dus de plaats waar de controles samenkomen is dan op verkoopservice niveau. Later misschien te refactoren.

07 Jan 17

Click to load diff

/APPS/.../event/OfferteGemaaktEventRaiser.cls.xml Deleted

Click to load diff

/WSimpl/Vhisie4/Winkelkar/WinkelkarService/ Added

Click to load diff

/vhUnitTest/.../VerkoopService/MaakWinkelkar/ Deleted

Click to load diff

/vhUnitTest/.../WinkelkarService/ControleerWinkelkarViaExterneId/ Added

Click to load diff

/vhUnitTest/APPS/.../impl/OfferteRepository/ Added

Click to load diff

/vhUnitTest/.../OfferteService/ControleerOfferteViaExterneId/ Added

Click to load diff

/vhUnitTest/.../OfferteService/ControleerOfferteViaterneId/ Deleted

Click to load diff

/vhUnitTest/DOM/.../impl/WinkelkarRepository/ Added

Click to load diff

/vhUnitTest/.../Winkelkar/WinkelkarService/ Added

Click to load diff

/vhUnitTest/.../WinkelkarService/MaakWinkelkar/ Added

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-3

[UST1939] Vh4_SVC: MaakWinkelkar

CR-3 12

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jo Claes

Kurt Callebaut

Log time against

[UST1939] Vh4_SVC: MaakWinkelkar

CR-3 12

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jo Claes

Kurt Callebaut

Log time against