CR-39 [UST2151]Vh4 TBX: opvullijsten toevoegen aan LadeMetVeelExtras

closed on 19 Jan 17

Author

Moderator

Reviewers

[UST2151]Vh4 TBX: opvullijsten toevoegen aan LadeMetVeelExtras

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 5

CacheAdminA_trunk2010 (root:) 0
- Folder vhTest/Utils 0
  - Folder APPS/EDI/common/dto 0
    - File LadeTBX.cls.xml 0 Remove
  - Folder DOM/PM/Maatwerk/Calc/Common/impl 0
    - File TBXKenmerkenLegacy.cls.xml 0 Remove
  - Folder ECON/PM/Maatwerk/dto 0
    - File TbxKenmerken.cls.xml 0 Remove
  - Folder EXT/Unishop/PurchaseOrder001/CreateOrder 0
    - File LadeEigenschappenTBX.cls.xml 0 Remove
- Folder vhUnitTest/DOM/PM/impl/VerkoopPrijsBepaler/BepaalVerkoopPrijs 0
  - File Test.cls.xml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Tom Vermeulen	Author & Moderator	4m	1	Als op alle laagskes dezelfde schuif op dezelfde manier w...
Jo Claes	Reviewer - Complete	3m	1	Vind het wel raar dat er geen enkele conversie test ( kla...
Total		7m	2

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Jo Claes

Vind het wel raar dat er geen enkele conversie test ( klasse ) is aangepast t...

Vind het wel raar dat er geen enkele conversie test ( klasse ) is aangepast terwijl er toch overal nieuwe kenmerken gedefinieerd worden

18 Jan 17

Tom Vermeulen

Resolved

19 Jan 17

Tom Vermeulen

Als op alle laagskes dezelfde schuif op dezelfde manier wordt aangepast (opvu...

Als op alle laagskes dezelfde schuif op dezelfde manier wordt aangepast (opvullijsten dus), en de conversies waren al snugger genoeg om er mee om te gaan, zullen de conversies(/tests) niet aangeepast moeten worden.

19 Jan 17

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-39

[UST2151]Vh4 TBX: opvullijsten toevoegen aan LadeMetVeelExtras

CR-39 2

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jo Claes

Tom Vermeulen

Log time against

[UST2151]Vh4 TBX: opvullijsten toevoegen aan LadeMetVeelExtras

CR-39 2

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jo Claes

Tom Vermeulen

Log time against