CR-450 [UST2729] VHIP903: Period. voorraad: SoprContract opnemen voor elke SOPR-variant:

closed on 24 Aug 17

Author

Moderator

Reviewers

[UST2729] VHIP903: Period. voorraad: SoprContract opnemen voor elke...

Activity

Details
Objectives
General Comments 1
Unresolved
Resolved
Number of files included: 25

CacheAdminA_trunk2010 (root:) 0
- Folder AX/Uitgaand/PM/impl/Convertor/Sopr 0
  - File ProductConvertor.cls.xml 0 Remove
- Folder AXdata/AifMessage 0
  - File Message.cls.xml 0 Remove
- Folder AXif/Dynamics/InventoryOut 0
  - Folder MessageParts 0
    - File AxdADUMsgOutboundInQuery.cls.xml 0 Remove
    - File AxdEntityHeader.cls.xml 0 Remove
  - File Body.cls.xml 0 Remove
  - File MessageParts.cls.xml 0 Remove
- Folder AXimpl 0
  - Folder Admin/DOM/PM 0
    - File ProductIterator.cls.xml 0 Remove
  - Folder Dynamics 0
    - Folder InventSync 0 Remove
      - File AxInventSyncCreator.cls.xml 0 Remove
    - Folder InventoryOut/Converter 0
      - File AxInventSyncCreator.cls.xml 1 Remove
      - File InventoryOutConverter.cls.xml 2 Remove
- Folder Prod 0
  - File Product.cls.xml 0 Remove
  - File ProductGateway.cls.xml 0 Remove
  - File ProductRepository.cls.xml 0 Remove
- Folder vhDeploy 0
  - File D20170803xConfigSettingsAXEventhandlersInventoryOut.cls.xml 0 Remove
  - File D20170821xConfigSettingsAXEventhandlersInventoryOut.cls.xml 0 Remove
- Folder vhTest 0
  - Folder Fake 0
    - Folder AX/Uitgaand/PM/impl/Convertor/Sopr 0
      - File ProductConvertor.cls.xml 0 Remove
    - Folder AXimpl/Dynamics/InventoryOut/Converter 0
      - File InventoryOutConverter.cls.xml 0 Remove
    - Folder Prod 0
      - File ProductRepository.cls.xml 0 Remove
  - Folder Mock 0
    - Folder AX/Uitgaand/PM/impl/Convertor/Sopr 0
      - File ProductConvertor.cls.xml 0 Remove
    - Folder AXimpl/Dynamics/InventoryOut/Converter 0
      - File AxInventSyncCreator.cls.xml 0 Remove
      - File InventoryOutConverter.cls.xml 0 Remove
    - Folder Prod 0
      - File ProductRepository.cls.xml 0 Remove
- Folder vhUnitTest/AXimpl/Dynamics/InventoryOut/Converter 0
  - Folder AxInventSyncCreator 0
    - File Test.cls.xml 0 Remove
  - Folder InventoryOutConverter/Convert 0
    - File Test.cls.xml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Tommy Hebb	Author & Moderator	3m
Tom Vermeulen	Reviewer - Complete	23m	4 (3 defects)	Je gebruikt principieel en principaal door elkaar, best v...
Total		26m	4 (3 defects)

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Tom Vermeulen

Je gebruikt principieel en principaal door elkaar, best vervangen door princi...

Je gebruikt principieel en principaal door elkaar, best vervangen door principaal (doe een CTRL-F, het zijn vijf files)

Defect Ranking: Minor Classification: Improvement desirable

23 Aug 17

Tommy Hebb

Resolved

24 Aug 17

Click to load diff

/AXimpl/.../InventSync/AxInventSyncCreator.cls.xml Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-450

[UST2729] VHIP903: Period. voorraad: SoprContract opnemen voor elke...

CR-450 4

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Tom Vermeulen

Log time against

[UST2729] VHIP903: Period. voorraad: SoprContract opnemen voor elke...

CR-450 4

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Tom Vermeulen

Log time against