CR-46 [UST2064] Vh4_SVC: BewaarMaatwerkLijn

closed on 28 Feb 17

Author

Moderator

Reviewers

[UST2064] Vh4_SVC: BewaarMaatwerkLijn

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 29

CacheAdminA_trunk2010 (root:) 0
- Folder APPS 0
  - Folder EC/Winkelkar 0
    - Folder dto 0
      - File Winkelkar.cls.xml 1 Remove
    - Folder impl 0
      - File MaatwerkLijnBuilder.cls.xml 0 Remove
      - File WinkelkarService.cls.xml 1 Remove
    - File WinkelkarService.cls.xml 0 Remove
  - Folder EDI/PrijsBerekening/impl 0
    - File PrijsBerekeningService.cls.xml 0 Remove
  - Folder VKP/impl 0
    - File OfferteService.cls.xml 0 Remove
- Folder WS/EC/Winkelkar 0
  - File WinkelkarService.cls.xml 0 Remove
- Folder WSimpl/Vhisie4/Winkelkar 0
  - Folder WinkelkarService 0
    - File BewaarMaatwerkLijn.cls.xml 0 Remove
  - File EconConfiguratieConverter.cls.xml 0 Remove
  - File WinkelkarRepository.cls.xml 0 Remove
- Folder vhTest 0
  - Folder Fake 0
    - Folder APPS/EC/Winkelkar/impl 0
      - File WinkelkarService.cls.xml 0 Remove
    - Folder WSimpl/Vhisie4/Winkelkar 0
      - File EconConfiguratieConverter.cls.xml 0 Remove
      - File WinkelkarRepository.cls.xml 0 Remove
  - Folder Mock 0
    - Folder APPS/EC/Winkelkar 0
      - Folder impl 0
        
        File MaatwerkLijnBuilder.cls.xml 0 Remove
        
        File WinkelkarService.cls.xml 0 Remove
      - File WinkelkarService.cls.xml 0 Remove
    - Folder WSimpl/Vhisie4/Winkelkar 0
      - File EconConfiguratieConverter.cls.xml 0 Remove
      - File WinkelkarRepository.cls.xml 0 Remove
- Folder vhUnitTest 0
  - Folder APPS 0
    - Folder EC 0
      - Folder Verkoop/impl/Externe/VerkoopService 0
        
        File Base.cls.xml 0 Remove
      - Folder Winkelkar 0
        
        Folder WinkelkarService 0
        
        Folder WijzigMaatwerklijn 0
        
        File Test.cls.xml 0 Remove
        
        File TestHandel.cls.xml 0 Remove
        
        File TestVanHoecke.cls.xml 0 Remove
        
        Folder impl/WinkelkarService 0
        
        Folder WijzigMeerdereMaatwerkLijnen 0
        
        File Test.cls.xml 0 Remove
        
        File Base.cls.xml 0 Remove
    - Folder VKP 0
      - Folder impl/OfferteService/VoegToeMaatwerk 0
        
        File Test.cls.xml 1 Remove
      - File TestVerkoopService.cls.xml 0 Remove
  - Folder WSimpl/Vhisie4/Winkelkar 0
    - Folder EconConfiguratieConverter 0 Remove
      - File Test.cls.xml 0 Remove
    - Folder WinkelkarService/BewaarMaatwerkLijn 0
      - File Test.cls.xml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Kurt Callebaut	Author & Moderator	7m
Jo Claes	Reviewer - Complete	20m	3 (3 defects)	Dummy terminologie is hier niet meer juist.. daar het ove...
Total		27m	3 (3 defects)

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/vhTest/Mock/.../impl/WinkelkarService.cls.xml Deleted

Click to load diff

/vhUnitTest/.../Winkelkar/EconConfiguratieConverter/ Added

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-46

[UST2064] Vh4_SVC: BewaarMaatwerkLijn

CR-46 3

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

[UST2064] Vh4_SVC: BewaarMaatwerkLijn

CR-46 3

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against