CR-468 [UST2398] Vh4: OPC: Alle klanten op Vhisie4 omschakelen

closed on 28 Aug 17

Author

Moderator

Reviewers

[UST2398] Vh4: OPC: Alle klanten op Vhisie4 omschakelen

Activity

Details
Objectives
General Comments 3
Unresolved
Resolved
Number of files included: 14

CacheAdminA_trunk2010 (root:) 0
- Folder APPS/Blum/impl 0
  - Folder OnlineProductConfigurator 0
    - File KlantBepaler.cls.xml 2 Remove
  - File OnlineProductConfiguratorService.cls.xml 0 Remove
- Folder WSdata/Vhisie4/Winkelkar 0
  - File KlantenBepaler.cls.xml 0 Remove
- Folder vhTest 0
  - Folder Fake 0
    - Folder APPS/Blum/impl/OnlineProductConfigurator 0
      - File KlantBepaler.cls.xml 0 Remove
    - Folder WSdata/Vhisie4/Winkelkar 0
      - File KlantenBepaler.cls.xml 0 Remove
  - Folder Mock 0
    - Folder APPS/Blum/impl/OnlineProductConfigurator 0
      - File KlantBepaler.cls.xml 0 Remove
    - Folder WSdata/Vhisie4/Winkelkar 0
      - File KlantenBepaler.cls.xml 0 Remove
- Folder vhUnitTest 0
  - Folder APPS/Blum/impl 0
    - Folder OnlineProductConfigurator/KlantBepaler 0
      - File Test.cls.xml 0 Remove
    - Folder OnlineProductConfiguratorService 0
      - File Test.cls.xml 0 Remove
  - Folder WSdata 0 Remove
    - Folder Vhisie4 0 Remove
      - Folder Winkelkar 0 Remove
        
        Folder KlantenBepaler 0 Remove
        
        File Test.cls.xml 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Kurt Callebaut	Author & Moderator	3m
Jo Claes	Reviewer - Complete	8m	5 (5 defects)	APPS.Blum.OnlineProductConfigurator.enu.KlantType -> Vhis...
Total		11m	5 (5 defects)

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Jo Claes

APPS.Blum.impl.UserCartValidator wordt niet meer gebruikt -> mag weg -> alsoo...

APPS.Blum.impl.UserCartValidator wordt niet meer gebruikt -> mag weg -> alsook de bijhorende testen

Defect Classification: Cleanup Ranking: Minor

25 Aug 17

Jo Claes

Unresolved

25 Aug 17

Jo Claes

APPS.Blum.impl.OnlineProductConfigurator.OPCWinkelkarNaarFlowOfferteConvertee...

APPS.Blum.impl.OnlineProductConfigurator.OPCWinkelkarNaarFlowOfferteConverteerder wordt niet meer gebruikt -> mag weg -> alsook de bijhorende testen

Defect Ranking: Minor Classification: Cleanup

25 Aug 17

Jo Claes

Unresolved

25 Aug 17

Jo Claes

APPS.Blum.OnlineProductConfigurator.enu.KlantType -> Vhisie3 is niet meer van...

APPS.Blum.OnlineProductConfigurator.enu.KlantType -> Vhisie3 is niet meer van toepassing -> best ook eens naar de DISPLAYLIST kijken

Defect Ranking: Major Classification: Factually incorrect

25 Aug 17

Jo Claes

Unresolved

25 Aug 17

Click to load diff

/WSdata/.../Winkelkar/KlantenBepaler.cls.xml Deleted

Click to load diff

/vhTest/.../Winkelkar/KlantenBepaler.cls.xml Deleted

Click to load diff

/vhTest/.../Winkelkar/KlantenBepaler.cls.xml Deleted

Click to load diff

/vhUnitTest/.../Winkelkar/KlantenBepaler/ Deleted

Click to load diff

/vhUnitTest/.../KlantenBepaler/Test.cls.xml Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-468

[UST2398] Vh4: OPC: Alle klanten op Vhisie4 omschakelen

CR-468 5

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jo Claes

Jo Claes

Jo Claes

Log time against

[UST2398] Vh4: OPC: Alle klanten op Vhisie4 omschakelen

CR-468 5

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Jo Claes

Jo Claes

Jo Claes

Log time against