CR-511 [UST2758] Vh4: Geldigheid prijzen: beslag-winkelkarren niet controleren en BestelWinkelkar

closed on 12 Sep 17

Author

Moderator

Reviewers

[UST2758] Vh4: Geldigheid prijzen: beslag-winkelkarren niet controleren en...

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 17

CacheAdminA_trunk2010 (root:) 0
- Folder APPS 0
  - Folder EC 0
    - Folder Verkoop 0
      - Folder impl 0
        
        File OfferteVoorBestellingValidator.cls.xml 0 Remove
      - File OfferteVoorBestellingValidator.cls.xml 0 Remove
    - Folder Winkelkar 0
      - File WinkelkarControleur.cls.xml 1 Remove
    - Folder impl/ExterneVerkoopService 0
      - File OfferteBesteller.cls.xml 0 Remove
  - Folder VKP/Offerte/impl 0
    - File OfferteNietMeerGeldigException.cls.xml 3 Remove
  - Folder common/impl 0
    - File Validator.cls.xml 2 Remove
- Folder vhTest 0
  - Folder Fake/APPS/EC/Winkelkar 0
    - File WinkelkarControleur.cls.xml 0 Remove
  - Folder Mock/APPS/EC 0
    - Folder Verkoop 0
      - File OfferteVoorBestellingValidator.cls.xml 0 Remove
    - Folder Winkelkar 0
      - File WinkelkarControleur.cls.xml 0 Remove
- Folder vhUnitTest 0
  - Folder APPS/EC 0
    - Folder UNI/SFS/impl/OrderServiceInternal/ConfirmOrder 0
      - File Test2.cls.xml 0 Remove
    - Folder Verkoop/impl/Externe/VerkoopService 0
      - Folder GeefOfferteEnHerberekenIndienNodig 0
        
        File Test.cls.xml 0 Remove
      - Folder OfferteVoorBestellingValidator 0
        
        File TestBase.cls.xml 0 Remove
        
        File TestVH.cls.xml 1 Remove
        
        File TestValideer.cls.xml 0 Remove
    - Folder impl/ExterneVerkoopService 0
      - Folder OfferteBesteller 0 Remove
        
        File Test.cls.xml 1 Remove
  - Folder WSimpl/EC/Unishop/OrderConfirmation/Service/ConfirmOrder 0
    - File Test2.cls.xml 1 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Kurt Callebaut	Author & Moderator	31m	3	excepties van gemaakt.
Jo Claes	Reviewer - Complete	28m	6 (5 defects)	LeverDatum als %String terwijl de interface zegt dat het ...
Total		59m	9 (5 defects)

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/vhUnitTest/.../OfferteVoorBestellingValidator/TestValideer.cls.xml Deleted

Click to load diff

/vhUnitTest/.../ExterneVerkoopService/OfferteBesteller/ Added

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: Crucible Review CR-1
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

CR-511

[UST2758] Vh4: Geldigheid prijzen: beslag-winkelkarren niet controleren en...

CR-511 9

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against

[UST2758] Vh4: Geldigheid prijzen: beslag-winkelkarren niet controleren en...

CR-511 9

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time against