Index: vhUnitTest/WSimpl/Halux/AAP/DnaCodeService/DnaCodeAfmelden/Test.cls.xml =================================================================== diff -u -r73833 -r73854 --- vhUnitTest/WSimpl/Halux/AAP/DnaCodeService/DnaCodeAfmelden/Test.cls.xml (.../Test.cls.xml) (revision 73833) +++ vhUnitTest/WSimpl/Halux/AAP/DnaCodeService/DnaCodeAfmelden/Test.cls.xml (.../Test.cls.xml) (revision 73854) @@ -7,13 +7,14 @@ @@ -71,13 +66,14 @@ @@ -175,6 +165,7 @@ Set DnaCode1 = ##class(DOM.Halux.AAP.DnaCode).%New() Set DnaCode1.Toelevering = "222222" + Set DnaCode1.Lijn = 1 #dim DnaCodeIteratorEenStuk As TECH.Iterator = ##class(TECH.ListUtils).CreateIteratorOfObjects(DnaCode1) Set DnaCodeRepositoryMock = ##class(vhTest.Mock.DOM.Halux.AAP.DnaCodeRepository).%New() Do DnaCodeRepositoryMock.IndienMethodCall("ZoekViaDnaCodeEnRecent",Request.DnaCode).DanReturn(DnaCodeIteratorEenStuk) @@ -189,13 +180,8 @@ Set DocumentGeneratorMock = ##class(vhTest.Mock.APPS.Halux.Afmelden.impl.DocumentLadeGerecepteerdNaarObjective).%New() Do DocumentGeneratorMock.VerwachtMethodCall("GenereerDocumentVoorObjective", DnaCode1.DnaCode).DanDoeNiks() - #dim BatchServiceMock As vhTest.Mock.APPS.Halux.common.BatchService = ##class(vhTest.Mock.APPS.Halux.common.BatchService).%New() - #dim BatchMock As vhTest.Mock.APPS.Halux.common.Batch = ##class(vhTest.Mock.APPS.Halux.common.Batch).%New() - Do BatchMock.IndienMethodCall("GeefLijn").DanReturn(1) - Do BatchServiceMock.VerwachtMethodCall("GeefBatch",Request.BatchId).DanReturn(BatchMock) + Set DnaCodeService = ##class(WSimpl.Halux.AAP.DnaCodeService).%New(DnaCodeRepositoryMock,,,,,,, DnaCodeInVhossKastBepalerStub,,, ToeleveringServiceMock, DocumentGeneratorMock) - Set DnaCodeService = ##class(WSimpl.Halux.AAP.DnaCodeService).%New(DnaCodeRepositoryMock,,,,,,, DnaCodeInVhossKastBepalerStub,,, ToeleveringServiceMock, DocumentGeneratorMock,,BatchServiceMock) - #dim Antwoord As WS.Halux.AAP.DnaCodeAfmeldenResponse = DnaCodeService.DnaCodeAfmelden(Request) Do $$$AssertEquals(Antwoord.Header.Status,"200") @@ -204,7 +190,6 @@ Do DnaCodeRepositoryMock.Verifieer() Do ToeleveringServiceMock.Verifieer() Do DocumentGeneratorMock.Verifieer() - Do BatchServiceMock.Verifieer() ]]> @@ -273,12 +258,13 @@ Set Request = ##class(WS.Halux.AAP.DnaCodeAfmeldenRequest).%New() Set Request.DnaCode = "K00000A" Set Request.Toelevering = "356789" - Set Request.BatchId = 1234567 Set DnaCode1 = ##class(DOM.Halux.AAP.DnaCode).%New() Set DnaCode1.Toelevering = "222222" + Set DnaCode1.Lijn = 1 Set DnaCode2 = ##class(DOM.Halux.AAP.DnaCode).%New() Set DnaCode2.Toelevering = "222222" + Set DnaCode2.Lijn = 1 #dim DnaCodeIteratorEenStuk As TECH.Iterator = ##class(TECH.ListUtils).CreateIteratorOfObjects(DnaCode1) #dim DnaCodeIteratorTweeStuks As TECH.Iterator = ##class(TECH.ListUtils).CreateIteratorOfObjects(DnaCode1, DnaCode2) Set DnaCodeRepositoryMock = ##class(vhTest.Mock.DOM.Halux.AAP.DnaCodeRepository).%New() @@ -292,13 +278,8 @@ Set DocumentGeneratorMock = ##class(vhTest.Mock.APPS.Halux.Afmelden.impl.DocumentLadeGerecepteerdNaarObjective).%New() Do DocumentGeneratorMock.VerwachtMethodCall("GenereerDocumentVoorObjective",DnaCode1.DnaCode).DanDoeNiks() - #dim BatchServiceMock As vhTest.Mock.APPS.Halux.common.BatchService = ##class(vhTest.Mock.APPS.Halux.common.BatchService).%New() - #dim BatchMock As vhTest.Mock.APPS.Halux.common.Batch = ##class(vhTest.Mock.APPS.Halux.common.Batch).%New() - Do BatchMock.IndienMethodCall("GeefLijn").DanReturn(1) - Do BatchServiceMock.VerwachtMethodCall("GeefBatch",Request.BatchId).DanReturn(BatchMock) + Set DnaCodeService = ##class(WSimpl.Halux.AAP.DnaCodeService).%New(DnaCodeRepositoryMock,,,,,,,,,, ToeleveringServiceMock, DocumentGeneratorMock,) - Set DnaCodeService = ##class(WSimpl.Halux.AAP.DnaCodeService).%New(DnaCodeRepositoryMock,,,,,,,,,, ToeleveringServiceMock, DocumentGeneratorMock,,BatchServiceMock) - #dim Antwoord As WS.Halux.AAP.DnaCodeAfmeldenResponse = DnaCodeService.DnaCodeAfmelden(Request) Do $$$AssertEquals(Antwoord.Header.Status,"200") @@ -307,7 +288,6 @@ Do DnaCodeRepositoryMock.Verifieer() Do ToeleveringServiceMock.Verifieer() Do DocumentGeneratorMock.Verifieer() - Do BatchServiceMock.Verifieer() ]]> @@ -370,23 +350,25 @@ Set Request.DnaCode = "DnaCode" Set Request.Aantal = -1 Set Request.PalletCode = "TBX12345" - Set Request.BatchId = 1234567 Set DnaCode1 = ##class(DOM.Halux.AAP.DnaCode).%New() Set DnaCode1.Toelevering = "222222" Set DnaCode1.DnaCode = "DnaCode" Set DnaCode1.PalletCode = "TBX12345" Set DnaCode1.InitialenScanner = "XXX" + Set DnaCode1.Lijn = 1 Set DnaCode2 = ##class(DOM.Halux.AAP.DnaCode).%New() Set DnaCode2.Toelevering = "222222" Set DnaCode2.InitialenScanner = "XXX" + Set DnaCode1.Lijn = 1 Set AfgemeldeDnaCode = ##class(DOM.Halux.AAP.DnaCode).%New() Set AfgemeldeDnaCode.Toelevering = "222222" Set AfgemeldeDnaCode.DnaCode = "DnaCode" Set AfgemeldeDnaCode.InitialenScanner = "" Set AfgemeldeDnaCode.Status = ##class(DOM.Halux.AAP.enu.DnaCodeStatus).Ongedaan() + Set AfgemeldeDnaCode.Lijn = 1 #dim DnaCodeIteratorEenStuk As TECH.Iterator = ##class(TECH.ListUtils).CreateIteratorOfObjects(DnaCode1) #dim DnaCodeIteratorTweeStuks As TECH.Iterator = ##class(TECH.ListUtils).CreateIteratorOfObjects(DnaCode1, DnaCode2) @@ -401,13 +383,8 @@ Set DocumentGeneratorMock = ##class(vhTest.Mock.APPS.Halux.Afmelden.impl.DocumentLadeGerecepteerdNaarObjective).%New() Do DocumentGeneratorMock.VerwachtMethodCall("GenereerDocumentVoorObjective",DnaCode1.DnaCode).DanDoeNiks() - #dim BatchServiceMock As vhTest.Mock.APPS.Halux.common.BatchService = ##class(vhTest.Mock.APPS.Halux.common.BatchService).%New() - #dim BatchMock As vhTest.Mock.APPS.Halux.common.Batch = ##class(vhTest.Mock.APPS.Halux.common.Batch).%New() - Do BatchMock.IndienMethodCall("GeefLijn").DanReturn(1) - Do BatchServiceMock.VerwachtMethodCall("GeefBatch",Request.BatchId).DanReturn(BatchMock) + Set DnaCodeService = ##class(WSimpl.Halux.AAP.DnaCodeService).%New(DnaCodeRepositoryMock,,,,,,,,,, ToeleveringServiceMock, DocumentGeneratorMock) - Set DnaCodeService = ##class(WSimpl.Halux.AAP.DnaCodeService).%New(DnaCodeRepositoryMock,,,,,,,,,, ToeleveringServiceMock, DocumentGeneratorMock,,BatchServiceMock) - #dim Antwoord As WS.Halux.AAP.DnaCodeAfmeldenResponse = DnaCodeService.DnaCodeAfmelden(Request) Do $$$AssertEquals(Antwoord.Header.Status,"200") @@ -416,7 +393,6 @@ Do DnaCodeRepositoryMock.Verifieer() Do ToeleveringServiceMock.Verifieer() Do DocumentGeneratorMock.Verifieer() - Do BatchServiceMock.Verifieer() ]]> @@ -425,10 +401,10 @@ Set Request = ##class(WS.Halux.AAP.DnaCodeAfmeldenRequest).%New() Set Request.DnaCode = "DnaCode" Set Request.Locatie = $$$DummyString - Set Request.BatchId = 1234567 Set DnaCode1 = ##class(DOM.Halux.AAP.DnaCode).%New() Set DnaCode1.Toelevering = "222222" + Set DnaCode1.Lijn = 1 #dim DnaCodeIteratorEenStuk As TECH.Iterator = ##class(TECH.ListUtils).CreateIteratorOfObjects(DnaCode1) Set DnaCodeRepositoryMock = ##class(vhTest.Mock.DOM.Halux.AAP.DnaCodeRepository).%New() Do DnaCodeRepositoryMock.IndienMethodCall("ZoekViaDnaCodeEnRecent",Request.DnaCode).DanReturn(DnaCodeIteratorEenStuk) @@ -441,13 +417,8 @@ Set DocumentGeneratorMock = ##class(vhTest.Mock.APPS.Halux.Afmelden.impl.DocumentLadeGerecepteerdNaarObjective).%New() Do DocumentGeneratorMock.VerwachtMethodCall("GenereerDocumentVoorObjective",DnaCode1.DnaCode).DanDoeNiks() - #dim BatchServiceMock As vhTest.Mock.APPS.Halux.common.BatchService = ##class(vhTest.Mock.APPS.Halux.common.BatchService).%New() - #dim BatchMock As vhTest.Mock.APPS.Halux.common.Batch = ##class(vhTest.Mock.APPS.Halux.common.Batch).%New() - Do BatchMock.IndienMethodCall("GeefLijn").DanReturn(1) - Do BatchServiceMock.VerwachtMethodCall("GeefBatch",Request.BatchId).DanReturn(BatchMock) + Set DnaCodeService = ##class(WSimpl.Halux.AAP.DnaCodeService).%New(DnaCodeRepositoryMock,,,,,,,,,, ToeleveringServiceMock, DocumentGeneratorMock,) - Set DnaCodeService = ##class(WSimpl.Halux.AAP.DnaCodeService).%New(DnaCodeRepositoryMock,,,,,,,,,, ToeleveringServiceMock, DocumentGeneratorMock,,BatchServiceMock) - #dim Antwoord As WS.Halux.AAP.DnaCodeAfmeldenResponse = DnaCodeService.DnaCodeAfmelden(Request) Do $$$AssertEquals(Antwoord.Header.Status,"200") @@ -456,7 +427,6 @@ Do DnaCodeRepositoryMock.Verifieer() Do ToeleveringServiceMock.Verifieer() Do DocumentGeneratorMock.Verifieer() - Do BatchServiceMock.Verifieer() ]]> @@ -465,20 +435,22 @@ Set Request = ##class(WS.Halux.AAP.DnaCodeAfmeldenRequest).%New() Set Request.DnaCode = "DnaCode" Set Request.Locatie = $$$DummyString - Set Request.BatchId = 1234567 Set DnaCode1 = ##class(DOM.Halux.AAP.DnaCode).%New() Set DnaCode1.Toelevering = "222222" Set DnaCode1.DnaCode = "LAAAAA1" Set DnaCode1.ParentDnaCode = "LBBBBB1" + Set DnaCode1.Lijn = 1 Set DnaCode2 = ##class(DOM.Halux.AAP.DnaCode).%New() Set DnaCode2.Toelevering = "222222" Set DnaCode2.DnaCode = "LBBBBB1" Set DnaCode2.ParentDnaCode = "LBBBBB1" + Set DnaCode2.Lijn = 1 Set DnaCode3 = ##class(DOM.Halux.AAP.DnaCode).%New() Set DnaCode3.Toelevering = "222222" Set DnaCode3.DnaCode = "LCCCCC1" Set DnaCode3.ParentDnaCode = "LBBBBB1" + Set DnaCode3.Lijn = 1 #dim DnaCodeIteratorEenStuk As TECH.Iterator = ##class(TECH.ListUtils).CreateIteratorOfObjects(DnaCode1) #dim DnaCodeIteratorDrieStuks As TECH.Iterator = ##class(TECH.ListUtils).CreateIteratorOfObjects(DnaCode1,DnaCode2,DnaCode3) Set DnaCodeRepositoryMock = ##class(vhTest.Mock.DOM.Halux.AAP.DnaCodeRepository).%New() @@ -495,13 +467,8 @@ Set DocumentGeneratorMock = ##class(vhTest.Mock.APPS.Halux.Afmelden.impl.DocumentLadeGerecepteerdNaarObjective).%New() Do DocumentGeneratorMock.VerwachtMethodCall("GenereerDocumentVoorObjective",DnaCode1.DnaCode).DanDoeNiks() - #dim BatchServiceMock As vhTest.Mock.APPS.Halux.common.BatchService = ##class(vhTest.Mock.APPS.Halux.common.BatchService).%New() - #dim BatchMock As vhTest.Mock.APPS.Halux.common.Batch = ##class(vhTest.Mock.APPS.Halux.common.Batch).%New() - Do BatchMock.IndienMethodCall("GeefLijn").DanReturn(1) - Do BatchServiceMock.VerwachtMethodCall("GeefBatch",Request.BatchId).DanReturn(BatchMock) + Set DnaCodeService = ##class(WSimpl.Halux.AAP.DnaCodeService).%New(DnaCodeRepositoryMock,,,,,,,,,, ToeleveringServiceMock, DocumentGeneratorMock,) - Set DnaCodeService = ##class(WSimpl.Halux.AAP.DnaCodeService).%New(DnaCodeRepositoryMock,,,,,,,,,, ToeleveringServiceMock, DocumentGeneratorMock,,BatchServiceMock) - #dim Antwoord As WS.Halux.AAP.DnaCodeAfmeldenResponse = DnaCodeService.DnaCodeAfmelden(Request) Do $$$AssertEquals(Antwoord.Header.Status,"200") @@ -510,18 +477,17 @@ Do DnaCodeRepositoryMock.Verifieer() Do ToeleveringServiceMock.Verifieer() Do DocumentGeneratorMock.Verifieer() - Do BatchServiceMock.Verifieer() ]]> Index: WSimpl/Halux/AAP/DnaCodeService.cls.xml =================================================================== diff -u -r73833 -r73854 --- WSimpl/Halux/AAP/DnaCodeService.cls.xml (.../DnaCodeService.cls.xml) (revision 73833) +++ WSimpl/Halux/AAP/DnaCodeService.cls.xml (.../DnaCodeService.cls.xml) (revision 73854) @@ -93,13 +93,8 @@ 1 - -APPS.Halux.common.BatchService -1 - - -DnaCodeRepository:DOM.Halux.AAP.DnaCodeRepository="",PalletCodeValidator:WSimpl.Halux.AAP.DnaCodeService.PalletCodeValidator="",InventarisService:APPS.MAG.Inventaris.impl.InventarisService,DocsV1:BL.PPS.TBX.DocsV1="",KlantinstellingenRepository:DOM.Halux.AAP.KlantinstellingenRepository="",VerkoopAPI:DOM.VKP.VerkoopAPI="",AantalGescandeVhossSequentieItemsBepaler:WSimpl.Halux.AAP.DnaCodeService.AantalGescandeVhossSequentieItemsBepaler="",DnaCodeInVhossKastBepaler:WSimpl.Halux.AAP.DnaCodeService.DnaCodeInVhossKastBepaler="",SequentieService:APPS.Halux.common.impl.SequentieService="",RondAfVhossKastHelper:WSimpl.Halux.AAP.DnaCodeService.RondAfVhossKastHelper="",ToeleveringService:DOM.AKP.ToeleveringService="",DocumentGenerator:APPS.Halux.Afmelden.impl.DocumentLadeGerecepteerdNaarObjective="",DnaCodeHelper:APPS.Halux.AAP.DnaCodeService.DnaCodeServiceHelper="",BatchService:APPS.Halux.common.BatchService="" +DnaCodeRepository:DOM.Halux.AAP.DnaCodeRepository="",PalletCodeValidator:WSimpl.Halux.AAP.DnaCodeService.PalletCodeValidator="",InventarisService:APPS.MAG.Inventaris.impl.InventarisService,DocsV1:BL.PPS.TBX.DocsV1="",KlantinstellingenRepository:DOM.Halux.AAP.KlantinstellingenRepository="",VerkoopAPI:DOM.VKP.VerkoopAPI="",AantalGescandeVhossSequentieItemsBepaler:WSimpl.Halux.AAP.DnaCodeService.AantalGescandeVhossSequentieItemsBepaler="",DnaCodeInVhossKastBepaler:WSimpl.Halux.AAP.DnaCodeService.DnaCodeInVhossKastBepaler="",SequentieService:APPS.Halux.common.impl.SequentieService="",RondAfVhossKastHelper:WSimpl.Halux.AAP.DnaCodeService.RondAfVhossKastHelper="",ToeleveringService:DOM.AKP.ToeleveringService="",DocumentGenerator:APPS.Halux.Afmelden.impl.DocumentLadeGerecepteerdNaarObjective="",DnaCodeHelper:APPS.Halux.AAP.DnaCodeService.DnaCodeServiceHelper="" 1 1 %Status @@ -122,7 +117,6 @@ Set ..DocumentGenerator = $$$Inject(DocumentGenerator, ##class(APPS.Halux.Afmelden.impl.DocumentLadeGerecepteerdNaarObjective).%New()) Set ..DnaCodeHelper = $$$Inject(DnaCodeHelper, ##class(APPS.Halux.AAP.DnaCodeService.DnaCodeServiceHelper).%New()) Set ..MESService = ##class(APPS.Halux.PPS.MES.MESService).%New() - Set ..BatchService = $$$Inject(BatchService, ##class(APPS.Halux.common.impl.BatchService).%New()) Quit $$$OK ]]> @@ -394,8 +388,7 @@ Do ..DnaCodeRepository.Bewaar(DnaCode) #dim MesFaseActief As %Integer = 1 - #dim Batch As APPS.Halux.common.Batch = ..BatchService.GeefBatch(DnaCodeAfmeldenRequest.BatchId) - If (..MESService.IsActiefVoorMes(Batch.GeefLijn(), MesFaseActief)) { + If (..MESService.IsActiefVoorMes(DnaCode.Lijn, MesFaseActief)) { #dim IsDnaCodeVoorSpaceStep As %Boolean = ..DnaCodeHelper.IsSpaceStepGeneriekProduct(DnaCode, DnaCode.ProductNummer) If $$$Not(IsDnaCodeVoorSpaceStep) { Do ..DocumentGenerator.GenereerDocumentVoorObjective(DnaCode.DnaCode)