Index: vhUnitTest/APPS/Halux/PPS/Document/impl/common/BatchNaarObjective/OptieGenerator/RollenEnStuklijstOptiesGeneratorLbx/GenereerOptiesVoorLade/Test.cls.xml =================================================================== diff -u -r74458 -r74472 --- vhUnitTest/APPS/Halux/PPS/Document/impl/common/BatchNaarObjective/OptieGenerator/RollenEnStuklijstOptiesGeneratorLbx/GenereerOptiesVoorLade/Test.cls.xml (.../Test.cls.xml) (revision 74458) +++ vhUnitTest/APPS/Halux/PPS/Document/impl/common/BatchNaarObjective/OptieGenerator/RollenEnStuklijstOptiesGeneratorLbx/GenereerOptiesVoorLade/Test.cls.xml (.../Test.cls.xml) (revision 74472) @@ -57,12 +57,8 @@ Set HalffabItemBoomMock = ##class(vhTest.Mock.DOM.PM.Maatwerk.Calc.HF.HalffabItemsBoom).%New() Do HalffabItemBoomMock.VerwachtMethodCall("GeefAlleHalffabItemsIterator").DanReturn(HalffabItemsIterator) - #dim BatchPitchExportedVolgnummer As %String = 100 - Set BatchPitchExported = ##class(APPS.Halux.Planning.Pitching.BatchPitchExported).%New() - Set BatchPitchExported.Volgnummer = BatchPitchExportedVolgnummer - Set BatchPitchExported.LijnNummer = 1 - #dim BatchPitchExportedLijst As %ListOfObjects = ##class(TECH.ListUtils).CreateListOfObjects(BatchPitchExported) - #dim BatchPitchExportedServiceMock As vhTest.Mock.APPS.Halux.Planning.Pitching.impl.BatchPitchExportedService = ..GeefBatchPitchExportedServiceMock(..#BatchId, BatchPitchExportedLijst) + Set BatchServiceMock = ##class(vhTest.Mock.APPS.Halux.common.BatchService).%New() + Do BatchServiceMock.VerwachtMethodCall("GeefLijn").DanReturn(1) Set ProductMock = ##class(vhTest.Mock.DOM.PM.MaatwerkProduct).%New() Do ProductMock.VerwachtMethodCall("GeefIngegevenKenmerken").DanReturn(..LbxKenmerken) @@ -74,7 +70,7 @@ Do ProductApiMock.VerwachtMethodCall("GeefIdentNummerVoorProductId", ..#HFProductId2).DanReturn(..#HFIdentnummer2) Set ..UitvoeringInfo.BatchID = ..#BatchId - Set Generator = ##class(APPS.Halux.PPS.Document.impl.common.BatchNaarObjective.OptieGenerator.RollenEnStuklijstOptiesGenerator).%New(ProductApiMock, BatchPitchExportedServiceMock) + Set Generator = ##class(APPS.Halux.PPS.Document.impl.common.BatchNaarObjective.OptieGenerator.RollenEnStuklijstOptiesGenerator).%New(ProductApiMock, BatchServiceMock) #dim Resultaat As %ListOfObjects = Generator.GenereerOptiesVoorLade(, ..UitvoeringInfo) Do $$$AssertEquals(Resultaat.Size, 5) @@ -87,7 +83,7 @@ Do HalffabItemBoomMock.Verifieer() Do ProductMock.Verifieer() Do ProductApiMock.Verifieer() - Do BatchPitchExportedServiceMock.Verifieer() + Do BatchServiceMock.Verifieer() ]]> @@ -106,12 +102,8 @@ Set HalffabItemBoomMock = ##class(vhTest.Mock.DOM.PM.Maatwerk.Calc.HF.HalffabItemsBoom).%New() Do HalffabItemBoomMock.VerwachtMethodCall("GeefAlleHalffabItemsIterator").DanReturn(HalffabItemsIterator) - #dim BatchPitchExportedVolgnummer As %String = 100 - Set BatchPitchExported = ##class(APPS.Halux.Planning.Pitching.BatchPitchExported).%New() - Set BatchPitchExported.Volgnummer = BatchPitchExportedVolgnummer - Set BatchPitchExported.LijnNummer = 1 - #dim BatchPitchExportedLijst As %ListOfObjects = ##class(TECH.ListUtils).CreateListOfObjects(BatchPitchExported) - #dim BatchPitchExportedServiceMock As vhTest.Mock.APPS.Halux.Planning.Pitching.impl.BatchPitchExportedService = ..GeefBatchPitchExportedServiceMock(..#BatchId, BatchPitchExportedLijst) + Set BatchServiceMock = ##class(vhTest.Mock.APPS.Halux.common.BatchService).%New() + Do BatchServiceMock.VerwachtMethodCall("GeefLijn").DanReturn(1) Set ProductMock = ##class(vhTest.Mock.DOM.PM.MaatwerkProduct).%New() Do ProductMock.VerwachtMethodCall("GeefIngegevenKenmerken").DanReturn(LbxKenmerken) @@ -122,7 +114,7 @@ Do ProductApiMock.VerwachtMethodCall("GeefIdentNummerVoorProductId", ..#HFProductId2).DanReturn(..#HFIdentnummer2) Set ..UitvoeringInfo.BatchID = ..#BatchId - Set Generator = ##class(APPS.Halux.PPS.Document.impl.common.BatchNaarObjective.OptieGenerator.RollenEnStuklijstOptiesGenerator).%New(ProductApiMock, BatchPitchExportedServiceMock) + Set Generator = ##class(APPS.Halux.PPS.Document.impl.common.BatchNaarObjective.OptieGenerator.RollenEnStuklijstOptiesGenerator).%New(ProductApiMock, BatchServiceMock) #dim Resultaat As %ListOfObjects = Generator.GenereerOptiesVoorLade(, ..UitvoeringInfo) Do $$$AssertEquals(Resultaat.Size, 3) @@ -133,7 +125,7 @@ Do HalffabItemBoomMock.Verifieer() Do ProductMock.Verifieer() Do ProductApiMock.Verifieer() - Do BatchPitchExportedServiceMock.Verifieer() + Do BatchServiceMock.Verifieer() ]]> @@ -148,12 +140,8 @@ Set HalffabItemBoomMock = ##class(vhTest.Mock.DOM.PM.Maatwerk.Calc.HF.HalffabItemsBoom).%New() Do HalffabItemBoomMock.VerwachtMethodCall("GeefAlleHalffabItemsIterator").DanReturn(HalffabItemsIterator) - #dim BatchPitchExportedVolgnummer As %String = 100 - Set BatchPitchExported = ##class(APPS.Halux.Planning.Pitching.BatchPitchExported).%New() - Set BatchPitchExported.Volgnummer = BatchPitchExportedVolgnummer - Set BatchPitchExported.LijnNummer = 1 - #dim BatchPitchExportedLijst As %ListOfObjects = ##class(TECH.ListUtils).CreateListOfObjects(BatchPitchExported) - #dim BatchPitchExportedServiceMock As vhTest.Mock.APPS.Halux.Planning.Pitching.impl.BatchPitchExportedService = ..GeefBatchPitchExportedServiceMock(..#BatchId, BatchPitchExportedLijst) + Set BatchServiceMock = ##class(vhTest.Mock.APPS.Halux.common.BatchService).%New() + Do BatchServiceMock.VerwachtMethodCall("GeefLijn").DanReturn(1) Set ProductMock = ##class(vhTest.Mock.DOM.PM.MaatwerkProduct).%New() Do ProductMock.VerwachtMethodCall("GeefIngegevenKenmerken").DanReturn(..LbxKenmerken) @@ -164,7 +152,7 @@ Do ProductApiMock.VerwachtMethodCall("GeefIdentNummerVoorProductId", ..#HFProductId1).ExactAantalKeer(0) Set ..UitvoeringInfo.BatchID = ..#BatchId - Set Generator = ##class(APPS.Halux.PPS.Document.impl.common.BatchNaarObjective.OptieGenerator.RollenEnStuklijstOptiesGenerator).%New(ProductApiMock, BatchPitchExportedServiceMock) + Set Generator = ##class(APPS.Halux.PPS.Document.impl.common.BatchNaarObjective.OptieGenerator.RollenEnStuklijstOptiesGenerator).%New(ProductApiMock, BatchServiceMock) #dim Resultaat As %ListOfObjects = Generator.GenereerOptiesVoorLade(, ..UitvoeringInfo) Do $$$AssertEquals(Resultaat.Size, 1) @@ -173,7 +161,7 @@ Do HalffabItemBoomMock.Verifieer() Do ProductMock.Verifieer() Do ProductApiMock.Verifieer() - Do BatchPitchExportedServiceMock.Verifieer() + Do BatchServiceMock.Verifieer() ]]> Index: APPS/Halux/PPS/Document/impl/common/BatchNaarObjective/HoofdDataGenerator.cls.xml =================================================================== diff -u -r74411 -r74472 --- APPS/Halux/PPS/Document/impl/common/BatchNaarObjective/HoofdDataGenerator.cls.xml (.../HoofdDataGenerator.cls.xml) (revision 74411) +++ APPS/Halux/PPS/Document/impl/common/BatchNaarObjective/HoofdDataGenerator.cls.xml (.../HoofdDataGenerator.cls.xml) (revision 74472) @@ -145,6 +145,7 @@ } Else { Set TekstVelden.LeveradresDetails = LeverAdres.GeefStraat()_LeverAdres.GeefPostcode()_LeverAdres.GeefGemeente() Set TekstVelden.LeveradresLand = LeverAdres.GeefLandNr() + Set TekstVelden.ProductieLijn = ..GeefWaardeOfNull(Batch.GeefLijn()) } Set TekstVelden.VerkoopOrderId = ..GeefWaardeOfNull(Order.GeefAxSalesId()) Index: APPS/Halux/PPS/Document/impl/common/BatchNaarObjective/OptieGenerator/RollenEnStuklijstOptiesGenerator.cls.xml =================================================================== diff -u -r74458 -r74472 --- APPS/Halux/PPS/Document/impl/common/BatchNaarObjective/OptieGenerator/RollenEnStuklijstOptiesGenerator.cls.xml (.../RollenEnStuklijstOptiesGenerator.cls.xml) (revision 74458) +++ APPS/Halux/PPS/Document/impl/common/BatchNaarObjective/OptieGenerator/RollenEnStuklijstOptiesGenerator.cls.xml (.../RollenEnStuklijstOptiesGenerator.cls.xml) (revision 74472) @@ -13,21 +13,21 @@ 1 - -APPS.Halux.Planning.Pitching.impl.BatchPitchExportedService + +APPS.Halux.common.BatchService 1 -ProductApi:DOM.PM.ProductAPI="",BatchPitchExportedService:APPS.Halux.Planning.Pitching.impl.BatchPitchExportedService="" +ProductApi:DOM.PM.ProductAPI="",BatchService:APPS.Halux.common.BatchService="" 1 1 %Status 1 @@ -48,7 +48,7 @@ #dim HalffabItemsIterator As TECH.Iterator = HalffabItemsBoom.GeefAlleHalffabItemsIterator() #dim Index As %Integer = 0 #dim StalenRugPRNr As %String = "" - #dim ProductieLijn As %String = ..GeefProductieLijn(UitvoeringInfo.BatchID) + #dim ProductieLijn As %String = ..BatchService.GeefBatch(UitvoeringInfo.BatchID).GeefLijn() While (HalffabItemsIterator.HasNext()) { #dim HalffabItem As DOM.PM.Maatwerk.Calc.HF.IHalffabItem = HalffabItemsIterator.Next() @@ -136,41 +136,18 @@ ]]> - -BatchId:%String -1 -%Integer - - - - -BatchId:%String -1 -APPS.Halux.Planning.Pitching.BatchPitchExported - - - ProductieLijn:%String,StalenugPRNr:%String 1 %Boolean