Index: APPS/PM/KenmerkenService.cls.xml =================================================================== diff -u -r2064 -r2140 --- APPS/PM/KenmerkenService.cls.xml (.../KenmerkenService.cls.xml) (revision 2064) +++ APPS/PM/KenmerkenService.cls.xml (.../KenmerkenService.cls.xml) (revision 2140) @@ -27,9 +27,13 @@ -MasterUnIDs:%ListOfDataTypes +MasterUnIDs:%ListOfDataTypes,KenmerkGroep:%String APPS.PM.dto.Kenm.AutoVariantenVanMasters + + +KenmerkGroep:%String +1 +%Boolean + 1) HeeftProdMulti = 1 + Quit HeeftProdMulti +]]> + Index: DOM/common/dto/ProductData.cls.xml =================================================================== diff -u -r2084 -r2140 --- DOM/common/dto/ProductData.cls.xml (.../ProductData.cls.xml) (revision 2084) +++ DOM/common/dto/ProductData.cls.xml (.../ProductData.cls.xml) (revision 2140) @@ -5,10 +5,6 @@ %RegisteredObject,%XML.Adaptor 0 - -%String - - %String @@ -21,12 +17,20 @@ %String + +%String + + %String DOM.common.dto.ClassificatieData + + +APPS.PM.dto.ProductAfbeeldingen + Index: APPS/common/DataService.cls.xml =================================================================== diff -u -r2084 -r2140 --- APPS/common/DataService.cls.xml (.../DataService.cls.xml) (revision 2084) +++ APPS/common/DataService.cls.xml (.../DataService.cls.xml) (revision 2140) @@ -89,7 +89,6 @@ Set ProductData.IdentNr = Product.GeefIdentNr() Set ProductData.Omschrijving = Product.GeefLangtekst("N") Set ProductData.Classificatie = ..GeefClassificatieData(ProductAPI.GeefProductClassificatie(ProductID).GeefClassificatie().GeefID()) - Set ProductData.ClassificatieID = ProductData.Classificatie.ID Quit ProductData ]]> Index: vhUnitTest/APPS/PM/TestKenmerkenService.cls.xml =================================================================== diff -u -r2064 -r2140 --- vhUnitTest/APPS/PM/TestKenmerkenService.cls.xml (.../TestKenmerkenService.cls.xml) (revision 2064) +++ vhUnitTest/APPS/PM/TestKenmerkenService.cls.xml (.../TestKenmerkenService.cls.xml) (revision 2140) @@ -83,10 +83,11 @@ + + + + + + +Test met foutieve kenmerkgroep + + + Test het verwijderen van een kenmerkenset, waardoor er nog twee multiple kenmerkensets overschieten. @@ -650,5 +687,26 @@ Do $$$AssertEquals(Sets.Count(),2,"Er zijn twee multiple producten aanwezig voor PRNr 1023") ]]> + + + +Testen op fout indien geen correcte kenmerkengroep is meegegeven voor sets te creeren + + Index: WS/PM/KenmerkenService.cls.xml =================================================================== diff -u -r2131 -r2140 --- WS/PM/KenmerkenService.cls.xml (.../KenmerkenService.cls.xml) (revision 2131) +++ WS/PM/KenmerkenService.cls.xml (.../KenmerkenService.cls.xml) (revision 2140) @@ -19,14 +19,15 @@ -MasterUnIDs:%ListOfDataTypes +MasterUnIDs:%ListOfDataTypes,KenmerkGroep:%String APPS.PM.dto.Kenm.AutoVariantenVanMasters 1 Index: APPS/PM/dto/ProductIDsControleResult.cls.xml =================================================================== diff -u -r1073 -r2140 --- APPS/PM/dto/ProductIDsControleResult.cls.xml (.../ProductIDsControleResult.cls.xml) (revision 1073) +++ APPS/PM/dto/ProductIDsControleResult.cls.xml (.../ProductIDsControleResult.cls.xml) (revision 2140) @@ -11,7 +11,7 @@ -APPS.PM.dto.ProductIDs +DOM.common.dto.ProductData list Index: vhUnitTest/APPS/PM/TestProductService.cls.xml =================================================================== diff -u -r1820 -r2140 --- vhUnitTest/APPS/PM/TestProductService.cls.xml (.../TestProductService.cls.xml) (revision 1820) +++ vhUnitTest/APPS/PM/TestProductService.cls.xml (.../TestProductService.cls.xml) (revision 2140) @@ -221,7 +221,7 @@ Set ProductIt = ##class(TECH.ListIterator).%New(ProductenLijst) While (ProductIt.HasNext()){ Set ProductID = ProductIt.Next() - Set Product = ##class(DOM.DomeinContext).Instance().GeefProductAPI().GeefProduct(ProductID.PRNr) + Set Product = ##class(DOM.DomeinContext).Instance().GeefProductAPI().GeefProduct(ProductID.ID) Set Multiples = Product.GeefMultiples() Set MultipleIt = ##class(TECH.ListIterator).%New(Multiples) While (MultipleIt.HasNext()){ @@ -237,7 +237,7 @@ Set JuistType = 1 } } - Do $$$AssertTrue(JuistType,"Het product "_ProductID.PRNr_" heeft een juist generatietype.") + Do $$$AssertTrue(JuistType,"Het product "_ProductID.ID_" heeft een juist generatietype.") } } } @@ -374,19 +374,19 @@ Set HerkendeProducten = ProductIDsControleResult.HerkendeProducten - Do $$$AssertEquals(HerkendeProducten.GetAt(1).PRNr,137136,"PRNr 137136 van eerste herkend product is corrrect.") + Do $$$AssertEquals(HerkendeProducten.GetAt(1).ID,137136,"PRNr 137136 van eerste herkend product is corrrect.") Do $$$AssertEquals(HerkendeProducten.GetAt(1).Korttekst,"BAN.4.BU 2072x681x587 EV","Korttekst 'BAN.4.BU 2072x681x587 EV' van eerste product is corrrect.") Do $$$AssertEquals(HerkendeProducten.GetAt(1).IdentNr,"9.371.360.1","IdentNr '9.371.360.1' van eerste product is corrrect.") - Do $$$AssertEquals(HerkendeProducten.GetAt(2).PRNr,411830,"PRNr 411830 van tweede herkend product is corrrect.") + Do $$$AssertEquals(HerkendeProducten.GetAt(2).ID,411830,"PRNr 411830 van tweede herkend product is corrrect.") Do $$$AssertEquals(HerkendeProducten.GetAt(2).Korttekst,"SD1.PH BU 400X1","Korttekst 'SD1.PH BU 400X1' van tweede product is corrrect.") Do $$$AssertEquals(HerkendeProducten.GetAt(2).IdentNr,"9.118.303.4","IdentNr '9.118.303.4' van tweede product is corrrect.") - Do $$$AssertEquals(HerkendeProducten.GetAt(3).PRNr,647511,"PRNr 647511 van derde herkend product is corrrect.") + Do $$$AssertEquals(HerkendeProducten.GetAt(3).ID,647511,"PRNr 647511 van derde herkend product is corrrect.") Do $$$AssertEquals(HerkendeProducten.GetAt(3).Korttekst,"RAI.U10BU VERZ","RAI.U10BU VERZ' van derde product is corrrect.") Do $$$AssertEquals(HerkendeProducten.GetAt(3).IdentNr,"9.475.114.6","IdentNr '9.475.114.6' van derde product is corrrect.") - Do $$$AssertEquals(HerkendeProducten.GetAt(4).PRNr,166448,"PRNr 166448 van vierde herkend product is corrrect.") + Do $$$AssertEquals(HerkendeProducten.GetAt(4).ID,166448,"PRNr 166448 van vierde herkend product is corrrect.") Do $$$AssertEquals(HerkendeProducten.GetAt(4).Korttekst,"BAN.4.GB912x1922x1174 EV","Korttekst 'BAN.4.GB912x1922x1174 EV' van vierde product is corrrect.") Do $$$AssertEquals(HerkendeProducten.GetAt(4).IdentNr,"9.664.481.1","IdentNr '9.664.481.1' van vierde product is corrrect.") ]]> @@ -433,7 +433,7 @@ Do $$$AssertEquals(ProductIDsControleResult.NietHerkendeProductIDs.Count(),0,"Er zijn geen niet herkende producten") Set HerkendeProducten = ProductIDsControleResult.HerkendeProducten - Do $$$AssertEquals(HerkendeProducten.GetAt(1).PRNr,"380928","PRNr 380928 van product is corrrect.") + Do $$$AssertEquals(HerkendeProducten.GetAt(1).ID,"380928","PRNr 380928 van product is corrrect.") Do $$$AssertEquals(HerkendeProducten.GetAt(1).Omschrijving,"Cuisio-Flex inzet set van 4 stuks ","Omschrijving van product is corrrect.") ]]> @@ -453,9 +453,9 @@ Do $$$AssertEquals(ProductIDsControleResult.NietHerkendeProductIDs.Count(),0,"Er zijn geen niet herkende producten") Set HerkendeProducten = ProductIDsControleResult.HerkendeProducten Do $$$AssertEquals(HerkendeProducten.Count(),2,"Er zijn twee producten gevonden.") - Do $$$AssertEquals(HerkendeProducten.GetAt(1).PRNr,"380928","PRNr 380928 van product is corrrect.") - Do $$$AssertEquals(HerkendeProducten.GetAt(1).ClassificatieID,"1190","ClassificatieID van product is corrrect.") - Do $$$AssertEquals(HerkendeProducten.GetAt(2).PRNr,"398706","PRNr 398706 van product is corrrect.") + Do $$$AssertEquals(HerkendeProducten.GetAt(1).ID,"380928","PRNr 380928 van product is corrrect.") + Do $$$AssertEquals(HerkendeProducten.GetAt(1).Classificatie.ID,"1190","ClassificatieID van product is corrrect.") + Do $$$AssertEquals(HerkendeProducten.GetAt(2).ID,"398706","PRNr 398706 van product is corrrect.") ]]> @@ -465,19 +465,19 @@ Index: vhUnitTest/common/TestDataService.cls.xml =================================================================== diff -u -r2084 -r2140 --- vhUnitTest/common/TestDataService.cls.xml (.../TestDataService.cls.xml) (revision 2084) +++ vhUnitTest/common/TestDataService.cls.xml (.../TestDataService.cls.xml) (revision 2140) @@ -72,7 +72,7 @@ Do $$$AssertEquals(ProductData.Code,"358M2702I Z LI V20IG/G","De product code") Do $$$AssertEquals(ProductData.IdentNr,"0.234.930.0","De ident nr") Do $$$AssertEquals(ProductData.Omschrijving,"Tandembox PLUS ladeprofiel links, staal, 270mm diep","De omschrijving") - Do $$$AssertEquals(ProductData.ClassificatieID,"409","De classificatie id") + Do $$$AssertEquals(ProductData.Classificatie.ID,"409","De classificatie id") Do $$$AssertTrue($IsObject(ProductData.Classificatie),"De classificatie is ingesteld") ]]> Index: APPS/PM/dto/Kenm/ProductKenmerkenSet.cls.xml =================================================================== diff -u -r1562 -r2140 --- APPS/PM/dto/Kenm/ProductKenmerkenSet.cls.xml (.../ProductKenmerkenSet.cls.xml) (revision 1562) +++ APPS/PM/dto/Kenm/ProductKenmerkenSet.cls.xml (.../ProductKenmerkenSet.cls.xml) (revision 2140) @@ -13,6 +13,11 @@ 1 + +%String +1 + + %String 1 Index: vhConsistency/Checks/MastersVarianten.cls.xml =================================================================== diff -u -r1834 -r2140 --- vhConsistency/Checks/MastersVarianten.cls.xml (.../MastersVarianten.cls.xml) (revision 1834) +++ vhConsistency/Checks/MastersVarianten.cls.xml (.../MastersVarianten.cls.xml) (revision 2140) @@ -16,6 +16,7 @@ Set KenmerkenService = ##class(APPS.PM.KenmerkenService).%New() Set MasterUnIDLijst = ##class(%ListOfDataTypes).%New() + Set KenmerkGroep = "OL" Set ProductAPI = ##class(DOM.DomeinContext).Instance().GeefProductAPI() Set ProductIterator = ProductAPI.GeefProductIterator() @@ -25,9 +26,9 @@ Set PRNr = Product.GeefPRNr() Set ProductKenmerken = ProductAPI.GeefProductKenmerken(PRNr) - If (ProductKenmerken.HeeftKenmerkGroep("OL")) + If (ProductKenmerken.HeeftKenmerkGroep(KenmerkGroep)) { - Set ProductKenmerkenSets = ProductKenmerken.GeefProductKenmerkenSets("OL") + Set ProductKenmerkenSets = ProductKenmerken.GeefProductKenmerkenSets(KenmerkGroep) Set KenmerkenSetsIterator = ProductKenmerkenSets.GeefProductKenmerkenSetIterator() If (KenmerkenSetsIterator.HasNext()) { @@ -36,12 +37,12 @@ /// Wijzigingen die binnen deze method lopen zullen echter niet in de bulk event komen, maar zullen allemaal single events zijn. If ((ProductKenmerkenSet.GeefKenmerkWaarden("GeneratieType").GetAt(1) = ##class(APPS.PM.enu.GeneratieType).Master())) { Do MasterUnIDLijst.Insert(PRNr) - Set AutoVariantenLijst = KenmerkenService.GeefAutoVariantenVanMasters(MasterUnIDLijst).GetAt(1).AutoVarianten + Set AutoVariantenLijst = KenmerkenService.GeefAutoVariantenVanMasters(MasterUnIDLijst,KenmerkGroep).GetAt(1).AutoVarianten Set AutoVariantenIterator = ##class(TECH.ListIterator).%New(AutoVariantenLijst) While (AutoVariantenIterator.HasNext()) { Set AutoVariantPRNr = AutoVariantenIterator.Next().PRNr - Set ProductKenmerkenSetsAuto = ProductAPI.GeefProductKenmerken(PRNr).GeefProductKenmerkenSets("OL") + Set ProductKenmerkenSetsAuto = ProductAPI.GeefProductKenmerken(PRNr).GeefProductKenmerkenSets(KenmerkGroep) If (ProductKenmerkenSets.GeefAantalSets() '= ProductKenmerkenSetsAuto.GeefAantalSets()) { Index: APPS/PM/ProductService.cls.xml =================================================================== diff -u -r1935 -r2140 --- APPS/PM/ProductService.cls.xml (.../ProductService.cls.xml) (revision 1935) +++ APPS/PM/ProductService.cls.xml (.../ProductService.cls.xml) (revision 2140) @@ -302,12 +302,12 @@ While(ProductIDIt.HasNext()){ Set ProductIDs = ProductIDIt.Next() If ($IsObject(ProductIDs)){ - If (PRNr = ProductIDs.PRNr){ + If (PRNr = ProductIDs.ID){ Set ReedsToegevoegd = 0 Set It = ##class(TECH.ListIterator).%New(ProductenLijst.HerkendeProducten) While It.HasNext() { Set ProductID = It.Next() - If ProductID.PRNr = ProductIDs.PRNr { + If ProductID.ID = ProductIDs.ID { Set ReedsToegevoegd = 1 } } @@ -417,22 +417,24 @@ Product:DOM.PM.Product -APPS.PM.dto.ProductIDs +DOM.common.dto.ProductData Index: APPS/PM/dto/Kenm/AutoVariantenVanMaster.cls.xml =================================================================== diff -u -r1735 -r2140 --- APPS/PM/dto/Kenm/AutoVariantenVanMaster.cls.xml (.../AutoVariantenVanMaster.cls.xml) (revision 1735) +++ APPS/PM/dto/Kenm/AutoVariantenVanMaster.cls.xml (.../AutoVariantenVanMaster.cls.xml) (revision 2140) @@ -14,7 +14,7 @@ -APPS.PM.dto.ProductIDs +DOM.common.dto.ProductData list