Index: vhUnitTest/APPS/TBXWeb/impl/VHEPNOrderHandlerMock.cls.xml =================================================================== diff -u -r320 -r388 --- vhUnitTest/APPS/TBXWeb/impl/VHEPNOrderHandlerMock.cls.xml (.../VHEPNOrderHandlerMock.cls.xml) (revision 320) +++ vhUnitTest/APPS/TBXWeb/impl/VHEPNOrderHandlerMock.cls.xml (.../VHEPNOrderHandlerMock.cls.xml) (revision 388) @@ -45,5 +45,12 @@ + + +1 +%String + + Index: APPS/TBXWeb/impl/VHEPNOrderHandler.cls.xml =================================================================== diff -u -r375 -r388 --- APPS/TBXWeb/impl/VHEPNOrderHandler.cls.xml (.../VHEPNOrderHandler.cls.xml) (revision 375) +++ APPS/TBXWeb/impl/VHEPNOrderHandler.cls.xml (.../VHEPNOrderHandler.cls.xml) (revision 388) @@ -95,14 +95,10 @@ %List + + + +1 +%String + %String - Index: vhUnitTest/APPS/TBXWeb/impl/TestOrderHandlers.cls.xml =================================================================== diff -u -r320 -r388 --- vhUnitTest/APPS/TBXWeb/impl/TestOrderHandlers.cls.xml (.../TestOrderHandlers.cls.xml) (revision 320) +++ vhUnitTest/APPS/TBXWeb/impl/TestOrderHandlers.cls.xml (.../TestOrderHandlers.cls.xml) (revision 388) @@ -82,15 +82,35 @@ 1 - + " + set ..MailLanguage = ##class(DOM.enu.Taal).Nederlands() + set ..OrderResultType = ##class(APPS.TBXWeb.enu.BonType).OfferteAanvraag() + set ..Implementatie = "VHEPNOrderHandler" + + set ..ValidBonTypes = $listbuild(##class(APPS.TBXWeb.enu.BonType).OfferteAanvraag()) + + do ..VoerUitTest() +]]> + + + +") + set ..MailTo = $listbuild("OV_WebOrder_Rxx-UT_KLNr_4645@vanhoecke.be") set ..MailFrom = """KlantNaam ("_##class(APPS.TBXWeb.enu.TBXHandel).VanHoecke()_")"" " set ..MailLanguage = ##class(DOM.enu.Taal).Nederlands() set ..OrderResultType = ##class(APPS.TBXWeb.enu.BonType).Bestelbon() @@ -102,21 +122,21 @@ ]]> - + ") - set ..MailFrom = """De onbekende soldaat"" " + set ..KlantNr = $$$TBoxWebKlantNrSFS + set ..KlantNaam = "KlantNaam ("_..Requester_")" + set ..IsAnoniemeGebruiker=0 + set ..MailTo = $listbuild("OV_WebOrder_Rxx-UT_KLNr_12486@vanhoecke.be") + set ..MailFrom = """KlantNaam ("_##class(APPS.TBXWeb.enu.TBXHandel).VanHoecke()_")"" " set ..MailLanguage = ##class(DOM.enu.Taal).Nederlands() - set ..OrderResultType = ##class(APPS.TBXWeb.enu.BonType).OfferteAanvraag() + set ..OrderResultType = ##class(APPS.TBXWeb.enu.BonType).Bestelbon() set ..Implementatie = "VHEPNOrderHandler" - set ..ValidBonTypes = $listbuild(##class(APPS.TBXWeb.enu.BonType).OfferteAanvraag()) + set ..ValidBonTypes = $listbuild(##class(APPS.TBXWeb.enu.BonType).Offerte()) do ..VoerUitTest() ]]> @@ -125,12 +145,12 @@ " set ..MailLanguage = ##class(DOM.enu.Taal).Nederlands() set ..ValidBonTypes = $listbuild(##class(APPS.TBXWeb.enu.BonType).Bestelbon()) @@ -146,12 +166,12 @@ " set ..MailLanguage = ##class(DOM.enu.Taal).Nederlands() set ..ValidBonTypes = $listbuild(##class(APPS.TBXWeb.enu.BonType).Bestelbon()) @@ -167,12 +187,12 @@ " set ..MailLanguage = ##class(DOM.enu.Taal).Nederlands() set ..ValidBonTypes = $listbuild(##class(APPS.TBXWeb.enu.BonType).Bestelbon()) @@ -188,12 +208,12 @@ " set ..MailLanguage = ##class(DOM.enu.Taal).Nederlands() @@ -209,12 +229,12 @@ ") + set ..IsAnoniemeGebruiker=1 + set ..MailTo = $listbuild("OV_WebOrder_Rxx-UT_KLNr_4598@vanhoecke.be") set ..MailLanguage = ##class(DOM.enu.Taal).Nederlands() set ..ValidBonTypes = $listbuild(##class(APPS.TBXWeb.enu.BonType).Bestelbon()) set ..MailFrom = """Destil TBX Inkoop"" " @@ -230,13 +250,13 @@ ") + set ..MailTo = $listbuild("OV_WebOrder_Rxx-UT_KLNr_6279@vanhoecke.be","ICT_SupportTBX@vanhoecke.be") ; $listbuild("""OV_TBX_OPTIMA"" ") set ..ValidBonTypes = $listbuild(##class(APPS.TBXWeb.enu.BonType).Bestelbon()) set ..MailFrom = """Extern TBX Aankoop"" " set ..OrderResultType = ##class(APPS.TBXWeb.enu.BonType).Inkooporder() @@ -253,7 +273,7 @@ set ..Shop = ##class(APPS.TBXWeb.enu.TBXHandel).SFS() set ..WebDomain = "tbx.sfsunimarket.biz" set ..Requester = ##class(APPS.TBXWeb.enu.TBXHandel).SFS() - set ..KlantNr = $$$TBoxWebKlantNrSFS + set ..KlantNr = 12345678 set ..KlantNaam = "KlantNaam ("_..Requester_")" set ..IsAnoniemeGebruiker=0 set ..MailTo = "" @@ -274,7 +294,7 @@ set ..Shop = ##class(APPS.TBXWeb.enu.TBXHandel).Kisch() set ..WebDomain = "tandembox.kisch.nl" set ..Requester = ##class(APPS.TBXWeb.enu.TBXHandel).Kisch() - set ..KlantNr = $$$TBoxWebKlantNrKISCH + set ..KlantNr = 12345678 set ..KlantNaam = "KlantNaam ("_..Requester_")" set ..IsAnoniemeGebruiker=0 set ..MailTo = $listbuild("""KISCH OV."" ", """KISCH OV."" ") @@ -295,7 +315,7 @@ set ..Shop = ##class(APPS.TBXWeb.enu.TBXHandel).MBHolland() set ..WebDomain = "tandembox.meubelbeslagholland.nl" set ..Requester = ##class(APPS.TBXWeb.enu.TBXHandel).MBHolland() - set ..KlantNr = $$$TBoxWebKlantNrMBHO + set ..KlantNr = 12345678 set ..KlantNaam = "KlantNaam ("_..Requester_")" set ..IsAnoniemeGebruiker=0 set ..MailTo = $listbuild("""MBHO OV."" ") @@ -316,7 +336,7 @@ set ..Shop = ##class(APPS.TBXWeb.enu.TBXHandel).Optima() set ..WebDomain = "www.optima-tbx.fr" set ..Requester = ##class(APPS.TBXWeb.enu.TBXHandel).Optima() - set ..KlantNr = $$$TBoxWebKlantNrOPTIMA + set ..KlantNr = 12345678 set ..KlantNaam = "KlantNaam ("_..Requester_")" set ..IsAnoniemeGebruiker=0 set ..MailTo = $listbuild("""LMC OV."" ") @@ -337,7 +357,7 @@ set ..Shop = ##class(APPS.TBXWeb.enu.TBXHandel).Destil() set ..WebDomain = "tbx.destil.nl" set ..Requester = ##class(APPS.TBXWeb.enu.TBXHandel).Destil() - set ..KlantNr = $$$TBoxWebKlantNrHELMY + set ..KlantNr = "" set ..KlantNaam = "KlantNaam ("_..Requester_")" set ..IsAnoniemeGebruiker=0 set ..MailTo = $listbuild("""Destil OV."" ","""Twan Peters"" ") @@ -353,7 +373,14 @@ ]]> - + + + + + " set ..MailLanguage = ##class(DOM.enu.Taal).Duits() set ..ValidBonTypes = $listbuild(##class(APPS.TBXWeb.enu.BonType).Offerte()) + set ..OrderResultType = ##class(APPS.TBXWeb.enu.BonType).Offerte() + set ..Implementatie = "HEINOrderHandler" + + do ..VoerUitOrderTestVoorBonType(##class(APPS.TBXWeb.enu.BonType).OfferteAanvraag()) + do ..VoerUitOrderTestVoorBonType(##class(APPS.TBXWeb.enu.BonType).Offerte()) + do ..VoerUitOrderTestVoorBonType(##class(APPS.TBXWeb.enu.BonType).Inkooporder()) + + do ..VoerUitGOTestVoorBonType(##class(APPS.TBXWeb.enu.BonType).OfferteAanvraag()) + do ..VoerUitGOTestVoorBonType(##class(APPS.TBXWeb.enu.BonType).Offerte()) + do ..VoerUitGOTestVoorBonType(##class(APPS.TBXWeb.enu.BonType).Inkooporder()) + quit +]]> + + + +") + set ..MailFrom = """KlantNaam (HEIN)"" " + set ..MailLanguage = ##class(DOM.enu.Taal).Duits() + set ..ValidBonTypes = $listbuild(##class(APPS.TBXWeb.enu.BonType).Bestelbon()) set ..OrderResultType = ##class(APPS.TBXWeb.enu.BonType).Bestelbon() set ..Implementatie = "HEINOrderHandler" - do ..VoerUitTest() + do ..VoerUitOrderTestVoorBonType(##class(APPS.TBXWeb.enu.BonType).OfferteAanvraag()) + do ..VoerUitOrderTestVoorBonType(##class(APPS.TBXWeb.enu.BonType).Bestelbon()) + do ..VoerUitOrderTestVoorBonType(##class(APPS.TBXWeb.enu.BonType).Inkooporder()) + + do ..VoerUitGOTestVoorBonType(##class(APPS.TBXWeb.enu.BonType).OfferteAanvraag()) + do ..VoerUitGOTestVoorBonType(##class(APPS.TBXWeb.enu.BonType).Bestelbon()) + do ..VoerUitGOTestVoorBonType(##class(APPS.TBXWeb.enu.BonType).Inkooporder()) quit ]]> @@ -433,10 +492,12 @@ if $$$AssertTrue(##class(TECH.StringUtils).StartsWith(impl.%ClassName(),..Implementatie),"controle implementatie "_..Requester) { do $$$AssertEquals(impl.WebServer(),..WebDomain,"Webserver voor "_..Requester) - do $$$AssertEquals(impl.GetOrderResultType(),..OrderResultType,"OrderResultType voor "_..Requester) do ..ControleBonType(impl,BonType) do ..ControleFoutInLijnen(impl,AbstractOrderID) + if ..IsValidBonType(BonType) { + do $$$AssertEquals(impl.GetOrderResultType(),..OrderResultType,"OrderResultType voor "_..Requester) + } ;do $$$AssertEquals(impl.GebruiktEmail(),$length(..MailFrom)>0,"de unittest data is consistent opgesteld") ;do $$$AssertEquals(impl.GebruiktEmail(),$length(..MailTo)>0,"de unittest data is consistent opgesteld") Index: APPS/TBXWeb/impl/AbstractOrderHandler.cls.xml =================================================================== diff -u -r337 -r388 --- APPS/TBXWeb/impl/AbstractOrderHandler.cls.xml (.../AbstractOrderHandler.cls.xml) (revision 337) +++ APPS/TBXWeb/impl/AbstractOrderHandler.cls.xml (.../AbstractOrderHandler.cls.xml) (revision 388) @@ -82,7 +82,7 @@ . Do ..Logger.ErrorMail("ORDERSTARTTYPE_INVALID",..WSOrd.%Id()_" : "_..WSOrd.BonType) If '(..IsValidWebDomain()) Do Quit $$$ERROR($$$GeneralError,"WSOrder has no valid WebDomain for this shop") - . Set Info = "WSOrd.WebDomain = *"_..WSOrd.WebDomain _"* "_"Requester = *"_..Requester_"*" + . Set Info = "WSOrd.WebDomain = *"_..GeefOrderDomein() _"* "_"Requester = *"_..Requester_"*" . Do ..Logger.ErrorMail("WEBDOMAIN_INVALID",Info) ; testen of order lijnen bevat die niet konden berekend worden. @@ -118,7 +118,7 @@ . Do ..Logger.ErrorMail("POSTPROCESSING_FAILED",$$ParseStatus^vhLib.System(stPostProcessing)) . Set lbExtras="" . Set lbExtras=lbExtras_$LB(..%ClassName(0)) - . Do ##class(cspBasis.GAProdTBox).AddToLog("SUBMIT_FAILED",..WSOrd.WebDomain,..WSOrd.KLNummer,"shop="_..Shop,..WSOrd.mID,..Requester,..Taal,,lbExtras) + . Do ##class(cspBasis.GAProdTBox).AddToLog("SUBMIT_FAILED",..GeefOrderDomein(),..WSOrd.KLNummer,"shop="_..Shop,..WSOrd.mID,..Requester,..Taal,,lbExtras) Do ..Logger.Info("ORDER_PROCESSED") @@ -128,7 +128,7 @@ %Boolean - @@ -172,6 +172,14 @@ %String + +1 +1 +%String + + + 1 %ListOfDataTypes @@ -200,7 +208,7 @@ . Set:($L($G(From))) lbExtras=lbExtras_$LB("MailFrom="_$TR(From,"""","")) . Set:($L($G(lbTo))) lbExtras=lbExtras_$LB("MailTo="_MailTo) . Set:($L(..WSOrd.Opmerking1)) lbExtras=lbExtras_$LB("MailComment="_..WSOrd.Opmerking1) - . Do ##class(cspBasis.GAProdTBox).AddToLog("MAIL_SEND",..WSOrd.WebDomain,..WSOrd.KLNummer,"shop="_..Shop,..WSOrd.mID,VERW,$G(Taal),,lbExtras) + . Do ##class(cspBasis.GAProdTBox).AddToLog("MAIL_SEND",..GeefOrderDomein(),..WSOrd.KLNummer,"shop="_..Shop,..WSOrd.mID,VERW,$G(Taal),,lbExtras) . Set Info = "From="_From_" To="_$$$LCVT(lbTo) . Do ..Logger.Info("MAIL_SEND",Info) Else Do @@ -276,9 +284,9 @@ 1 %String